)]}'
{"keystoneclient/tests/test_auth_token_middleware.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8e3ae79f840a10e1350e538bcb4eef932afceff2","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.middleware \u003d None"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        self.conf \u003d {"},{"line_number":241,"context_line":"            \u0027identity_uri\u0027: \u0027https://keystone.example.com:1234/testadmin/\u0027,"},{"line_number":242,"context_line":"            \u0027signing_dir\u0027: client_fixtures.CERTDIR,"},{"line_number":243,"context_line":"            \u0027auth_version\u0027: auth_version,"},{"line_number":244,"context_line":"            \u0027auth_uri\u0027: \u0027https://keystone.example.com:1234\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2Bxz0%3D","line":241,"updated":"2014-03-24 12:59:15.000000000","message":"Is the trailing slash necessary here?","commit_id":"93619b53a109d78eab2e2dd55d612c872746c6d7"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2b9b97c0283d444a52939ad1618d677cb08cdd97","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        self.assert_valid_request_200(self.token_dict[\u0027uuid_token_default\u0027])"},{"line_number":525,"context_line":"        self.assert_valid_last_url(self.token_dict[\u0027uuid_token_default\u0027])"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_valid_uuid_request_with_identity_uri(self):"},{"line_number":528,"context_line":"        for opt in [\u0027auth_host\u0027, \u0027auth_port\u0027, \u0027auth_protocol\u0027,"},{"line_number":529,"context_line":"                    \u0027auth_admin_prefix\u0027]:"},{"line_number":530,"context_line":"            del self.conf[opt]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BLKQ%3D","side":"PARENT","line":527,"updated":"2014-03-28 16:22:09.000000000","message":"any reason not to add a new test, instead of removing this seemingly-valid one?","commit_id":"708886b2c6bdd150c4d3dae16fb8807c19f7403c"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"17e9e2f8b2bcaa4087d85b1d50fb042f46c95f07","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        self.assert_valid_request_200(self.token_dict[\u0027uuid_token_default\u0027])"},{"line_number":525,"context_line":"        self.assert_valid_last_url(self.token_dict[\u0027uuid_token_default\u0027])"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def test_valid_uuid_request_with_identity_uri(self):"},{"line_number":528,"context_line":"        for opt in [\u0027auth_host\u0027, \u0027auth_port\u0027, \u0027auth_protocol\u0027,"},{"line_number":529,"context_line":"                    \u0027auth_admin_prefix\u0027]:"},{"line_number":530,"context_line":"            del self.conf[opt]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BH6Y%3D","side":"PARENT","line":527,"in_reply_to":"AAAAWH%2F%2BLKQ%3D","updated":"2014-03-29 04:11:58.000000000","message":"i added this test in the dependant review so that we could test both the new method and the old method. Now that we are updating everything else to use identity_uri we have plenty of tests that work like this - it\u0027s the auth fragments which is now the old method that we need to keep compatibility for.","commit_id":"708886b2c6bdd150c4d3dae16fb8807c19f7403c"}]}