)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-03-07 17:37:36 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Regions Management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5c1526457395ba3fb06977bea775ff572ec840ba"},{"line_number":10,"context_line":"Closes-Bug: 1289519"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAVn%2F%2FJgU%3D","line":8,"updated":"2014-03-08 05:11:39.000000000","message":"Might be helpful to add a little detail here saying this is gluing client code to v3 regions implementation. Especially with the addition of some new files.","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"}],"examples/scripts/exercise_v3_regions.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from keystoneclient.v3 import client"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJgI%3D","line":12,"updated":"2014-03-08 05:11:39.000000000","message":"Add description of what example details","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from keystoneclient.v3 import client"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BxHM%3D","line":12,"in_reply_to":"AAAAVn%2F%2FJgI%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"keystone_url \u003d \u0027http://localhost:35357/v3\u0027"},{"line_number":17,"context_line":"public_url \u003d \u0027http://localhost:5000/v3\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def build_admin_user(admin_client):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJgE%3D","line":17,"updated":"2014-03-08 05:11:39.000000000","message":"(NIT): Uppercase module level vars?","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"keystone_url \u003d \u0027http://localhost:35357/v3\u0027"},{"line_number":17,"context_line":"public_url \u003d \u0027http://localhost:5000/v3\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def build_admin_user(admin_client):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BxHQ%3D","line":17,"in_reply_to":"AAAAVn%2F%2FJgE%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def build_admin_user(admin_client):"},{"line_number":21,"context_line":"    #default domain already exists"},{"line_number":22,"context_line":"    default_domain \u003d admin_client.domains.get(\u0027default\u0027)"},{"line_number":23,"context_line":"    admin_project \u003d admin_client.projects.create("},{"line_number":24,"context_line":"        name\u003d\u0027admin\u0027, domain\u003ddefault_domain.id,"},{"line_number":25,"context_line":"        description\u003d\u0027For Administrative Actions Only\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJgM%3D","line":22,"updated":"2014-03-08 05:11:39.000000000","message":"Can we validate that \u0027default\u0027 domain exists?","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def build_admin_user(admin_client):"},{"line_number":21,"context_line":"    #default domain already exists"},{"line_number":22,"context_line":"    default_domain \u003d admin_client.domains.get(\u0027default\u0027)"},{"line_number":23,"context_line":"    admin_project \u003d admin_client.projects.create("},{"line_number":24,"context_line":"        name\u003d\u0027admin\u0027, domain\u003ddefault_domain.id,"},{"line_number":25,"context_line":"        description\u003d\u0027For Administrative Actions Only\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BxHY%3D","line":22,"in_reply_to":"AAAAVn%2F%2FJgM%3D","updated":"2014-03-24 15:41:28.000000000","message":"In general, yes, but doesn\u0027t belong in this script.  In this case, the whole script would error our, and it would be fairly clear why.","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"admin_client \u003d client.Client(endpoint\u003dkeystone_url,"},{"line_number":38,"context_line":"                             token\u003d\u0027freeipa4all\u0027)"},{"line_number":39,"context_line":"#build_admin_user(admin_client)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"admin_client.regions.create(id\u003d\u0027Australia\u0027,"},{"line_number":42,"context_line":"                            description\u003d\"The Island Continent\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJgA%3D","line":39,"updated":"2014-03-08 05:11:39.000000000","message":"remove commented out code","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"admin_client \u003d client.Client(endpoint\u003dkeystone_url,"},{"line_number":38,"context_line":"                             token\u003d\u0027freeipa4all\u0027)"},{"line_number":39,"context_line":"#build_admin_user(admin_client)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"admin_client.regions.create(id\u003d\u0027Australia\u0027,"},{"line_number":42,"context_line":"                            description\u003d\"The Island Continent\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BxHI%3D","line":39,"in_reply_to":"AAAAVn%2F%2FJgA%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c79ede8f2716494398509bb35ac94f0dbcaba6c5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            description\u003d\"New South Wales\","},{"line_number":47,"context_line":"                            parent_region_id\u003d\u0027Australia\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"admin_client.regions.create(id\u003d\u0027Sidney\u0027,"},{"line_number":50,"context_line":"                            description\u003d\"More than an Opera House\","},{"line_number":51,"context_line":"                            parent_region_id\u003d\u0027NSW\u0027)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F5Ps%3D","line":49,"updated":"2014-03-13 04:31:11.000000000","message":"\u0027Sydney\u0027","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            description\u003d\"New South Wales\","},{"line_number":47,"context_line":"                            parent_region_id\u003d\u0027Australia\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"admin_client.regions.create(id\u003d\u0027Sidney\u0027,"},{"line_number":50,"context_line":"                            description\u003d\"More than an Opera House\","},{"line_number":51,"context_line":"                            parent_region_id\u003d\u0027NSW\u0027)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BxKo%3D","line":49,"in_reply_to":"AAAAWH%2F%2F5Ps%3D","updated":"2014-03-24 15:41:28.000000000","message":"Did I really do that?","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                            parent_region_id\u003d\u0027NSW\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"admin_client.regions.create(id\u003d\u0027Oceana\u0027,"},{"line_number":54,"context_line":"                            description\u003d\"All that suff south and east of Asia\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"admin_client.regions.update(\u0027Australia\u0027, parent_region_id\u003d\u0027Oceana\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJf0%3D","line":54,"updated":"2014-03-08 05:11:39.000000000","message":"s/suff/stuff/","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                            parent_region_id\u003d\u0027NSW\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"admin_client.regions.create(id\u003d\u0027Oceana\u0027,"},{"line_number":54,"context_line":"                            description\u003d\"All that suff south and east of Asia\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"admin_client.regions.update(\u0027Australia\u0027, parent_region_id\u003d\u0027Oceana\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BxHE%3D","line":54,"in_reply_to":"AAAAVn%2F%2FJf0%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"dcbe3a156430129a45ca2ec6467b3f5b6311d188","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"admin_client \u003d client.Client(endpoint\u003dOS_SERVICE_ENDPOINT,"},{"line_number":39,"context_line":"                             token\u003d\u0027freeipa4all\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"admin_client.regions.create(id\u003d\u0027Australia\u0027,"},{"line_number":42,"context_line":"                            description\u003d\"The Island Continent\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BkQQ%3D","line":39,"updated":"2014-03-25 21:12:24.000000000","message":"not actually using the token here","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c3d7a67dfc5420580d37fa236aa8802f0875f3a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                             token\u003d\u0027freeipa4all\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"admin_client.regions.create(id\u003d\u0027Australia\u0027,"},{"line_number":42,"context_line":"                            description\u003d\"The Island Continent\")"},{"line_number":43,"context_line":"admin_client.regions.get(\u0027Australia\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"NSW \u003d admin_client.regions.create(id\u003d\u0027NSW\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BsQE%3D","line":42,"updated":"2014-03-25 02:05:10.000000000","message":"Switch to single quotes to be consistent with the rest of the usage in this module","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c3d7a67dfc5420580d37fa236aa8802f0875f3a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                            description\u003d\u0027The Island Continent Country\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"for region in admin_client.regions.list():"},{"line_number":60,"context_line":"    print(\"id \u003d %s, parent \u003d %s, description\u003d%s\" % ("},{"line_number":61,"context_line":"        region.id, region.parent_region_id, region.description))"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"admin_client.regions.delete(\u0027Sydney\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BsQA%3D","line":60,"updated":"2014-03-25 02:05:10.000000000","message":"same comment here if possible.","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"}],"keystoneclient/tests/v3/test_regions.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        kwargs \u003d super(RegionTests, self).new_ref(**kwargs)"},{"line_number":30,"context_line":"        kwargs.setdefault(\u0027enabled\u0027, True)"},{"line_number":31,"context_line":"        kwargs.setdefault(\u0027id\u0027, uuid.uuid4().hex)"},{"line_number":32,"context_line":"        #kwargs.setdefault(\u0027description\u0027, \"default\")"},{"line_number":33,"context_line":"        return kwargs"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJfw%3D","line":32,"updated":"2014-03-08 05:11:39.000000000","message":"remove commented out code.","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a4b3800715eeae1d2198d65505a0abe47f9d76ea","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import uuid"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FcDc%3D","line":11,"updated":"2014-04-21 19:40:10.000000000","message":"(NIT): spacing in copyright is different than in \n\nhttps://review.openstack.org/#/c/79096/6/keystoneclient/v3/regions.py\n\nsuggest modifying one to be consistent with the other.","commit_id":"2964180949e15beb98ffb43d3bd081ac22ce31d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"179b7f321b896c454fed5124b461cbc59845da2b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def new_ref(self, **kwargs):"},{"line_number":29,"context_line":"        kwargs \u003d super(RegionTests, self).new_ref(**kwargs)"},{"line_number":30,"context_line":"        kwargs.setdefault(\u0027enabled\u0027, True)"},{"line_number":31,"context_line":"        kwargs.setdefault(\u0027id\u0027, uuid.uuid4().hex)"},{"line_number":32,"context_line":"        return kwargs"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_list_filter_name(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2F1Jg%3D","line":31,"updated":"2014-04-17 05:36:10.000000000","message":"add fields for description and parent region?","commit_id":"2964180949e15beb98ffb43d3bd081ac22ce31d0"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"e37c51cea83b32cb420ae3c2380ad55ecec8ee3e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def new_ref(self, **kwargs):"},{"line_number":29,"context_line":"        kwargs \u003d super(RegionTests, self).new_ref(**kwargs)"},{"line_number":30,"context_line":"        kwargs.setdefault(\u0027enabled\u0027, True)"},{"line_number":31,"context_line":"        kwargs.setdefault(\u0027id\u0027, uuid.uuid4().hex)"},{"line_number":32,"context_line":"        return kwargs"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_list_filter_name(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FPmk%3D","line":31,"in_reply_to":"AAAAXH%2F%2F1Jg%3D","updated":"2014-04-23 03:29:47.000000000","message":"The test doesn\u0027t require them.  Adding them here would not increase the \"real\" ness of the test","commit_id":"2964180949e15beb98ffb43d3bd081ac22ce31d0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"11f130ccf56c9c3d302b509ca1ed60d1e1fa8358","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return kwargs"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def test_list_filter_name(self):"},{"line_number":36,"context_line":"        super(RegionTests, self).test_list(name\u003d\u0027aregion123\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_994e6695","line":36,"updated":"2014-05-02 16:43:20.000000000","message":"since regions don\u0027t have names, an inline comment explaining why you\u0027re overriding the parent method and why you\u0027re passing a name here would be appreciated.\n\nalso, change the value to a uuid","commit_id":"ebb03e25c8c35728d854ff8ad5c0cf7019ab7169"}],"keystoneclient/v3/regions.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright 2011 Nebula, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJfs%3D","line":1,"updated":"2014-03-08 05:11:39.000000000","message":"(NIT): Remove company copyrights?","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright 2011 Nebula, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bwfs%3D","line":1,"in_reply_to":"AAAAVn%2F%2FJfs%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"283b3cd2e870ed94d7abbd6f8b6351490e569df2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Copyright 2011 Nebula, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2B0U%3D","line":5,"updated":"2014-03-12 15:14:28.000000000","message":"really nitpicky, but theres a newer format for copyright:\nhttps://github.com/openstack/keystone/blob/master/keystone/contrib/revoke/controllers.py\nnote the space isnt doubled after hashes","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Copyright 2011 Nebula, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":7,"context_line":"#    a copy of the License at"},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bwfw%3D","line":5,"in_reply_to":"AAAAWH%2F%2F%2B0U%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":40,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def create(self, description\u003dNone, enabled\u003dTrue,"},{"line_number":43,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":44,"context_line":"        return super(RegionManager, self).create("},{"line_number":45,"context_line":"            description\u003ddescription, enabled\u003denabled,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJfc%3D","line":42,"updated":"2014-03-08 05:11:39.000000000","message":"add doc strings to be consistent with def list()\n\nRandom questions; should enabled be detailed here https://github.com/openstack/identity-api/blob/master/openstack-identity-api/v3/src/markdown/identity-api-v3.md#regions-v3regions ? \n\nI don\u0027t think regions has a column for \u0027enabled\u0027 https://github.com/openstack/keystone/blob/master/keystone/common/sql/migrate_repo/versions/037_add_region_table.py so wouldn\u0027t it get stuffed into \u0027extra\u0027?","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":40,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def create(self, description\u003dNone, enabled\u003dTrue,"},{"line_number":43,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":44,"context_line":"        return super(RegionManager, self).create("},{"line_number":45,"context_line":"            description\u003ddescription, enabled\u003denabled,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BwUU%3D","line":42,"in_reply_to":"AAAAVn%2F%2FJfc%3D","updated":"2014-03-24 15:41:28.000000000","message":"its in \"extra\"","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"899d765754f79983ffe9803cea435e16dd5305d2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":44,"context_line":"        return super(RegionManager, self).create("},{"line_number":45,"context_line":"            description\u003ddescription, enabled\u003denabled,"},{"line_number":46,"context_line":"            parent_region_id\u003dparent_region_id, **kwargs)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get(self, region):"},{"line_number":49,"context_line":"        return super(RegionManager, self).get("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FEXM%3D","line":46,"updated":"2014-03-10 08:21:51.000000000","message":"parent_region should be passed as an object and then use base.getid()","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":43,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":44,"context_line":"        return super(RegionManager, self).create("},{"line_number":45,"context_line":"            description\u003ddescription, enabled\u003denabled,"},{"line_number":46,"context_line":"            parent_region_id\u003dparent_region_id, **kwargs)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get(self, region):"},{"line_number":49,"context_line":"        return super(RegionManager, self).get("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Bweg%3D","line":46,"in_reply_to":"AAAAVn%2F%2FEXM%3D","updated":"2014-03-24 15:41:28.000000000","message":"That makes it ugly to default.","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c10444096dd31a9ce5830c5d04afb05740644e5c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            description\u003ddescription, enabled\u003denabled,"},{"line_number":46,"context_line":"            parent_region_id\u003dparent_region_id, **kwargs)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get(self, region):"},{"line_number":49,"context_line":"        return super(RegionManager, self).get("},{"line_number":50,"context_line":"            region_id\u003dbase.getid(region))"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJfg%3D","line":48,"updated":"2014-03-08 05:11:39.000000000","message":"add doc strings to be consistent with def list()","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"73e85625c7186d29e1c4379d38caf21b0067c58c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"List regions."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        If ``**kwargs`` are provided, then filter regions with"},{"line_number":56,"context_line":"        attributes matching ``**kwargs``."},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        return super(RegionManager, self).list("},{"line_number":59,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FJec%3D","line":56,"updated":"2014-03-08 05:24:28.000000000","message":"add unit test for this functionality, like here if possible: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/v3/test_domains.py#L33","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"List regions."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        If ``**kwargs`` are provided, then filter regions with"},{"line_number":56,"context_line":"        attributes matching ``**kwargs``."},{"line_number":57,"context_line":"        \"\"\""},{"line_number":58,"context_line":"        return super(RegionManager, self).list("},{"line_number":59,"context_line":"            **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BwVA%3D","line":56,"in_reply_to":"AAAAVn%2F%2FJec%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"899d765754f79983ffe9803cea435e16dd5305d2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":63,"context_line":"        return super(RegionManager, self).update("},{"line_number":64,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":65,"context_line":"            description\u003dNone, enabled\u003dTrue, parent_region_id\u003dNone,"},{"line_number":66,"context_line":"            **kwargs)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete(self, region):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FEW0%3D","line":65,"updated":"2014-03-10 08:21:51.000000000","message":"i don\u0027t think you mean \u003dNone and \u003dTrue here","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"47e01ccdb3024079c97f035caa6e64eb1583ce47","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":63,"context_line":"        return super(RegionManager, self).update("},{"line_number":64,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":65,"context_line":"            description\u003dNone, enabled\u003dTrue, parent_region_id\u003dNone,"},{"line_number":66,"context_line":"            **kwargs)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete(self, region):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2BweA%3D","line":65,"in_reply_to":"AAAAVn%2F%2FEW0%3D","updated":"2014-03-24 15:41:28.000000000","message":"Done","commit_id":"c7f5411793e596bbe5f8d550f5c34571a6e810d6"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"96e1c3d98feeaef35d5c51a08c4519c9956eccbc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        return super(RegionManager, self).list("},{"line_number":59,"context_line":"            **kwargs)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def update(self, region, description\u003dNone, enabled\u003dTrue,"},{"line_number":62,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":63,"context_line":"        return super(RegionManager, self).update("},{"line_number":64,"context_line":"            region_id\u003dbase.getid(region),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B%2F0Q%3D","line":61,"updated":"2014-03-21 03:27:16.000000000","message":"I think it is better that the default value of enabled parameter should be None. If the default value is True, when I just want to update the description the enabled will be updated to True too.","commit_id":"f94c827c8b7984056143304500de0e3170d26334"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"821071a6512a2de198aa4d85dfe18d7d688be501","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        return super(RegionManager, self).list("},{"line_number":59,"context_line":"            **kwargs)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def update(self, region, description\u003dNone, enabled\u003dTrue,"},{"line_number":62,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":63,"context_line":"        return super(RegionManager, self).update("},{"line_number":64,"context_line":"            region_id\u003dbase.getid(region),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BxMk%3D","line":61,"in_reply_to":"AAAAWH%2F%2B%2F0Q%3D","updated":"2014-03-24 15:41:20.000000000","message":"Updating the description on a disabled region seems wrong, but I see your point.  Shouldn\u0027t enable by mistake.","commit_id":"f94c827c8b7984056143304500de0e3170d26334"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"96e1c3d98feeaef35d5c51a08c4519c9956eccbc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":63,"context_line":"        return super(RegionManager, self).update("},{"line_number":64,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":65,"context_line":"            description\u003dNone, enabled\u003dTrue, parent_region_id\u003dNone,"},{"line_number":66,"context_line":"            **kwargs)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete(self, region):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B%2F0E%3D","line":65,"updated":"2014-03-21 03:27:16.000000000","message":"Here should be description\u003ddescription, enabled\u003denabled, parent_region_id\u003dparent_region_id.","commit_id":"f94c827c8b7984056143304500de0e3170d26334"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"821071a6512a2de198aa4d85dfe18d7d688be501","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               parent_region_id\u003dNone, **kwargs):"},{"line_number":63,"context_line":"        return super(RegionManager, self).update("},{"line_number":64,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":65,"context_line":"            description\u003dNone, enabled\u003dTrue, parent_region_id\u003dNone,"},{"line_number":66,"context_line":"            **kwargs)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete(self, region):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2BxP4%3D","line":65,"in_reply_to":"AAAAWH%2F%2B%2F0E%3D","updated":"2014-03-24 15:41:20.000000000","message":"Done","commit_id":"f94c827c8b7984056143304500de0e3170d26334"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c3d7a67dfc5420580d37fa236aa8802f0875f3a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        * id: a string that identifies the endpoint"},{"line_number":21,"context_line":"        * description: a string that describes the endpoint"},{"line_number":22,"context_line":"        * parent_region_id: string that is the id field for an pre-existing"},{"line_number":23,"context_line":"          region in the backend. Optional.   Allows for hierarchical region"},{"line_number":24,"context_line":"          organization"},{"line_number":25,"context_line":"        * enabled: determines whether the endpoint appears in the catalog."},{"line_number":26,"context_line":"          Defaults to True"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BsPs%3D","line":23,"updated":"2014-03-25 02:05:10.000000000","message":"multiple spaces before Allows","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c3d7a67dfc5420580d37fa236aa8802f0875f3a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"          region in the backend. Optional.   Allows for hierarchical region"},{"line_number":24,"context_line":"          organization"},{"line_number":25,"context_line":"        * enabled: determines whether the endpoint appears in the catalog."},{"line_number":26,"context_line":"          Defaults to True"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BsPw%3D","line":26,"updated":"2014-03-25 02:05:10.000000000","message":"Period after True.","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c3d7a67dfc5420580d37fa236aa8802f0875f3a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":36,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create(self, description\u003dNone, enabled\u003dNone,"},{"line_number":39,"context_line":"               parent_region\u003dNone, **kwargs):"},{"line_number":40,"context_line":"        return super(RegionManager, self).create("},{"line_number":41,"context_line":"            description\u003ddescription, enabled\u003denabled,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BsPY%3D","line":38,"updated":"2014-03-25 02:05:10.000000000","message":"NIT: add docstrings to be consistent with def list()","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"1a52051dc9849d390aeb3616e0993b4b2be6bb66","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":36,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create(self, description\u003dNone, enabled\u003dNone,"},{"line_number":39,"context_line":"               parent_region\u003dNone, **kwargs):"},{"line_number":40,"context_line":"        return super(RegionManager, self).create("},{"line_number":41,"context_line":"            description\u003ddescription, enabled\u003denabled,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2FmeU%3D","line":38,"in_reply_to":"AAAAWH%2F%2BsPY%3D","updated":"2014-04-11 20:46:18.000000000","message":"We don\u0027t do doc strings on each function unless we have something beyond the server side arg list to explain.  See v3/user.py","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7c3d7a67dfc5420580d37fa236aa8802f0875f3a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            description\u003ddescription, enabled\u003denabled,"},{"line_number":42,"context_line":"            parent_region_id\u003dbase.getid(parent_region), **kwargs)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get(self, region):"},{"line_number":45,"context_line":"        return super(RegionManager, self).get("},{"line_number":46,"context_line":"            region_id\u003dbase.getid(region))"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAWH%2F%2BsPk%3D","line":44,"updated":"2014-03-25 02:05:10.000000000","message":"NIT: add docstrings to be consistent with def list()","commit_id":"55e76a2a4ca875e1721a1891dd537ac92e135031"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"179b7f321b896c454fed5124b461cbc59845da2b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    Attributes:"},{"line_number":20,"context_line":"        * id: a string that identifies the endpoint"},{"line_number":21,"context_line":"        * description: a string that describes the endpoint"},{"line_number":22,"context_line":"        * parent_region_id: string that is the id field for an pre-existing"},{"line_number":23,"context_line":"          region in the backend. Optional.  Allows for hierarchical region"},{"line_number":24,"context_line":"          organization"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2F1JY%3D","line":21,"updated":"2014-04-17 05:36:10.000000000","message":"Add Optional. here too","commit_id":"2964180949e15beb98ffb43d3bd081ac22ce31d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"179b7f321b896c454fed5124b461cbc59845da2b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":36,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create(self, description\u003dNone, enabled\u003dNone,"},{"line_number":39,"context_line":"               parent_region\u003dNone, **kwargs):"},{"line_number":40,"context_line":"        return super(RegionManager, self).create("},{"line_number":41,"context_line":"            description\u003ddescription, enabled\u003denabled,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2F1I4%3D","line":38,"updated":"2014-04-17 05:36:10.000000000","message":"What about create region with user defined id?","commit_id":"2964180949e15beb98ffb43d3bd081ac22ce31d0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"179b7f321b896c454fed5124b461cbc59845da2b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            region_id\u003dbase.getid(region))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def list(self, **kwargs):"},{"line_number":49,"context_line":"        \"\"\"List regions."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        If ``**kwargs`` are provided, then filter regions with"},{"line_number":52,"context_line":"        attributes matching ``**kwargs``."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2F1JE%3D","line":49,"updated":"2014-04-17 05:36:10.000000000","message":"Why docstring for list only? Suggest create docstrings for all functions","commit_id":"2964180949e15beb98ffb43d3bd081ac22ce31d0"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"070cd4d8f0d134876adedc90ea513c7d6500ce83","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    collection_key \u003d \u0027regions\u0027"},{"line_number":36,"context_line":"    key \u003d \u0027region\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create(self, id\u003dNone, description\u003dNone, enabled\u003dNone,"},{"line_number":39,"context_line":"               parent_region\u003dNone, **kwargs):"},{"line_number":40,"context_line":"    # See Region class (above) for meaning of these parameters"},{"line_number":41,"context_line":"        return super(RegionManager, self).create("}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXH%2F%2FFmc%3D","line":38,"updated":"2014-04-24 05:53:40.000000000","message":"what is id doing? you don\u0027t use it anywhere","commit_id":"9838c4b2a4a34c9eec9568d9e36ed145fa9f7b79"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"070cd4d8f0d134876adedc90ea513c7d6500ce83","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        return super(RegionManager, self).update("},{"line_number":62,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":63,"context_line":"            description\u003ddescription, enabled\u003denabled,"},{"line_number":64,"context_line":"            parent_region_id\u003dparent_region_id,"},{"line_number":65,"context_line":"            **kwargs)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def delete(self, region):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAXH%2F%2FFmY%3D","line":64,"updated":"2014-04-24 05:53:40.000000000","message":"base.getid(parent_region)","commit_id":"9838c4b2a4a34c9eec9568d9e36ed145fa9f7b79"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"11f130ccf56c9c3d302b509ca1ed60d1e1fa8358","unresolved":false,"context_lines":[{"line_number":39,"context_line":"               parent_region\u003dNone, **kwargs):"},{"line_number":40,"context_line":"        \"\"\"Update a Catalog region."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            param :id: a string that identifies the region. If None, an"},{"line_number":43,"context_line":"                identifier will be generated for the region."},{"line_number":44,"context_line":"            param :description: a string that describes the region. Optional."},{"line_number":45,"context_line":"            param :parent_region: string that is the id field for a"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_143bfdd1","line":42,"updated":"2014-05-02 16:43:20.000000000","message":"if not specified","commit_id":"ebb03e25c8c35728d854ff8ad5c0cf7019ab7169"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"11f130ccf56c9c3d302b509ca1ed60d1e1fa8358","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"\"\"Update a Catalog region."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            param :id: a string that identifies the region. If None, an"},{"line_number":43,"context_line":"                identifier will be generated for the region."},{"line_number":44,"context_line":"            param :description: a string that describes the region. Optional."},{"line_number":45,"context_line":"            param :parent_region: string that is the id field for a"},{"line_number":46,"context_line":"                pre-existing region in the backend. Optional.  Allows for"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_1414dd42","line":43,"updated":"2014-05-02 16:43:20.000000000","message":".. a unique identifier will be assigned to ..","commit_id":"ebb03e25c8c35728d854ff8ad5c0cf7019ab7169"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"11f130ccf56c9c3d302b509ca1ed60d1e1fa8358","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            param :description: a string that describes the region. Optional."},{"line_number":45,"context_line":"            param :parent_region: string that is the id field for a"},{"line_number":46,"context_line":"                pre-existing region in the backend. Optional.  Allows for"},{"line_number":47,"context_line":"                hierarchical region organization."},{"line_number":48,"context_line":"            param :enabled: determines whether the endpoint appears in the"},{"line_number":49,"context_line":"                catalog. Defaults to True"},{"line_number":50,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_d458b534","line":47,"updated":"2014-05-02 16:43:20.000000000","message":"the method signature already indicates these are both optional","commit_id":"ebb03e25c8c35728d854ff8ad5c0cf7019ab7169"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"11f130ccf56c9c3d302b509ca1ed60d1e1fa8358","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                pre-existing region in the backend. Optional.  Allows for"},{"line_number":47,"context_line":"                hierarchical region organization."},{"line_number":48,"context_line":"            param :enabled: determines whether the endpoint appears in the"},{"line_number":49,"context_line":"                catalog. Defaults to True"},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        return super(RegionManager, self).create("},{"line_number":52,"context_line":"            id\u003did, description\u003ddescription, enabled\u003denabled,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_b42a517c","line":49,"updated":"2014-05-02 16:43:20.000000000","message":"the default here is redundant with the method signature - remove it","commit_id":"ebb03e25c8c35728d854ff8ad5c0cf7019ab7169"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"11f130ccf56c9c3d302b509ca1ed60d1e1fa8358","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        return super(RegionManager, self).update("},{"line_number":82,"context_line":"            region_id\u003dbase.getid(region),"},{"line_number":83,"context_line":"            description\u003ddescription, enabled\u003denabled,"},{"line_number":84,"context_line":"            parent_region_id\u003dbase.getid(parent_region),"},{"line_number":85,"context_line":"            **kwargs)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad9bd40_343d61bc","line":83,"updated":"2014-05-02 16:43:20.000000000","message":"it\u0027d be nice if enabled was on it\u0027s own line, rather than mixing/matching line break styles","commit_id":"ebb03e25c8c35728d854ff8ad5c0cf7019ab7169"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d4fb2d12ac62dfae6be7d4a369c95a414ea2e9f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \"\"\"Update a Catalog region."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            param :id: a string that identifies the region. If not specified,"},{"line_number":43,"context_line":"             a unique identifier will be assigned to the region."},{"line_number":44,"context_line":"            param :description: a string that describes the region. Optional."},{"line_number":45,"context_line":"            param :parent_region: string that is the id field for a"},{"line_number":46,"context_line":"                pre-existing region in the backend. Allows for"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_541e0960","line":43,"updated":"2014-05-06 19:06:11.000000000","message":"nit: inconsistent indentation, i doubt the docs will build correctly","commit_id":"8bb56be9deb581fe0fbd4371660867152e4d517a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d4fb2d12ac62dfae6be7d4a369c95a414ea2e9f1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            param :region: a string that identifies the region."},{"line_number":73,"context_line":"            param :description: a string that describes the region. Optional."},{"line_number":74,"context_line":"            param :parent_region: string that is the id field for a"},{"line_number":75,"context_line":"                pre-existing"},{"line_number":76,"context_line":"                region in the backend. Optional.  Allows for hierarchical"},{"line_number":77,"context_line":"                region organization."},{"line_number":78,"context_line":"            param :enabled: determines whether the endpoint appears in the"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad9bd40_144f216c","line":75,"updated":"2014-05-06 19:06:11.000000000","message":"clean this up?","commit_id":"8bb56be9deb581fe0fbd4371660867152e4d517a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0dfbec4b2f8b62ab371905cc3286ddcb15fd7fd3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            param :region: a string that identifies the region."},{"line_number":73,"context_line":"            param :description: a string that describes the region. Optional."},{"line_number":74,"context_line":"            param :parent_region: string that is the id field for a"},{"line_number":75,"context_line":"            pre-existing"},{"line_number":76,"context_line":"            region in the backend. Optional.  Allows for hierarchical"},{"line_number":77,"context_line":"            region organization."},{"line_number":78,"context_line":"            param :enabled: determines whether the endpoint appears in the"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad9bd40_4afca272","line":75,"updated":"2014-05-06 20:18:08.000000000","message":"another nit here as \u0027pre-existing\u0027 is on it\u0027s own line.","commit_id":"7ce29cb45f4b4c6a943fdcc94e89e429c9ea44fb"}]}