)]}'
{"keystoneclient/tests/v3/test_services.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"75f9000e666e61df7144dd79558f3b469539f960","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        kwargs \u003d super(ServiceTests, self).new_ref(**kwargs)"},{"line_number":29,"context_line":"        kwargs.setdefault(\u0027name\u0027, uuid.uuid4().hex)"},{"line_number":30,"context_line":"        kwargs.setdefault(\u0027type\u0027, uuid.uuid4().hex)"},{"line_number":31,"context_line":"        kwargs.setdefault(\u0027description\u0027, uuid.uuid4().hex)"},{"line_number":32,"context_line":"        kwargs.setdefault(\u0027enabled\u0027, True)"},{"line_number":33,"context_line":"        return kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_e4750033","line":31,"updated":"2014-05-22 21:02:22.000000000","message":"why was this change made? I tried removing the line and the tests pass.","commit_id":"20d4b72c65546d2a69cec91b781d7ccf4ad70fb1"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"bbdd279c361c29c5800001ea77565f8fff8a13c8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        kwargs \u003d super(ServiceTests, self).new_ref(**kwargs)"},{"line_number":29,"context_line":"        kwargs.setdefault(\u0027name\u0027, uuid.uuid4().hex)"},{"line_number":30,"context_line":"        kwargs.setdefault(\u0027type\u0027, uuid.uuid4().hex)"},{"line_number":31,"context_line":"        kwargs.setdefault(\u0027description\u0027, uuid.uuid4().hex)"},{"line_number":32,"context_line":"        kwargs.setdefault(\u0027enabled\u0027, True)"},{"line_number":33,"context_line":"        return kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"7adec928_503f35d6","line":31,"in_reply_to":"7adec928_e4750033","updated":"2014-05-23 17:22:53.000000000","message":"Done","commit_id":"20d4b72c65546d2a69cec91b781d7ccf4ad70fb1"}],"keystoneclient/v3/services.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"20b1e8b26e15876533531ac1c4d373b4acf5366e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    collection_key \u003d \u0027services\u0027"},{"line_number":37,"context_line":"    key \u003d \u0027service\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, type, description, enabled\u003dTrue, **kwargs):"},{"line_number":40,"context_line":"        return super(ServiceManager, self).create("},{"line_number":41,"context_line":"            name\u003dname,"},{"line_number":42,"context_line":"            type\u003dtype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FwcE%3D","line":39,"updated":"2014-03-14 00:47:14.000000000","message":"can\u0027t add a required field. You need at least to have \u003dNone.","commit_id":"b693b30120327a18e1ac2f2d15b10cb7b5e040ff"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"7f8a29d5ceb76590d87b8eab5a6aa325a6962dda","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    collection_key \u003d \u0027services\u0027"},{"line_number":37,"context_line":"    key \u003d \u0027service\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, type, description, enabled\u003dTrue, **kwargs):"},{"line_number":40,"context_line":"        return super(ServiceManager, self).create("},{"line_number":41,"context_line":"            name\u003dname,"},{"line_number":42,"context_line":"            type\u003dtype,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Fs5s%3D","line":39,"in_reply_to":"AAAAWH%2F%2FwcE%3D","updated":"2014-03-14 11:56:32.000000000","message":"Done","commit_id":"b693b30120327a18e1ac2f2d15b10cb7b5e040ff"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"b2a3fb5a256a0d45e88304ecececec8d66a3e92d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return super(ServiceManager, self).get("},{"line_number":49,"context_line":"            service_id\u003dbase.getid(service))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def update(self, service, name\u003dNone, type\u003dNone, enabled\u003dNone, **kwargs):"},{"line_number":52,"context_line":"        return super(ServiceManager, self).update("},{"line_number":53,"context_line":"            service_id\u003dbase.getid(service),"},{"line_number":54,"context_line":"            name\u003dname,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2FuKk%3D","line":51,"updated":"2014-03-14 08:24:54.000000000","message":"Maybe we should add \"description\" parameter here too.","commit_id":"b693b30120327a18e1ac2f2d15b10cb7b5e040ff"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"7f8a29d5ceb76590d87b8eab5a6aa325a6962dda","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return super(ServiceManager, self).get("},{"line_number":49,"context_line":"            service_id\u003dbase.getid(service))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def update(self, service, name\u003dNone, type\u003dNone, enabled\u003dNone, **kwargs):"},{"line_number":52,"context_line":"        return super(ServiceManager, self).update("},{"line_number":53,"context_line":"            service_id\u003dbase.getid(service),"},{"line_number":54,"context_line":"            name\u003dname,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2Fs5o%3D","line":51,"in_reply_to":"AAAAWH%2F%2FuKk%3D","updated":"2014-03-14 11:56:32.000000000","message":"Done","commit_id":"b693b30120327a18e1ac2f2d15b10cb7b5e040ff"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"981a90ddb8c8b3b65697932b206ed4c83685c7d8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    collection_key \u003d \u0027services\u0027"},{"line_number":37,"context_line":"    key \u003d \u0027service\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, type, description\u003dNone, enabled\u003dTrue, **kwargs):"},{"line_number":40,"context_line":"        return super(ServiceManager, self).create("},{"line_number":41,"context_line":"            name\u003dname,"},{"line_number":42,"context_line":"            type\u003dtype,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FZZ0%3D","line":39,"updated":"2014-03-18 06:05:20.000000000","message":"There\u0027s **kwargs at the end so in theory \"description\" is already supported. Just back out the changes in this file and keep the changes in test_services.py and thing should still work fine.","commit_id":"6820d05d096b399836e6c9c1d063d25561949422"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"08cdafebc4f5eca917db6aaebdc9d504696181f9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    collection_key \u003d \u0027services\u0027"},{"line_number":37,"context_line":"    key \u003d \u0027service\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, type, description\u003dNone, enabled\u003dTrue, **kwargs):"},{"line_number":40,"context_line":"        return super(ServiceManager, self).create("},{"line_number":41,"context_line":"            name\u003dname,"},{"line_number":42,"context_line":"            type\u003dtype,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2B11k%3D","line":39,"updated":"2014-03-23 14:42:08.000000000","message":"don\u0027t change the order of the keyword arguments. it\u0027s not backwards compatible.","commit_id":"6820d05d096b399836e6c9c1d063d25561949422"},{"author":{"_account_id":10247,"name":"Santiago Baldassin","email":"santiago.b.baldassin@intel.com","username":"santibaldassin"},"change_message_id":"48a11327f29cc399c5431c47937a1aba8b2c2d1b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    collection_key \u003d \u0027services\u0027"},{"line_number":37,"context_line":"    key \u003d \u0027service\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, type, description\u003dNone, enabled\u003dTrue, **kwargs):"},{"line_number":40,"context_line":"        return super(ServiceManager, self).create("},{"line_number":41,"context_line":"            name\u003dname,"},{"line_number":42,"context_line":"            type\u003dtype,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BjZY%3D","line":39,"in_reply_to":"AAAAWH%2F%2B11k%3D","updated":"2014-03-25 23:38:51.000000000","message":"hi Brant, the as far as I see, the order is the same as in V2. Am I missing something?","commit_id":"6820d05d096b399836e6c9c1d063d25561949422"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c6f4c2a13d450c11ae1b958af7102604636fe8b9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    collection_key \u003d \u0027services\u0027"},{"line_number":37,"context_line":"    key \u003d \u0027service\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, type, description\u003dNone, enabled\u003dTrue, **kwargs):"},{"line_number":40,"context_line":"        return super(ServiceManager, self).create("},{"line_number":41,"context_line":"            name\u003dname,"},{"line_number":42,"context_line":"            type\u003dtype,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad9bd40_e71f8d6a","line":39,"in_reply_to":"AAAAWH%2F%2BjZY%3D","updated":"2014-05-05 23:44:41.000000000","message":"It needs to be backwards compatible with released versions of the code... they could have used service.create(\u0027abc\u0027, \u0027type-a\u0027, True) -- code that used to work would fail with this change.","commit_id":"6820d05d096b399836e6c9c1d063d25561949422"}]}