)]}'
{"keystoneclient/middleware/auth_token.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"786b9bafab56755beb00753e6fe97693bf30adba","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"        self._fetch_cert_file(self.signing_ca_file_name, \u0027ca\u0027)"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"class CachePool(list):"},{"line_number":1370,"context_line":"    \"\"\"A lazy pool of cache references.\"\"\""},{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":"    def __init__(self, cache, memcached_servers):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FcCo%3D","line":1369,"updated":"2014-03-17 22:09:18.000000000","message":"any reason we shouldnt send this to openstack.common.memorypool?","commit_id":"843c3fd7902a6aac86110150eb469ea264d569ba"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"185358f7eb7106d0f13a14eb388778a37bf0d46c","unresolved":false,"context_lines":[{"line_number":1366,"context_line":"        self._fetch_cert_file(self.signing_ca_file_name, \u0027ca\u0027)"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"class CachePool(list):"},{"line_number":1370,"context_line":"    \"\"\"A lazy pool of cache references.\"\"\""},{"line_number":1371,"context_line":""},{"line_number":1372,"context_line":"    def __init__(self, cache, memcached_servers):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FWzk%3D","line":1369,"in_reply_to":"AAAAWH%2F%2FcCo%3D","updated":"2014-03-18 12:12:45.000000000","message":"yes and no - ping me in IRC to discuss","commit_id":"843c3fd7902a6aac86110150eb469ea264d569ba"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"035e6311ab67fa1d45910cac17b4a846d3a49dd1","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"    def _create_client(self):"},{"line_number":1377,"context_line":"        if self._environment_cache is not None:"},{"line_number":1378,"context_line":"            # use the cache from the upstream filter"},{"line_number":1379,"context_line":"            return self._environment_cache"},{"line_number":1380,"context_line":"        # use Keystone memcache"},{"line_number":1381,"context_line":"        return memorycache.get_client(self._memcached_servers)"},{"line_number":1382,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B6rE%3D","line":1379,"updated":"2014-03-21 17:52:53.000000000","message":"in this case nothing is created, so putting it in a function called create_client is incorrect IMO, and then this object is going to contain several references to the same object. I think this should be moved into reserve() and just yield the self._environment_cache and return.","commit_id":"843c3fd7902a6aac86110150eb469ea264d569ba"}]}