)]}'
{"id":"openstack%2Fpython-keystoneclient~81695","triplet_id":"openstack%2Fpython-keystoneclient~master~If9da3cbd0d5134961197c7387c7b39071bbf71b1","project":"openstack/python-keystoneclient","branch":"master","topic":"exclude","hashtags":[],"change_id":"If9da3cbd0d5134961197c7387c7b39071bbf71b1","subject":"Add an exclude option to AuthToken middleware","status":"ABANDONED","created":"2014-03-20 03:55:30.000000000","updated":"2014-04-02 13:09:39.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c570414c3c238e7d5102397c099f6ee4afdec70e","_number":81695,"virtual_id_number":81695,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"value":1,"date":"2014-03-25 02:29:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2014-03-25 01:17:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"date":"2014-03-25 05:47:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2014-03-25 19:03:56.000000000","_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-03-20 03:56:20.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"date":"2014-03-20 03:56:24.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"date":"2014-03-20 03:56:30.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"date":"2014-03-20 03:56:40.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"date":"2014-03-20 03:56:45.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"date":"2014-03-20 03:56:54.000000000","_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-20 03:56:20.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-03-20 03:56:24.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-03-20 03:56:30.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2014-03-20 03:56:40.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-03-20 03:56:45.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2014-03-20 03:56:54.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2014-03-25 02:29:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-03-25 19:03:56.000000000","updated_by":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"reviewer":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"state":"REVIEWER"}],"messages":[{"id":"f76f46317a3171824484ac698f7c6cd876eeef83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-20 03:55:31.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b6db4987c5cce86360c8311c28fdb274fb8078a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-20 05:05:42.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-pep8/a13bb1d : SUCCESS in 1m 18s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/95/81695/1/check/gate-python-keystoneclient-docs/7efb6a0/doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-python26/5176ee9 : SUCCESS in 3m 29s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-python27/a6b3cbb : SUCCESS in 1m 26s\n- check-grenade-dsvm http://logs.openstack.org/95/81695/1/check/check-grenade-dsvm/a1509f1 : SUCCESS in 36m 54s\n- check-tempest-dsvm-full http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-full/cc732ae : SUCCESS in 52m 35s\n- check-tempest-dsvm-neutron http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-neutron/ca7e406 : SUCCESS in 45m 41s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-neutron-heat-slow/e162fa0 : SUCCESS in 23m 23s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-python33/338a81b : SUCCESS in 3m 52s\n- check-devstack-dsvm-cells http://logs.openstack.org/95/81695/1/check/check-devstack-dsvm-cells/aebe9e7 : SUCCESS in 13m 04s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-postgres-full/5a06839 : SUCCESS in 47m 41s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/95/81695/1/check/gate-tempest-dsvm-large-ops/aba48cc : SUCCESS in 15m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/95/81695/1/check/gate-tempest-dsvm-neutron-large-ops/8a1e56d : SUCCESS in 18m 38s\n","accounts_in_message":[],"_revision_number":1},{"id":"154821d2653935eca5f12fee1f8639cc7da609bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-25 01:17:16.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e3fa50cea5c2a5964362503dca6396c5e232adea","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-03-25 01:17:16.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\ni don\u0027t see a reason for this to ignore case, but the rest LGTM","accounts_in_message":[],"_revision_number":1},{"id":"6e986845ce17e5a77f03230e01e2c7cbb2ae5404","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-25 02:29:03.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-pep8/3e7bbc3 : SUCCESS in 1m 32s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/95/81695/1/check/gate-python-keystoneclient-docs/2ee1f5c/doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-python26/c41e438 : SUCCESS in 1m 17s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-python27/b40437a : SUCCESS in 1m 33s\n- check-grenade-dsvm http://logs.openstack.org/95/81695/1/check/check-grenade-dsvm/31f0304 : SUCCESS in 31m 18s\n- check-tempest-dsvm-full http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-full/9da98f9 : SUCCESS in 1h 06m 36s\n- check-tempest-dsvm-neutron http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-neutron/287bb90 : SUCCESS in 47m 30s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-neutron-heat-slow/a67fd94 : SUCCESS in 23m 36s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/95/81695/1/check/gate-python-keystoneclient-python33/d8f3942 : SUCCESS in 4m 05s\n- check-devstack-dsvm-cells http://logs.openstack.org/95/81695/1/check/check-devstack-dsvm-cells/287220a : SUCCESS in 12m 58s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/95/81695/1/check/check-tempest-dsvm-postgres-full/4bc5340 : SUCCESS in 54m 20s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/95/81695/1/check/gate-tempest-dsvm-large-ops/89b967a : SUCCESS in 15m 12s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/95/81695/1/check/gate-tempest-dsvm-neutron-large-ops/108339f : SUCCESS in 15m 03s\n\n","accounts_in_message":[],"_revision_number":1},{"id":"afd3892bc3d694aaa06a7306b22a329c20a13d0c","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-03-25 05:47:41.000000000","message":"Patch Set 1:\n\nI think auth_token middleware is due for refactoring. There\u0027s \u0027delay_auth_decision\u0027 flag which tells auth_token to defer auth decision downstream. Maybe I don\u0027t know all the historic reasons, but I\u0027ve always thought auth_token middleware\u0027s job is to validate the token, if there is one, and populate the headers with token information. If auth_token is absent, then there\u0027s nothing to populate. It is up to the services themselves to enforce authorization via policy.conf.\n\nI am fine with this patch if there is no better alternative. But the number of options in auth_token is starting to complicating things.","accounts_in_message":[],"_revision_number":1},{"id":"b0ec299963b10de371d7d95ed2b78de4cba26709","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-04-01 06:03:02.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"99d6191b8011c81a40702c2df4854d21c8ed8a57","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-04-01 06:03:02.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"2678d47582d566261223dd2aaade6b4d8e766562","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-04-02 13:09:39.000000000","message":"Patch Set 1:\n\nPlease bring back","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"58f9999116f575c404668a3fbc4d560d3db7f86c","revisions":{"58f9999116f575c404668a3fbc4d560d3db7f86c":{"kind":"REWORK","_number":1,"created":"2014-03-20 03:55:30.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/95/81695/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/95/81695/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/81695/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/81695/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/81695/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/95/81695/1"}}},"commit":{"parents":[{"commit":"b63bd9c3d8c1f47a9354242eaee196713edde01f","subject":"Docs link to middlewarearchitecture","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/b63bd9c3d8c1f47a9354242eaee196713edde01f"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-03-20 03:48:27.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-03-20 03:48:27.000000000","tz":600},"subject":"Add an exclude option to AuthToken middleware","message":"Add an exclude option to AuthToken middleware\n\nAllow certain paths to be excluded from the auth_token middleware check.\nThe primary use I see for this option is version discovery URLs. We\nrecommend that version discover urls (eg /, /v1, /v2) are accessible\nunauthenticated however the auth_token middleware is an all or nothing\napproach and will secure all requests that pass through it.\n\nThis is an option I would see being set in a paste file or similar -\nrather than something that would be configured by an end\nuser/administrator.\n\nSecurityImpact\nDocImpact: New option \u0027exclude\u0027 to auth_token middleware settings which\nwill take a regular expression and, if it matches the path, allow a\nrequest to proceed unauthenticated.\n\nChange-Id: If9da3cbd0d5134961197c7387c7b39071bbf71b1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/58f9999116f575c404668a3fbc4d560d3db7f86c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/58f9999116f575c404668a3fbc4d560d3db7f86c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}