)]}'
{"keystoneclient/tests/v3/test_oauth1.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e3078834036a449325cc2eba278d0dc895a4b9ec","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                                     oauth_client)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"class TestOAuthLibModule(test_utils.DisableModuleFixture):"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def setUp(self):"},{"line_number":289,"context_line":"        super(TestOAuthLibModule, self).setUp()"}],"source_content_type":"text/x-python","patch_set":12,"id":"7adec928_cc085494","line":286,"updated":"2014-05-21 18:40:45.000000000","message":"Should this be a TestCase instead of a DisableModuleFixture?","commit_id":"499a951254c7f70c4f81609199a577d860435e48"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"27b13750c61e1fad60bfe8b91a99c5363a7b51c1","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                       access_key\u003daccess_key,"},{"line_number":260,"context_line":"                       access_secret\u003daccess_secret)"},{"line_number":261,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":262,"context_line":"        s.get_token()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        OAUTH_REQUEST_BODY \u003d {"},{"line_number":265,"context_line":"            \"auth\": {"}],"source_content_type":"text/x-python","patch_set":13,"id":"7adec928_50821201","line":262,"updated":"2014-05-21 23:21:56.000000000","message":"nit: should probably check the value of the returned token. should be self.TEST_TOKEN i think.","commit_id":"42b816b782b780e292d0cc92d7433f26b9551419"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04996cd73d5e2c1cdb83260b34d8f45896ac7520","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                       access_key\u003daccess_key,"},{"line_number":260,"context_line":"                       access_secret\u003daccess_secret)"},{"line_number":261,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":262,"context_line":"        s.get_token()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        OAUTH_REQUEST_BODY \u003d {"},{"line_number":265,"context_line":"            \"auth\": {"}],"source_content_type":"text/x-python","patch_set":13,"id":"7adec928_6461e5a7","line":262,"in_reply_to":"7adec928_50821201","updated":"2014-05-23 05:54:38.000000000","message":"I\u0027ll address this in the next patch","commit_id":"42b816b782b780e292d0cc92d7433f26b9551419"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"27b13750c61e1fad60bfe8b91a99c5363a7b51c1","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # method of oauth1.auth, when the tests are run, the oauthlib"},{"line_number":295,"context_line":"        # library is successfully found. But since we are disabling"},{"line_number":296,"context_line":"        # oauthlib in the setup, we have to reload oauth1.auth,"},{"line_number":297,"context_line":"        # to get the full effect of not having oauthlib available."},{"line_number":298,"context_line":"        reload(auth)"},{"line_number":299,"context_line":"        self.assertRaises(NotImplementedError,"},{"line_number":300,"context_line":"                          auth.OAuth,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7adec928_b09fd64f","line":297,"updated":"2014-05-21 23:21:56.000000000","message":"so then another way you could test this would be just to mock that auth.oauthlib \u003d None\n\nI\u0027m not really aware of how the DisableModuleFixture works but for the same reason you need a reload here then any tests that you do after here won\u0027t have oauthlib available.\n\nI added a new class at the end of the file with a test that just did an import ipdb; ipdb.set_trace() and regardless of whether i did a reload(auth) or import oauthlib1 it wouldn\u0027t import it.","commit_id":"42b816b782b780e292d0cc92d7433f26b9551419"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04996cd73d5e2c1cdb83260b34d8f45896ac7520","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # method of oauth1.auth, when the tests are run, the oauthlib"},{"line_number":295,"context_line":"        # library is successfully found. But since we are disabling"},{"line_number":296,"context_line":"        # oauthlib in the setup, we have to reload oauth1.auth,"},{"line_number":297,"context_line":"        # to get the full effect of not having oauthlib available."},{"line_number":298,"context_line":"        reload(auth)"},{"line_number":299,"context_line":"        self.assertRaises(NotImplementedError,"},{"line_number":300,"context_line":"                          auth.OAuth,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7adec928_045581c5","line":297,"in_reply_to":"7adec928_b09fd64f","updated":"2014-05-23 05:54:38.000000000","message":"I think DisableModuleFixture will disable it for all subsequent test calls (as you noticed). I ran into this as well.\n\nMaybe I\u0027ll try mocking it, like you said. When doing reload(), it\u0027s only passing on py27, not py33.","commit_id":"42b816b782b780e292d0cc92d7433f26b9551419"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"588db96622007ad53afea6503f20125302fadb54","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                       access_secret\u003daccess_secret)"},{"line_number":261,"context_line":"        s \u003d session.Session(auth\u003da)"},{"line_number":262,"context_line":"        t \u003d s.get_token()"},{"line_number":263,"context_line":"        self.assertEqual(t, self.TEST_TOKEN)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        OAUTH_REQUEST_BODY \u003d {"},{"line_number":266,"context_line":"            \"auth\": {"}],"source_content_type":"text/x-python","patch_set":14,"id":"3ae8d1ca_91c57f5d","line":263,"updated":"2014-05-28 04:21:21.000000000","message":"nit: expected, returned","commit_id":"855ec8047682215443a013c2ef3ad1d2ae808a7d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"588db96622007ad53afea6503f20125302fadb54","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                                     oauth_client)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"class TestOAuthLibModule(utils.TestCase):"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def setUp(self):"},{"line_number":290,"context_line":"        super(TestOAuthLibModule, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"3ae8d1ca_31958b40","line":287,"updated":"2014-05-28 04:21:21.000000000","message":"nit: no longer needs it\u0027s own class, or setUp() function.","commit_id":"855ec8047682215443a013c2ef3ad1d2ae808a7d"}],"keystoneclient/v3/contrib/oauth1/auth.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"27b13750c61e1fad60bfe8b91a99c5363a7b51c1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from keystoneclient.auth.identity import v3"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"try:"},{"line_number":17,"context_line":"    import oauthlib.oauth1 as oauth1"},{"line_number":18,"context_line":"except ImportError:"},{"line_number":19,"context_line":"    oauth1 \u003d None"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7adec928_f045deb3","line":17,"updated":"2014-05-21 23:21:56.000000000","message":"nit: AKA from oauthlib import oauth1","commit_id":"42b816b782b780e292d0cc92d7433f26b9551419"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04996cd73d5e2c1cdb83260b34d8f45896ac7520","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from keystoneclient.auth.identity import v3"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"try:"},{"line_number":17,"context_line":"    import oauthlib.oauth1 as oauth1"},{"line_number":18,"context_line":"except ImportError:"},{"line_number":19,"context_line":"    oauth1 \u003d None"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7adec928_a45bedf4","line":17,"in_reply_to":"7adec928_f045deb3","updated":"2014-05-23 05:54:38.000000000","message":"i\u0027ll address this in the next patch","commit_id":"42b816b782b780e292d0cc92d7433f26b9551419"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"44aa1394ee669c5e79c27f46fa4d2afd5ef384d5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    _auth_method_class \u003d OAuthMethod"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def __init__(self, auth_url, **kwargs):"},{"line_number":58,"context_line":"        super(OAuth, self).__init__(auth_url, **kwargs)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3ae8d1ca_b7725aab","line":58,"updated":"2014-05-28 14:04:46.000000000","message":"__init__ could be removed since it\u0027s not being used","commit_id":"855ec8047682215443a013c2ef3ad1d2ae808a7d"}]}