)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6f30be107e68468240aaec36027e16b674ed9408","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"requests.Session management is expected to be handled by the new"},{"line_number":10,"context_line":"keystoneclient.session object however there is some need for people"},{"line_number":11,"context_line":"using the existing client pattern to pass there own requests.Session."},{"line_number":12,"context_line":"This simply passes the option through to the keystoneclient.Session"},{"line_number":13,"context_line":"builder if it is called."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FkGs%3D","line":11,"updated":"2014-04-12 15:37:10.000000000","message":"change \"there\" to \"their\"","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"487f65dada40a2ba7203afb68d430a32a0e9a922","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"requests.Session management is expected to be handled by the new"},{"line_number":10,"context_line":"keystoneclient.session object however there is some need for people"},{"line_number":11,"context_line":"using the existing client pattern to pass there own requests.Session."},{"line_number":12,"context_line":"This simply passes the option through to the keystoneclient.Session"},{"line_number":13,"context_line":"builder if it is called."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2Fg1s%3D","line":11,"in_reply_to":"AAAAW3%2F%2FkGs%3D","updated":"2014-04-14 03:40:46.000000000","message":"Done","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6f30be107e68468240aaec36027e16b674ed9408","unresolved":false,"context_lines":[{"line_number":10,"context_line":"keystoneclient.session object however there is some need for people"},{"line_number":11,"context_line":"using the existing client pattern to pass there own requests.Session."},{"line_number":12,"context_line":"This simply passes the option through to the keystoneclient.Session"},{"line_number":13,"context_line":"builder if it is called."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I985245f433418ec72ec5ad5a316b33fb6d3d4117"},{"line_number":16,"context_line":"Partial-Bug: #1282089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FkGo%3D","line":13,"updated":"2014-04-12 15:37:10.000000000","message":"if what is called? explain what \"it\" is","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"487f65dada40a2ba7203afb68d430a32a0e9a922","unresolved":false,"context_lines":[{"line_number":10,"context_line":"keystoneclient.session object however there is some need for people"},{"line_number":11,"context_line":"using the existing client pattern to pass there own requests.Session."},{"line_number":12,"context_line":"This simply passes the option through to the keystoneclient.Session"},{"line_number":13,"context_line":"builder if it is called."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I985245f433418ec72ec5ad5a316b33fb6d3d4117"},{"line_number":16,"context_line":"Partial-Bug: #1282089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2Fg1o%3D","line":13,"in_reply_to":"AAAAW3%2F%2FkGo%3D","updated":"2014-04-14 03:40:46.000000000","message":"Done","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6f30be107e68468240aaec36027e16b674ed9408","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This simply passes the option through to the keystoneclient.Session"},{"line_number":13,"context_line":"builder if it is called."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I985245f433418ec72ec5ad5a316b33fb6d3d4117"},{"line_number":16,"context_line":"Partial-Bug: #1282089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2FkGY%3D","line":15,"updated":"2014-04-12 15:37:10.000000000","message":"seems like this should have a DocImpact.","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"487f65dada40a2ba7203afb68d430a32a0e9a922","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This simply passes the option through to the keystoneclient.Session"},{"line_number":13,"context_line":"builder if it is called."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I985245f433418ec72ec5ad5a316b33fb6d3d4117"},{"line_number":16,"context_line":"Partial-Bug: #1282089"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAW3%2F%2Fg1k%3D","line":15,"in_reply_to":"AAAAW3%2F%2FkGY%3D","updated":"2014-04-14 03:40:46.000000000","message":"Done","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"}],"keystoneclient/httpclient.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6f30be107e68468240aaec36027e16b674ed9408","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        :param object session: A Session object to be used for"},{"line_number":120,"context_line":"                               communicating with the identity service."},{"line_number":121,"context_line":"        :param object requests_session: A requests.Session() object that can"},{"line_number":122,"context_line":"                                        be used for connection pooling. This"},{"line_number":123,"context_line":"                                        parameter will be ignored if an"},{"line_number":124,"context_line":"                                        existing `session` object is passed."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FkGQ%3D","line":122,"updated":"2014-04-12 15:37:10.000000000","message":"I thought we disabled connection pooling because the managers kept references and they\u0027d never be closed.","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"487f65dada40a2ba7203afb68d430a32a0e9a922","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        :param object session: A Session object to be used for"},{"line_number":120,"context_line":"                               communicating with the identity service."},{"line_number":121,"context_line":"        :param object requests_session: A requests.Session() object that can"},{"line_number":122,"context_line":"                                        be used for connection pooling. This"},{"line_number":123,"context_line":"                                        parameter will be ignored if an"},{"line_number":124,"context_line":"                                        existing `session` object is passed."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2Fg2U%3D","line":122,"in_reply_to":"AAAAW3%2F%2FkGQ%3D","updated":"2014-04-14 03:40:46.000000000","message":"we did, but the problem there was when we created it automatically for people. If you pass in a session object then you expect to hold that reference externally. People can do what they like there.","commit_id":"c2b02c85cb2e63ec9634e92876c6a351a78eb4bf"}],"keystoneclient/tests/v2_0/test_client.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1b62c6bde5b1fc8d9b9e63fd09051ac8e1a0f225","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                           token\u003d\u0027aToken\u0027,"},{"line_number":163,"context_line":"                           requests_session\u003dsess)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.assertIs(cl.session.session, sess)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FYWE%3D","line":165,"updated":"2014-04-15 01:18:24.000000000","message":"There should be a test that the requests_session parameter is ignored if an existing `session` object is passed, and that it\u0027s not ignored if a non-existant `session` object is passed.","commit_id":"cb8bbc0695bf87bce0796d6cab30d06e8960b529"}],"keystoneclient/tests/v3/test_client.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"1b62c6bde5b1fc8d9b9e63fd09051ac8e1a0f225","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                           token\u003d\u0027aToken\u0027,"},{"line_number":208,"context_line":"                           requests_session\u003dsess)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        self.assertIs(cl.session.session, sess)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FYWA%3D","line":210,"updated":"2014-04-15 01:18:24.000000000","message":"There should be a test that the requests_session parameter is ignored if an existing `session` object is passed, and that it\u0027s not ignored if a non-existant `session` object is passed.","commit_id":"cb8bbc0695bf87bce0796d6cab30d06e8960b529"}]}