)]}'
{"id":"openstack%2Fpython-keystoneclient~87156","triplet_id":"openstack%2Fpython-keystoneclient~master~I1aad17893574ebc7c3a6b84f4d6ba1cd27932158","project":"openstack/python-keystoneclient","branch":"master","topic":"v2tokengen","hashtags":[],"change_id":"I1aad17893574ebc7c3a6b84f4d6ba1cd27932158","subject":"Don\u0027t use generic kwargs in v2 Token Generation","status":"MERGED","created":"2014-04-14 03:21:52.000000000","updated":"2014-04-14 17:41:37.000000000","submitted":"2014-04-14 17:41:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6809350b2d5858bdcc184ad4bf410e08cf18499d","_number":87156,"virtual_id_number":87156,"owner":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-04-14 17:41:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-04-14 16:26:05.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2014-04-14 03:36:57.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-04-14 16:26:05.000000000","_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"date":"2014-04-14 03:23:36.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"date":"2014-04-14 03:23:42.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"date":"2014-04-14 03:23:38.000000000","_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"date":"2014-04-14 03:23:52.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-04-14 03:23:36.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-04-14 03:23:38.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-04-14 03:23:42.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2014-04-14 03:23:52.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2014-04-14 16:26:05.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-04-14 17:41:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7b33dcc002f826baa7889992b4292908f04005f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-14 03:21:53.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e6e14736eeb111f651d4cf783e476266315af00d","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-04-14 03:36:57.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nI very much prefer this approach not allowing misc data to be jammed into the example tokens. This likely will save some headaches down the road: \"My example token worked\" - oh look you added XYZ data and keystone has no idea what that is and therefore doesn\u0027t emit it in the tokens.","accounts_in_message":[],"_revision_number":1},{"id":"99bb009b1d745c1ebe80df5e777edbdfac9a47b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-14 04:21:08.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/56/87156/1/check/gate-python-keystoneclient-pep8/2898c0f : SUCCESS in 52s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/56/87156/1/check/gate-python-keystoneclient-docs/4cf3d10/doc/build/html/ : SUCCESS in 1m 41s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/56/87156/1/check/gate-python-keystoneclient-python26/d988b7d : SUCCESS in 1m 09s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/56/87156/1/check/gate-python-keystoneclient-python27/68c03ae : SUCCESS in 1m 31s\n- check-tempest-dsvm-full http://logs.openstack.org/56/87156/1/check/check-tempest-dsvm-full/21fe2ed : SUCCESS in 59m 13s\n- check-tempest-dsvm-neutron http://logs.openstack.org/56/87156/1/check/check-tempest-dsvm-neutron/e9957de : SUCCESS in 52m 19s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/87156/1/check/check-tempest-dsvm-neutron-heat-slow/4dbef64 : SUCCESS in 19m 35s\n- check-grenade-dsvm http://logs.openstack.org/56/87156/1/check/check-grenade-dsvm/e2e7920 : SUCCESS in 37m 21s\n- check-grenade-dsvm-neutron http://logs.openstack.org/56/87156/1/check/check-grenade-dsvm-neutron/aa9a12d : FAILURE in 24m 39s (non-voting)\n- gate-python-keystoneclient-python33 http://logs.openstack.org/56/87156/1/check/gate-python-keystoneclient-python33/f338960 : SUCCESS in 3m 43s\n- check-devstack-dsvm-cells http://logs.openstack.org/56/87156/1/check/check-devstack-dsvm-cells/ae66080 : SUCCESS in 13m 29s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/56/87156/1/check/check-tempest-dsvm-postgres-full/54dd8d8 : SUCCESS in 50m 46s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/87156/1/check/gate-tempest-dsvm-large-ops/48096b1 : SUCCESS in 14m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/87156/1/check/gate-tempest-dsvm-neutron-large-ops/12c7439 : SUCCESS in 14m 24s\n","accounts_in_message":[],"_revision_number":1},{"id":"002dc55b6f93aacf8c080f179f46a62a31a7a770","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-14 16:26:05.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"7ee199407f67336db3d1d3bca2d568eb11903a33","author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"date":"2014-04-14 16:26:05.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a81f981b85b08c3df2d3027c976e88d783916002","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-14 17:41:37.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/56/87156/1/gate/gate-python-keystoneclient-docs/18bcd37/doc/build/html/ : SUCCESS in 2m 12s\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/56/87156/1/gate/gate-python-keystoneclient-pep8/0f9c8af : SUCCESS in 1m 39s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/56/87156/1/gate/gate-python-keystoneclient-python26/bbb10a2 : SUCCESS in 1m 07s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/56/87156/1/gate/gate-python-keystoneclient-python27/0c73094 : SUCCESS in 1m 23s\n- gate-tempest-dsvm-full http://logs.openstack.org/56/87156/1/gate/gate-tempest-dsvm-full/1517885 : SUCCESS in 1h 02m 47s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/56/87156/1/gate/gate-tempest-dsvm-neutron/a0788d9 : SUCCESS in 50m 57s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/56/87156/1/gate/gate-tempest-dsvm-neutron-heat-slow/856616f : SUCCESS in 22m 49s\n- gate-grenade-dsvm http://logs.openstack.org/56/87156/1/gate/gate-grenade-dsvm/f15c16b : SUCCESS in 43m 22s\n- gate-grenade-dsvm-neutron http://logs.openstack.org/56/87156/1/gate/gate-grenade-dsvm-neutron/da0535a : FAILURE in 26m 57s (non-voting)\n- gate-python-keystoneclient-python33 http://logs.openstack.org/56/87156/1/gate/gate-python-keystoneclient-python33/62fb2db : SUCCESS in 3m 51s\n- gate-devstack-dsvm-cells http://logs.openstack.org/56/87156/1/gate/gate-devstack-dsvm-cells/a5e9e43 : SUCCESS in 12m 57s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/56/87156/1/gate/gate-tempest-dsvm-postgres-full/9d8df73 : SUCCESS in 1h 14m 30s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/56/87156/1/gate/gate-tempest-dsvm-large-ops/12fd6ee : SUCCESS in 14m 54s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/56/87156/1/gate/gate-tempest-dsvm-neutron-large-ops/3697546 : SUCCESS in 16m 53s\n","accounts_in_message":[],"_revision_number":1},{"id":"8a7f461633a7a103dcb3eee716dce077773279e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-14 17:41:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e7b5120e76234002f72bb085bf6e287bf534090d","revisions":{"e7b5120e76234002f72bb085bf6e287bf534090d":{"kind":"REWORK","_number":1,"created":"2014-04-14 03:21:52.000000000","uploader":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"ref":"refs/changes/56/87156/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/56/87156/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/87156/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/87156/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/87156/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/56/87156/1"}}},"commit":{"parents":[{"commit":"f89787f46c04d428c36cb88a4c62ab58466c6b34","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f89787f46c04d428c36cb88a4c62ab58466c6b34"}]}],"author":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-04-14 03:17:51.000000000","tz":600},"committer":{"name":"Jamie Lennox","email":"jamielennox@redhat.com","date":"2014-04-14 03:17:51.000000000","tz":600},"subject":"Don\u0027t use generic kwargs in v2 Token Generation","message":"Don\u0027t use generic kwargs in v2 Token Generation\n\nWe need to allow for people adding other stuff to the tokens however it\nshouldn\u0027t be available in the standard case where for example a misspelt\nvariable would be propagated.\n\nThis is in line with how v3 is going to handle this same scenario.\n\nChange-Id: I1aad17893574ebc7c3a6b84f4d6ba1cd27932158\nCloses-Bug: #1307278\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e7b5120e76234002f72bb085bf6e287bf534090d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/e7b5120e76234002f72bb085bf6e287bf534090d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}