)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"241872636245029b22db64a9d0df48a2f2385c1b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add endpoint handling to Token/Endpoint auth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This auth plugin was initially created before get_endpoint was"},{"line_number":10,"context_line":"available. Now that it is we should return the endpoint as expected."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic868f509e708ad29faf86ec5ceeab2a9c98a24fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ae8d1ca_7db60c3f","line":10,"updated":"2014-05-28 00:42:43.000000000","message":"change \"it\" to \"get_endpoint\" since I didn\u0027t know if \"it\" was referring to the auth plugin or what.","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2a6e027ecc110f28d58e13be414e05e4d2175c5f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add endpoint handling to Token/Endpoint auth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This auth plugin was initially created before get_endpoint was"},{"line_number":10,"context_line":"available. Now that it is we should return the endpoint as expected."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic868f509e708ad29faf86ec5ceeab2a9c98a24fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ae8d1ca_d6bb7dc2","line":10,"in_reply_to":"3ae8d1ca_7db60c3f","updated":"2014-05-28 03:36:01.000000000","message":"Done","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"241872636245029b22db64a9d0df48a2f2385c1b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This auth plugin was initially created before get_endpoint was"},{"line_number":10,"context_line":"available. Now that it is we should return the endpoint as expected."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic868f509e708ad29faf86ec5ceeab2a9c98a24fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ae8d1ca_9d82f850","line":11,"updated":"2014-05-28 00:42:43.000000000","message":"Isn\u0027t this fixing a bug? If it\u0027s adding a new feature then there should be a blueprint.","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2a6e027ecc110f28d58e13be414e05e4d2175c5f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This auth plugin was initially created before get_endpoint was"},{"line_number":10,"context_line":"available. Now that it is we should return the endpoint as expected."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic868f509e708ad29faf86ec5ceeab2a9c98a24fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ae8d1ca_f6b079df","line":11,"in_reply_to":"3ae8d1ca_9d82f850","updated":"2014-05-28 03:36:01.000000000","message":"Done","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"}],"keystoneclient/auth/token_endpoint.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"241872636245029b22db64a9d0df48a2f2385c1b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def get_token(self, session):"},{"line_number":31,"context_line":"        return self.token"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_endpoint(self, session, **kwargs):"},{"line_number":34,"context_line":"        return self.endpoint"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_fdcf7cae","line":33,"updated":"2014-05-28 00:42:43.000000000","message":"This should have a docstring. The docstring in the superclass doesn\u0027t apply to this method, since it\u0027s ignoring service_type and always returning the given endpoint. A user could ask it for the endpoint for a service type and it\u0027ll return something unexpected.","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2a6e027ecc110f28d58e13be414e05e4d2175c5f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def get_token(self, session):"},{"line_number":31,"context_line":"        return self.token"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_endpoint(self, session, **kwargs):"},{"line_number":34,"context_line":"        return self.endpoint"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_16b6c5d9","line":33,"in_reply_to":"3ae8d1ca_fdcf7cae","updated":"2014-05-28 03:36:01.000000000","message":"Done","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"3cfe0117c3beecbbfd4fe902287d7d910ff14c75","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return self.token"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_endpoint(self, session, **kwargs):"},{"line_number":34,"context_line":"        return self.endpoint"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_2da218fd","line":34,"updated":"2014-05-06 20:40:40.000000000","message":"not sure i understand the point of this method - why not just call o.endpoint instead of o.get_endpoint()? same goes for o.token vs o.get_token()","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"65c8463e0dfc1be456d3c46cd0d54de50e11ef6f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return self.token"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_endpoint(self, session, **kwargs):"},{"line_number":34,"context_line":"        return self.endpoint"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_3e331cac","line":34,"in_reply_to":"9ad9bd40_2da218fd","updated":"2014-05-06 22:56:37.000000000","message":"because get_endpoint() is an overridable method in the base class so that this plugin implements the standard. It\u0027s not @abstract as i couldn\u0027t do it for compatibility reasons.","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"}],"keystoneclient/tests/auth/test_token_endpoint.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"241872636245029b22db64a9d0df48a2f2385c1b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     authenticated\u003dTrue,"},{"line_number":45,"context_line":"                     endpoint_filter\u003d{\u0027service\u0027: \u0027identity\u0027})"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertEqual(data.text, \u0027body\u0027)"},{"line_number":48,"context_line":"        self.assertRequestHeaderEqual(\u0027X-Auth-Token\u0027, self.TEST_TOKEN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_5dbeb000","line":47,"updated":"2014-05-28 00:42:43.000000000","message":"(nit) the expected value should come first.","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2a6e027ecc110f28d58e13be414e05e4d2175c5f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     authenticated\u003dTrue,"},{"line_number":45,"context_line":"                     endpoint_filter\u003d{\u0027service\u0027: \u0027identity\u0027})"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertEqual(data.text, \u0027body\u0027)"},{"line_number":48,"context_line":"        self.assertRequestHeaderEqual(\u0027X-Auth-Token\u0027, self.TEST_TOKEN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_96c5755d","line":47,"in_reply_to":"3ae8d1ca_5dbeb000","updated":"2014-05-28 03:36:01.000000000","message":"Done","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"241872636245029b22db64a9d0df48a2f2385c1b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                     endpoint_filter\u003d{\u0027service\u0027: \u0027identity\u0027})"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertEqual(data.text, \u0027body\u0027)"},{"line_number":48,"context_line":"        self.assertRequestHeaderEqual(\u0027X-Auth-Token\u0027, self.TEST_TOKEN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_1d4b482c","line":48,"updated":"2014-05-28 00:42:43.000000000","message":"Seems like there should be a call to token_endpoint.get_endpoint() in this test.","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2a6e027ecc110f28d58e13be414e05e4d2175c5f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                     endpoint_filter\u003d{\u0027service\u0027: \u0027identity\u0027})"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.assertEqual(data.text, \u0027body\u0027)"},{"line_number":48,"context_line":"        self.assertRequestHeaderEqual(\u0027X-Auth-Token\u0027, self.TEST_TOKEN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_d68d3d33","line":48,"in_reply_to":"3ae8d1ca_1d4b482c","updated":"2014-05-28 03:36:01.000000000","message":"there is. it looks for the identity service so it calls get_endpoint and so it correctly gets the url and makes a request to it to return the correct body.","commit_id":"02f0a97600464bf8e06796207da5831cf5eb3582"}]}