)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"f0754c2cbd0bc19024e1f47554e538b3e6c17f83","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Author:     Fernando Ribeiro \u003cfernando.ribeiro@oracle.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2014-05-04 02:52:03 -0300"},{"line_number":4,"context_line":"Commit:     Fernando Ribeiro \u003cfernando.ribeiro@oracle.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-04 02:52:03 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Closes-Bug: #1315798"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_fc61093a","line":5,"updated":"2014-05-04 08:00:39.000000000","message":"Some description of the changes in this patch could also be helpful. \n\nMore can be found here: https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes and here:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"420bc0c1ed6f059fafe69d3b3f24582ec67de523"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c80ea6d02f885af00f91a6430c99e959fb2f4f50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix listing of endpoints for a token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The client is currently failing to list endpoints for a token because it is looking for a non-existing token key in the response from Keystone:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"def endpoints(self, token):"},{"line_number":12,"context_line":"    return self._get(/tokens/%s/endpoints % base.getid(token), \"token\")"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7adec928_ac26a8b8","line":9,"updated":"2014-05-08 17:55:21.000000000","message":"try and limit these lines to 80 chars.","commit_id":"8f5e1100a4c1bbad6c653f1004c91531a8008cb8"},{"author":{"_account_id":10245,"name":"Fernando Ribeiro","email":"fernando.ribeiro@upic.com.br","username":"fribeiro"},"change_message_id":"91638025e56e641b8210c6c5cdbe496496b6de3c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix listing of endpoints for a token"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The client is currently failing to list endpoints for a token because it is looking for a non-existing token key in the response from Keystone:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"def endpoints(self, token):"},{"line_number":12,"context_line":"    return self._get(/tokens/%s/endpoints % base.getid(token), \"token\")"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7adec928_f05f9e0c","line":9,"in_reply_to":"7adec928_ac26a8b8","updated":"2014-05-08 23:27:25.000000000","message":"Done","commit_id":"8f5e1100a4c1bbad6c653f1004c91531a8008cb8"}],"keystoneclient/v2_0/endpoints.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"f0754c2cbd0bc19024e1f47554e538b3e6c17f83","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def list(self, token\u003dNone):"},{"line_number":31,"context_line":"        if token:"},{"line_number":32,"context_line":"            return self._list(\u0027/tokens/%s/endpoints\u0027 % base.getid(token), \u0027endpoints\u0027)"},{"line_number":33,"context_line":"        else:"},{"line_number":34,"context_line":"            return self._list(\u0027/endpoints\u0027, \u0027endpoints\u0027)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_dc1c45c4","line":32,"updated":"2014-05-04 08:00:39.000000000","message":"i think PEP8 test failed here as the line is too long. \n\nSuggested running tox -epep8 prior to uploading patches :-)","commit_id":"420bc0c1ed6f059fafe69d3b3f24582ec67de523"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c80ea6d02f885af00f91a6430c99e959fb2f4f50","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    resource_class \u003d Endpoint"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def list(self):"},{"line_number":31,"context_line":"        \"\"\"List all available endpoints.\"\"\""},{"line_number":32,"context_line":"        return self._list(\u0027/endpoints\u0027, \u0027endpoints\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def create(self, region, service_id, publicurl, adminurl, internalurl):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_acff8800","side":"PARENT","line":31,"updated":"2014-05-08 17:55:21.000000000","message":"also, don\u0027t delete doc strings unless they are no longer valid.","commit_id":"570a9dc22dad6c246372f273bd6db23342752c3a"},{"author":{"_account_id":10245,"name":"Fernando Ribeiro","email":"fernando.ribeiro@upic.com.br","username":"fribeiro"},"change_message_id":"91638025e56e641b8210c6c5cdbe496496b6de3c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    resource_class \u003d Endpoint"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def list(self):"},{"line_number":31,"context_line":"        \"\"\"List all available endpoints.\"\"\""},{"line_number":32,"context_line":"        return self._list(\u0027/endpoints\u0027, \u0027endpoints\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def create(self, region, service_id, publicurl, adminurl, internalurl):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_109c0ac0","side":"PARENT","line":31,"in_reply_to":"7adec928_acff8800","updated":"2014-05-08 23:27:25.000000000","message":"Done","commit_id":"570a9dc22dad6c246372f273bd6db23342752c3a"}],"keystoneclient/v2_0/tokens.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c80ea6d02f885af00f91a6430c99e959fb2f4f50","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self._delete(\"/tokens/%s\" % base.getid(token))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def endpoints(self, token):"},{"line_number":65,"context_line":"        return self._get(\"/tokens/%s/endpoints\" % base.getid(token), \"token\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_e9126261","side":"PARENT","line":65,"updated":"2014-05-08 17:55:21.000000000","message":"it looks like it was just failing because it was looking for the \u0027token\u0027 key when it should have been looking for the \u0027endpoint\u0027 key.\n\nWhy not just change this to:\n\n  self._list(\u0027/tokens/%s/endpoints\u0027 % base.getid(token), \u0027endpoints\u0027)\n\nthen you don\u0027t have to touch the other file.","commit_id":"570a9dc22dad6c246372f273bd6db23342752c3a"},{"author":{"_account_id":10245,"name":"Fernando Ribeiro","email":"fernando.ribeiro@upic.com.br","username":"fribeiro"},"change_message_id":"91638025e56e641b8210c6c5cdbe496496b6de3c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return self._delete(\"/tokens/%s\" % base.getid(token))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def endpoints(self, token):"},{"line_number":65,"context_line":"        return self._get(\"/tokens/%s/endpoints\" % base.getid(token), \"token\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7adec928_903f3a25","side":"PARENT","line":65,"in_reply_to":"7adec928_e9126261","updated":"2014-05-08 23:27:25.000000000","message":"Because \u0027endpoints\u0027 contains endpoints, not tokens, which aren\u0027t meant to be parsed by the token manager.","commit_id":"570a9dc22dad6c246372f273bd6db23342752c3a"}]}