)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"cc3edc2ea2520556d98e0be56dd9b52225303792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"94b0a435_8ba67e92","updated":"2024-05-22 22:19:22.000000000","message":"As I mentioned during the meeting, the \"system, domain, or project\" error message is being shown instead of the \"user or group\" message when I try to add a role with a valid project but no user or group on my devstack instance. However, all the tests here are passing.","commit_id":"7b3baa527bb3903e3df5a23e8edbda2f8f427b70"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"ea1c8f9e699fc002fde14c1c19a0bdc0fef0aa35","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"164b9852_412592be","in_reply_to":"6ab63588_44a50cd4","updated":"2024-05-28 19:09:20.000000000","message":"I also tried adding a unit test to python-openstackclient but it seems to not error out at all when not all the args (e.g. only user and group) are missing. (Traceback looks like this:\n```\n      File \"/home/human/python-openstackclient/openstackclient/tests/unit/identity/v3/test_role.py\", line 387, in test_role_add_with_error_user_or_group\n    ex \u003d self.assertRaises(\n\n      File \"/home/human/python-openstackclient/.tox/py3/lib/python3.10/site-packages/testtools/testcase.py\", line 469, in assertRaises\n    self.assertThat(our_callable, matcher)\n\n      File \"/home/human/python-openstackclient/.tox/py3/lib/python3.10/site-packages/testtools/testcase.py\", line 482, in assertThat\n    raise mismatch_error\n\n    testtools.matchers._impl.MismatchError: \u003cbound method AddRole.take_action of \u003copenstackclient.identity.v3.role.AddRole object at 0x7fd9e9b25990\u003e\u003e returned None\n```) I would guess this is probably because osc itself only checks for all the args being missing, so the unit test doesn\u0027t catch errors for individual arg groups being missing which need to come from keystoneclient itself?","commit_id":"7b3baa527bb3903e3df5a23e8edbda2f8f427b70"},{"author":{"_account_id":36482,"name":"Oria Weng","display_name":"0weng","email":"oweng@osuosl.org","username":"0weng"},"change_message_id":"a80680eccf3c8961b58608c369c8b0119db69b4b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ab63588_44a50cd4","in_reply_to":"94b0a435_8ba67e92","updated":"2024-05-22 22:32:50.000000000","message":"Oops, didn\u0027t mean for that to be resolved...","commit_id":"7b3baa527bb3903e3df5a23e8edbda2f8f427b70"}]}