)]}'
{"keystoneclient/session.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"5da40346f7d27bcc0c9c321bcd3a15c2ad8753c2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def request(self, url, method, json\u003dNone, original_ip\u003dNone,"},{"line_number":116,"context_line":"                user_agent\u003dNone, redirect\u003dNone, authenticated\u003dNone,"},{"line_number":117,"context_line":"                endpoint_filter\u003dNone, auth\u003dNone, requests_auth\u003dNone,"},{"line_number":118,"context_line":"                raise_exc\u003dTrue, allow_reauth\u003dFalse, **kwargs):"},{"line_number":119,"context_line":"        \"\"\"Send an HTTP request with the specified characteristics."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        Wrapper around `requests.Session.request` to handle tasks such as"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_1e4a3783","line":118,"updated":"2014-05-23 01:09:15.000000000","message":"why defaulting to false? seem like defaulting to true is better as it is supposed to handle the token revocation case.","commit_id":"8bf6985c726d86b7c793ba18efa3c4dae279211b"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"305495d9fdcb5d71511bb3fd37edce975e04dfce","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def request(self, url, method, json\u003dNone, original_ip\u003dNone,"},{"line_number":116,"context_line":"                user_agent\u003dNone, redirect\u003dNone, authenticated\u003dNone,"},{"line_number":117,"context_line":"                endpoint_filter\u003dNone, auth\u003dNone, requests_auth\u003dNone,"},{"line_number":118,"context_line":"                raise_exc\u003dTrue, allow_reauth\u003dFalse, **kwargs):"},{"line_number":119,"context_line":"        \"\"\"Send an HTTP request with the specified characteristics."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        Wrapper around `requests.Session.request` to handle tasks such as"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_aeb3cee7","line":118,"in_reply_to":"7adec928_1e4a3783","updated":"2014-05-23 03:37:04.000000000","message":"yea, i was thinking bigger picture because requests for everything will come through here. \n\nBut i think we can default True","commit_id":"8bf6985c726d86b7c793ba18efa3c4dae279211b"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"5da40346f7d27bcc0c9c321bcd3a15c2ad8753c2","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # handle getting a 401 Unauthorized response by invalidating the plugin"},{"line_number":263,"context_line":"        # and then retrying the request. This is only tried once."},{"line_number":264,"context_line":"        if authenticated and resp.status_code \u003d\u003d 401 and allow_reauth:"},{"line_number":265,"context_line":"            if self.invalidate(auth):"},{"line_number":266,"context_line":"                token \u003d self.get_token(auth)"},{"line_number":267,"context_line":"                if token:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_5e3bdfea","line":264,"updated":"2014-05-23 01:09:15.000000000","message":"may want to move resp.status_code to the front as the if statement is short-circuited\n\nif resp.status_code \u003d\u003d 401 and authenticated and allow_reauth","commit_id":"8bf6985c726d86b7c793ba18efa3c4dae279211b"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"305495d9fdcb5d71511bb3fd37edce975e04dfce","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        # handle getting a 401 Unauthorized response by invalidating the plugin"},{"line_number":263,"context_line":"        # and then retrying the request. This is only tried once."},{"line_number":264,"context_line":"        if authenticated and resp.status_code \u003d\u003d 401 and allow_reauth:"},{"line_number":265,"context_line":"            if self.invalidate(auth):"},{"line_number":266,"context_line":"                token \u003d self.get_token(auth)"},{"line_number":267,"context_line":"                if token:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_cea2da99","line":264,"in_reply_to":"7adec928_5e3bdfea","updated":"2014-05-23 03:37:04.000000000","message":"the others are just booleans so i don\u0027t know it matters, you could argue that any one of those is a valid short-circuit\n\nif you didn\u0027t provide a token ignore it, if you don\u0027t allow reauth then ignore it","commit_id":"8bf6985c726d86b7c793ba18efa3c4dae279211b"}]}