)]}'
{"keystoneclient/common/cms.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"57d784bb4c003adf7746cf69dadecf2fcffc9605","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def set_subprocess(_subprocess\u003dNone):"},{"line_number":58,"context_line":"    \"\"\"Set subprocess module to use."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    The subprocess could be eventlet.green.subprocess if using eventlet,"},{"line_number":61,"context_line":"    or Python\u0027s subprocess otherwise."},{"line_number":62,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4a8e5d7a","line":59,"updated":"2014-06-04 15:35:32.000000000","message":"Revert this unrelated whitespace change. -- https://wiki.openstack.org/wiki/GitCommitMessages#Things_to_avoid_when_creating_commits","commit_id":"58d3368a764d60af579d86edee79a5cbe71afcb5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"57d784bb4c003adf7746cf69dadecf2fcffc9605","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # Catching IOError means there is an issue with"},{"line_number":76,"context_line":"        # the given file."},{"line_number":77,"context_line":"        err \u003d (\u0027Hit OSError in _process_communicate_handle_oserror: \u0027"},{"line_number":78,"context_line":"               \u0027%s: %s\u0027) % (try_file, e.strerror)"},{"line_number":79,"context_line":"        retcode \u003d 2"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    return retcode, err"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_cab26d05","line":78,"updated":"2014-06-04 15:35:32.000000000","message":"the change to the message is worse that it was (and the message was pretty bad to begin with). It was obvious before that the code doesn\u0027t really know what the problem was. Also, now it\u0027s going to print \"... _process_communicate_handle_oserror: xxx: xxx\", which is worse.","commit_id":"58d3368a764d60af579d86edee79a5cbe71afcb5"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"acdc10c0b5990372d8009188a396226aafc9fdaa","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # Catching IOError means there is an issue with"},{"line_number":76,"context_line":"        # the given file."},{"line_number":77,"context_line":"        err \u003d (\u0027Hit OSError in _process_communicate_handle_oserror: \u0027"},{"line_number":78,"context_line":"               \u0027%s: %s\u0027) % (try_file, e.strerror)"},{"line_number":79,"context_line":"        retcode \u003d 2"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    return retcode, err"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e323e602","line":78,"in_reply_to":"1ae5cdf2_cab26d05","updated":"2014-06-11 23:20:30.000000000","message":"Just removal of the ()\\n would be fine here if we\u0027re not making the error message better.","commit_id":"58d3368a764d60af579d86edee79a5cbe71afcb5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"57d784bb4c003adf7746cf69dadecf2fcffc9605","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # the given file."},{"line_number":77,"context_line":"        err \u003d (\u0027Hit OSError in _process_communicate_handle_oserror: \u0027"},{"line_number":78,"context_line":"               \u0027%s: %s\u0027) % (try_file, e.strerror)"},{"line_number":79,"context_line":"        retcode \u003d 2"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    return retcode, err"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ea7009de","line":79,"updated":"2014-06-04 15:35:32.000000000","message":"why 2? add a comment.","commit_id":"58d3368a764d60af579d86edee79a5cbe71afcb5"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"acdc10c0b5990372d8009188a396226aafc9fdaa","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # the given file."},{"line_number":77,"context_line":"        err \u003d (\u0027Hit OSError in _process_communicate_handle_oserror: \u0027"},{"line_number":78,"context_line":"               \u0027%s: %s\u0027) % (try_file, e.strerror)"},{"line_number":79,"context_line":"        retcode \u003d 2"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    return retcode, err"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_031d32be","line":79,"in_reply_to":"1ae5cdf2_ea7009de","updated":"2014-06-11 23:20:30.000000000","message":"++","commit_id":"58d3368a764d60af579d86edee79a5cbe71afcb5"}],"keystoneclient/tests/test_cms.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"57d784bb4c003adf7746cf69dadecf2fcffc9605","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import errno"},{"line_number":14,"context_line":"import os"},{"line_number":15,"context_line":"import subprocess"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1540f632","line":13,"updated":"2014-06-04 15:35:32.000000000","message":"moving the import is unnecessary for the fix. cleanup changes should be done in a separate commit.","commit_id":"58d3368a764d60af579d86edee79a5cbe71afcb5"}]}
