)]}'
{"keystoneclient/tests/v2_0/test_users.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"27e6f5c3448ecdb6584cbbfbffb4bf42dda88715","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                \"password\": None,"},{"line_number":117,"context_line":"                \"tenantId\": 2,"},{"line_number":118,"context_line":"                \"enabled\": True,"},{"line_number":119,"context_line":"                \"email\": None,"},{"line_number":120,"context_line":"            }"},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_95e098fb","line":119,"updated":"2014-06-04 07:46:42.000000000","message":"s/\"/\u0027\n\nall through here","commit_id":"d555c7a440c0a4dbf46ec6fb8a778af33056e086"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"e0de3604f0a6e6d82bbba9dfc8a71322634bda1d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                \"password\": None,"},{"line_number":117,"context_line":"                \"tenantId\": 2,"},{"line_number":118,"context_line":"                \"enabled\": True,"},{"line_number":119,"context_line":"                \"email\": None,"},{"line_number":120,"context_line":"            }"},{"line_number":121,"context_line":"        }"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_0749b5b6","line":119,"in_reply_to":"1ae5cdf2_95e098fb","updated":"2014-06-04 13:08:17.000000000","message":"Done","commit_id":"d555c7a440c0a4dbf46ec6fb8a778af33056e086"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"27e6f5c3448ecdb6584cbbfbffb4bf42dda88715","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.stub_url(httpretty.POST, [\u0027users\u0027], json\u003dresp_body)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        user \u003d self.client.users.create("},{"line_number":135,"context_line":"            req_body[\u0027user\u0027][\u0027name\u0027],"},{"line_number":136,"context_line":"            tenant_id\u003dreq_body[\u0027user\u0027][\u0027tenantId\u0027],"},{"line_number":137,"context_line":"            enabled\u003dreq_body[\u0027user\u0027][\u0027enabled\u0027])"},{"line_number":138,"context_line":"        self.assertIsInstance(user, users.User)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_75db0c4f","line":135,"updated":"2014-06-04 07:46:42.000000000","message":"i\u0027d prefer you defined these as variables and then referenced them in the body and here rather than creating with the body data.","commit_id":"d555c7a440c0a4dbf46ec6fb8a778af33056e086"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"e0de3604f0a6e6d82bbba9dfc8a71322634bda1d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.stub_url(httpretty.POST, [\u0027users\u0027], json\u003dresp_body)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        user \u003d self.client.users.create("},{"line_number":135,"context_line":"            req_body[\u0027user\u0027][\u0027name\u0027],"},{"line_number":136,"context_line":"            tenant_id\u003dreq_body[\u0027user\u0027][\u0027tenantId\u0027],"},{"line_number":137,"context_line":"            enabled\u003dreq_body[\u0027user\u0027][\u0027enabled\u0027])"},{"line_number":138,"context_line":"        self.assertIsInstance(user, users.User)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_27c95126","line":135,"in_reply_to":"1ae5cdf2_75db0c4f","updated":"2014-06-04 13:08:17.000000000","message":"Done","commit_id":"d555c7a440c0a4dbf46ec6fb8a778af33056e086"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8026be0820ddc352e75bc48e27d5d67d54af8b0f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @httpretty.activate"},{"line_number":112,"context_line":"    def test_create_user_without_password(self):"},{"line_number":113,"context_line":"        user_name \u003d \u0027test\u0027"},{"line_number":114,"context_line":"        tenant_id \u003d 2"},{"line_number":115,"context_line":"        user_enabled \u003d True"},{"line_number":116,"context_line":"        req_body \u003d {"},{"line_number":117,"context_line":"            \u0027user\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c3aed397","line":114,"updated":"2014-06-04 19:10:00.000000000","message":"IDs are typically UUIDs, so use a uuid here.","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"0626890e353c8e612e4709d17b716dfa83dda6f7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @httpretty.activate"},{"line_number":112,"context_line":"    def test_create_user_without_password(self):"},{"line_number":113,"context_line":"        user_name \u003d \u0027test\u0027"},{"line_number":114,"context_line":"        tenant_id \u003d 2"},{"line_number":115,"context_line":"        user_enabled \u003d True"},{"line_number":116,"context_line":"        req_body \u003d {"},{"line_number":117,"context_line":"            \u0027user\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_f9d9bcf3","line":114,"in_reply_to":"1ae5cdf2_c3aed397","updated":"2014-06-04 20:26:41.000000000","message":"Done","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8026be0820ddc352e75bc48e27d5d67d54af8b0f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        req_body \u003d {"},{"line_number":117,"context_line":"            \u0027user\u0027: {"},{"line_number":118,"context_line":"                \u0027name\u0027: user_name,"},{"line_number":119,"context_line":"                \u0027password\u0027: None,"},{"line_number":120,"context_line":"                \u0027tenantId\u0027: tenant_id,"},{"line_number":121,"context_line":"                \u0027enabled\u0027: user_enabled,"},{"line_number":122,"context_line":"                \u0027email\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_2374d734","line":119,"updated":"2014-06-04 19:10:00.000000000","message":"shouldn\u0027t the client not send the password rather than sending \"password\": null ?","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"0626890e353c8e612e4709d17b716dfa83dda6f7","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        req_body \u003d {"},{"line_number":117,"context_line":"            \u0027user\u0027: {"},{"line_number":118,"context_line":"                \u0027name\u0027: user_name,"},{"line_number":119,"context_line":"                \u0027password\u0027: None,"},{"line_number":120,"context_line":"                \u0027tenantId\u0027: tenant_id,"},{"line_number":121,"context_line":"                \u0027enabled\u0027: user_enabled,"},{"line_number":122,"context_line":"                \u0027email\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_99b43883","line":119,"in_reply_to":"1ae5cdf2_2374d734","updated":"2014-06-04 20:26:41.000000000","message":"I think it is not really needed, but to be consistent with email behavior when no email is set the client sent None\n\nIf you feel it must be removed i could do it","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8026be0820ddc352e75bc48e27d5d67d54af8b0f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                \u0027name\u0027: user_name,"},{"line_number":128,"context_line":"                \u0027enabled\u0027: user_enabled,"},{"line_number":129,"context_line":"                \u0027tenantId\u0027: tenant_id,"},{"line_number":130,"context_line":"                \u0027id\u0027: 3,"},{"line_number":131,"context_line":"            }"},{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_638a5f1c","line":130,"updated":"2014-06-04 19:10:00.000000000","message":"use a uuid here.","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"0626890e353c8e612e4709d17b716dfa83dda6f7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                \u0027name\u0027: user_name,"},{"line_number":128,"context_line":"                \u0027enabled\u0027: user_enabled,"},{"line_number":129,"context_line":"                \u0027tenantId\u0027: tenant_id,"},{"line_number":130,"context_line":"                \u0027id\u0027: 3,"},{"line_number":131,"context_line":"            }"},{"line_number":132,"context_line":"        }"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_39e08495","line":130,"in_reply_to":"1ae5cdf2_638a5f1c","updated":"2014-06-04 20:26:41.000000000","message":"Done","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8026be0820ddc352e75bc48e27d5d67d54af8b0f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        user \u003d self.client.users.create(user_name, tenant_id\u003dtenant_id,"},{"line_number":137,"context_line":"                                        enabled\u003duser_enabled)"},{"line_number":138,"context_line":"        self.assertIsInstance(user, users.User)"},{"line_number":139,"context_line":"        self.assertEqual(user.id, 3)"},{"line_number":140,"context_line":"        self.assertEqual(user.name, user_name)"},{"line_number":141,"context_line":"        self.assertRequestBodyIs(json\u003dreq_body)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c385f307","line":139,"updated":"2014-06-04 19:10:00.000000000","message":"(nit) the order of arguments is expected, actual.","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"0626890e353c8e612e4709d17b716dfa83dda6f7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        user \u003d self.client.users.create(user_name, tenant_id\u003dtenant_id,"},{"line_number":137,"context_line":"                                        enabled\u003duser_enabled)"},{"line_number":138,"context_line":"        self.assertIsInstance(user, users.User)"},{"line_number":139,"context_line":"        self.assertEqual(user.id, 3)"},{"line_number":140,"context_line":"        self.assertEqual(user.name, user_name)"},{"line_number":141,"context_line":"        self.assertRequestBodyIs(json\u003dreq_body)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_59f0f066","line":139,"in_reply_to":"1ae5cdf2_c385f307","updated":"2014-06-04 20:26:41.000000000","message":"Done","commit_id":"d780cb17e47181cbb203023362e6e61a8eff2f76"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"a8cbbf8e96a19e3471e31352f37a5c55b7b76b0f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.tests.v2_0 import utils"},{"line_number":17,"context_line":"from keystoneclient.v2_0 import users"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_31dc0b46","line":14,"updated":"2014-06-13 01:53:13.000000000","message":"it was right before uuid is stdlib so it goes before everything else.","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"646993d8596aa3f439d6923bc59b739bc3fb930f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.tests.v2_0 import utils"},{"line_number":17,"context_line":"from keystoneclient.v2_0 import users"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_b56806f6","line":14,"in_reply_to":"1ae5cdf2_31dc0b46","updated":"2014-06-13 03:17:41.000000000","message":"I think this is an artifact of upgrading hacking and pep8","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"aa73afca01c93fa0b49610a57de576fb4963057e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.tests.v2_0 import utils"},{"line_number":17,"context_line":"from keystoneclient.v2_0 import users"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_441a646f","line":14,"in_reply_to":"1ae5cdf2_32df9f6a","updated":"2014-07-01 02:29:10.000000000","message":"yes, please. http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"35bca3983010c3e65356a3fbf7f9f878bb50b3a1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.tests.v2_0 import utils"},{"line_number":17,"context_line":"from keystoneclient.v2_0 import users"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_32df9f6a","line":14,"in_reply_to":"1ae5cdf2_b56806f6","updated":"2014-06-13 11:52:07.000000000","message":"importing uuid before httpretty also likes to pep8.\n\nThis was a change during rebase, if you want me to change it I could upload another patch","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"4a2d8ef7372ab8b43614cd288aaa5157561c53df","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import httpretty"},{"line_number":14,"context_line":"import uuid"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from keystoneclient.tests.v2_0 import utils"},{"line_number":17,"context_line":"from keystoneclient.v2_0 import users"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_0ee95b80","line":14,"in_reply_to":"baada198_441a646f","updated":"2014-07-01 11:35:35.000000000","message":"Done","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"a8cbbf8e96a19e3471e31352f37a5c55b7b76b0f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.assertIsInstance(user, users.User)"},{"line_number":77,"context_line":"        self.assertEqual(user.id, user_id)"},{"line_number":78,"context_line":"        self.assertEqual(user.name, \"gabriel\")"},{"line_number":79,"context_line":"        self.assertEqual(user.email, \"test@example.com\")"},{"line_number":80,"context_line":"        self.assertRequestBodyIs(json\u003dreq_body)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @httpretty.activate"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_b16adb7e","line":79,"updated":"2014-06-13 01:53:13.000000000","message":"nit: order should be expected, found","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"35bca3983010c3e65356a3fbf7f9f878bb50b3a1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.assertIsInstance(user, users.User)"},{"line_number":77,"context_line":"        self.assertEqual(user.id, user_id)"},{"line_number":78,"context_line":"        self.assertEqual(user.name, \"gabriel\")"},{"line_number":79,"context_line":"        self.assertEqual(user.email, \"test@example.com\")"},{"line_number":80,"context_line":"        self.assertRequestBodyIs(json\u003dreq_body)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @httpretty.activate"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_d2875b5f","line":79,"in_reply_to":"1ae5cdf2_b16adb7e","updated":"2014-06-13 11:52:07.000000000","message":"this is quite old, Perhaps we could create another bug and add it to wishlist","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"f3ce07d899bf2d605864854a1a0edce81ac299bf","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @httpretty.activate"},{"line_number":119,"context_line":"    def test_create_user_without_password(self):"},{"line_number":120,"context_line":"        user_name \u003d \u0027test\u0027"},{"line_number":121,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":122,"context_line":"        tenant_id \u003d uuid.uuid4().hex"},{"line_number":123,"context_line":"        user_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_9a7a8a22","line":120,"updated":"2014-06-11 18:10:24.000000000","message":"I\u0027m not sure what you are testing here? This test will work even without your change?","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"d953e482b9d057abf016b1e754c560c6278e015d","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @httpretty.activate"},{"line_number":119,"context_line":"    def test_create_user_without_password(self):"},{"line_number":120,"context_line":"        user_name \u003d \u0027test\u0027"},{"line_number":121,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":122,"context_line":"        tenant_id \u003d uuid.uuid4().hex"},{"line_number":123,"context_line":"        user_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_cfdb52eb","line":120,"in_reply_to":"1ae5cdf2_7a03fe41","updated":"2014-06-12 16:33:21.000000000","message":"What I  meant was, this actually  testing python default arg behavior and no functionality as such","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"c4f0f2597d1fcd800d888a07a3b15e0139fae039","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @httpretty.activate"},{"line_number":119,"context_line":"    def test_create_user_without_password(self):"},{"line_number":120,"context_line":"        user_name \u003d \u0027test\u0027"},{"line_number":121,"context_line":"        user_id \u003d uuid.uuid4().hex"},{"line_number":122,"context_line":"        tenant_id \u003d uuid.uuid4().hex"},{"line_number":123,"context_line":"        user_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_7a03fe41","line":120,"in_reply_to":"1ae5cdf2_9a7a8a22","updated":"2014-06-11 18:19:41.000000000","message":"No really, if you see line 144, the password is not passes to create.\n\nThis test also check that if no password parameter is passed to create the request body fill password\u003dNone (line 128)\n\nThanks for yours comments","commit_id":"68cd646adbeffbfd0ad789cf5582c45d52c7288e"}]}