)]}'
{"keystoneclient/middleware/auth_token.py":[{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"9d280bb217192f7d2db6c8b939edad56c55aae33","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"                if _token_is_v3(token_info):"},{"line_number":1031,"context_line":"                    catalog \u003d _v3_to_v2_catalog(catalog)"},{"line_number":1032,"context_line":"                rval[\u0027X-Service-Catalog\u0027] \u003d jsonutils.dumps(catalog)"},{"line_number":1033,"context_line":"            elif self.service_catalog:"},{"line_number":1034,"context_line":"                rval[\u0027X-Service-Catalog\u0027] \u003d \\"},{"line_number":1035,"context_line":"                    jsonutils.dumps(self.service_catalog)"},{"line_number":1036,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_0d152648","line":1033,"updated":"2014-06-05 16:32:33.000000000","message":"you are essentially using the admin user\u0027s service catalog instead of the requesting user\u0027s. Please make it configurable so it won\u0027t break endpoint filtering.","commit_id":"489007c8da40aa057e74bba641bf9cf74fa45659"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"fbedf4cdba0d7eff858293468619c5adb367b55a","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                default\u003dTrue,"},{"line_number":311,"context_line":"                help\u003d\u0027(optional) populate X-Service-Catalog from admin token\u0027"},{"line_number":312,"context_line":"                \u0027 response. If True, and catalog is not provided, it will be\u0027"},{"line_number":313,"context_line":"                \u0027 repopulated from admin token. If False, and catalog is not\u0027"},{"line_number":314,"context_line":"                \u0027 provided, X-Service-Catalog will be empty.\u0027),"},{"line_number":315,"context_line":"    cfg.StrOpt(\u0027enforce_token_bind\u0027,"},{"line_number":316,"context_line":"               default\u003d\u0027permissive\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_b640fa07","line":313,"updated":"2014-06-05 19:12:07.000000000","message":"If true, are u always going to assume, that service catalog is not provided.\nWhat  if the token already had  service catalog?\nAlso how does this work if the token is passed from one service to another service.? Are we assuming all the services will be configured with True or False. What will happen if one service use True and other use False, and the token is passed from one to other","commit_id":"0e6d02cd0de5812e59b79266c2fbaac78525992e"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"0eb71e011a6612305d7604fe6cf771f393bb1feb","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                default\u003dTrue,"},{"line_number":311,"context_line":"                help\u003d\u0027(optional) populate X-Service-Catalog from admin token\u0027"},{"line_number":312,"context_line":"                \u0027 response. If True, and catalog is not provided, it will be\u0027"},{"line_number":313,"context_line":"                \u0027 repopulated from admin token. If False, and catalog is not\u0027"},{"line_number":314,"context_line":"                \u0027 provided, X-Service-Catalog will be empty.\u0027),"},{"line_number":315,"context_line":"    cfg.StrOpt(\u0027enforce_token_bind\u0027,"},{"line_number":316,"context_line":"               default\u003d\u0027permissive\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_2298151b","line":313,"in_reply_to":"1ae5cdf2_b640fa07","updated":"2014-06-06 10:21:50.000000000","message":"If true, and catalog IS NOT provided, catalog will be repopulated. If token already HAD service catalog, then middleware use catalog from token (old behaviour).\n\nThis options controls behaviour only in case when catalog it requested by include_service_catalog and absent in signed part of PKI token.","commit_id":"0e6d02cd0de5812e59b79266c2fbaac78525992e"},{"author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"change_message_id":"0c9f39a3e9c8381027989e1e7d32aab5802aa1f7","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"    @property"},{"line_number":1499,"context_line":"    def service_catalog(self):"},{"line_number":1500,"context_line":"        if not self._service_catalog:"},{"line_number":1501,"context_line":"            self.get_admin_token()"},{"line_number":1502,"context_line":"        return self._service_catalog"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    def _service_catalog_set(self, token_info):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_e2528e67","line":1501,"updated":"2014-06-07 17:50:00.000000000","message":"there may be a side-effect with this approach. If there\u0027s a misconfiguration and no catalog is returned from admin token, you could get into an infinite loop.","commit_id":"0e6d02cd0de5812e59b79266c2fbaac78525992e"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"6e35f41fb30b8c009849d4289e31e4b69e9f261c","unresolved":false,"context_lines":[{"line_number":1498,"context_line":"    @property"},{"line_number":1499,"context_line":"    def service_catalog(self):"},{"line_number":1500,"context_line":"        if not self._service_catalog:"},{"line_number":1501,"context_line":"            self.get_admin_token()"},{"line_number":1502,"context_line":"        return self._service_catalog"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    def _service_catalog_set(self, token_info):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_3224adc5","line":1501,"in_reply_to":"1ae5cdf2_e2528e67","updated":"2014-06-09 11:53:58.000000000","message":"No, because here is I\u0027m doing only one attempt to get token. If it fails, no service_catalog will be returned.","commit_id":"0e6d02cd0de5812e59b79266c2fbaac78525992e"}]}