)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"92646af0cd435629b4e2d57f150b44ff33b58a94","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Berendt \u003cberendt@b1-systems.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-05 07:26:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Overwrite HelpFormatter constructur to extend argument column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Overwrite the HelpFormatter constructor in the class"},{"line_number":10,"context_line":"OpenStackHelpFormatter to modify the default value of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_30776e04","line":7,"updated":"2014-06-30 23:24:25.000000000","message":"constructor?","commit_id":"90802a7dd4b7231a6cd403f065b5c48da8358d81"}],"keystoneclient/shell.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"d0ada64ebb61a75dfe924cd0c34de8993b664269","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    def __init__(self, prog, indent_increment\u003d2, max_help_position\u003d28,"},{"line_number":482,"context_line":"                 width\u003dNone):"},{"line_number":483,"context_line":"        super(OpenStackHelpFormatter, self).__init__(prog, indent_increment,"},{"line_number":484,"context_line":"              max_help_position, width)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    def start_section(self, heading):"},{"line_number":487,"context_line":"        # Title-case the headings"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_97579c25","line":484,"updated":"2014-06-05 01:24:17.000000000","message":"-1: max_help should be aligned to prog, or prog should be in a new line","commit_id":"f651466cbb2bc398d660c99920e12fd2a20dccee"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"cc8299855a6c75549a78119e3d13ebfdce49ce5c","unresolved":false,"context_lines":[{"line_number":479,"context_line":"# I\u0027m picky about my shell help."},{"line_number":480,"context_line":"class OpenStackHelpFormatter(argparse.HelpFormatter):"},{"line_number":481,"context_line":"    def __init__(self, prog, indent_increment\u003d2, max_help_position\u003d28,"},{"line_number":482,"context_line":"                 width\u003dNone):"},{"line_number":483,"context_line":"        super(OpenStackHelpFormatter, self).__init__(prog, indent_increment,"},{"line_number":484,"context_line":"                                                     max_help_position, width)"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_63cd1631","line":482,"updated":"2014-06-11 23:24:12.000000000","message":"Would it make sense to try and do this a bit more programatically (up to a maximum column width)? \"options are X size [max] so set this to X unless X \u003e MAX.\n\nChanging this each time we have a length change seems like potentially the wrong approach (hard-coded values)","commit_id":"90802a7dd4b7231a6cd403f065b5c48da8358d81"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"92646af0cd435629b4e2d57f150b44ff33b58a94","unresolved":false,"context_lines":[{"line_number":479,"context_line":"# I\u0027m picky about my shell help."},{"line_number":480,"context_line":"class OpenStackHelpFormatter(argparse.HelpFormatter):"},{"line_number":481,"context_line":"    def __init__(self, prog, indent_increment\u003d2, max_help_position\u003d28,"},{"line_number":482,"context_line":"                 width\u003dNone):"},{"line_number":483,"context_line":"        super(OpenStackHelpFormatter, self).__init__(prog, indent_increment,"},{"line_number":484,"context_line":"                                                     max_help_position, width)"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_10518a62","line":482,"in_reply_to":"1ae5cdf2_63cd1631","updated":"2014-06-30 23:24:25.000000000","message":"It would be really cool if this isn\u0027t too much effort.  If it is and/or the solution is too ugly I\u0027d be OK with this as is.","commit_id":"90802a7dd4b7231a6cd403f065b5c48da8358d81"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"1cb5b238b141a77b49f2308d55ead7160faf52c5","unresolved":false,"context_lines":[{"line_number":440,"context_line":"    def add_arguments(self, actions):"},{"line_number":441,"context_line":"        for action in filter(lambda x: not x.option_strings, actions):"},{"line_number":442,"context_line":"            for choice in action.choices:"},{"line_number":443,"context_line":"                length \u003d len(choice) + 6"},{"line_number":444,"context_line":"                if(length \u003e self._max_help_position and length \u003c\u003d 32):"},{"line_number":445,"context_line":"                    self._max_help_position \u003d length"},{"line_number":446,"context_line":"        super(OpenStackHelpFormatter, self).add_arguments(actions)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_97ab77d5","line":443,"updated":"2014-07-02 21:21:29.000000000","message":"It is unclear why +6 and not + 7?  I would define a variable with meaningful name then assign 6 to it.","commit_id":"c741448644f5773c52013d5edd2554e9cf367244"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c6c07867dae780f25bc8207e309c3efb61c88abd","unresolved":false,"context_lines":[{"line_number":440,"context_line":"    def add_arguments(self, actions):"},{"line_number":441,"context_line":"        for action in filter(lambda x: not x.option_strings, actions):"},{"line_number":442,"context_line":"            for choice in action.choices:"},{"line_number":443,"context_line":"                length \u003d len(choice) + 6"},{"line_number":444,"context_line":"                if(length \u003e self._max_help_position and length \u003c\u003d 32):"},{"line_number":445,"context_line":"                    self._max_help_position \u003d length"},{"line_number":446,"context_line":"        super(OpenStackHelpFormatter, self).add_arguments(actions)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_6e3522d9","line":443,"in_reply_to":"baada198_97ab77d5","updated":"2014-07-03 08:08:29.000000000","message":"6 is simply the fixed indent before the names of the positional arguments.","commit_id":"c741448644f5773c52013d5edd2554e9cf367244"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"1cb5b238b141a77b49f2308d55ead7160faf52c5","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        for action in filter(lambda x: not x.option_strings, actions):"},{"line_number":442,"context_line":"            for choice in action.choices:"},{"line_number":443,"context_line":"                length \u003d len(choice) + 6"},{"line_number":444,"context_line":"                if(length \u003e self._max_help_position and length \u003c\u003d 32):"},{"line_number":445,"context_line":"                    self._max_help_position \u003d length"},{"line_number":446,"context_line":"        super(OpenStackHelpFormatter, self).add_arguments(actions)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_9747f71c","line":444,"updated":"2014-07-02 21:21:29.000000000","message":"Similar to my comment above.  Please define 32.","commit_id":"c741448644f5773c52013d5edd2554e9cf367244"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"c6c07867dae780f25bc8207e309c3efb61c88abd","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        for action in filter(lambda x: not x.option_strings, actions):"},{"line_number":442,"context_line":"            for choice in action.choices:"},{"line_number":443,"context_line":"                length \u003d len(choice) + 6"},{"line_number":444,"context_line":"                if(length \u003e self._max_help_position and length \u003c\u003d 32):"},{"line_number":445,"context_line":"                    self._max_help_position \u003d length"},{"line_number":446,"context_line":"        super(OpenStackHelpFormatter, self).add_arguments(actions)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_6e4c4271","line":444,"in_reply_to":"baada198_9747f71c","updated":"2014-07-03 08:08:29.000000000","message":"32 is the maximum width used for the column.","commit_id":"c741448644f5773c52013d5edd2554e9cf367244"}]}
