)]}'
{"id":"openstack%2Fpython-keystoneclient~99432","triplet_id":"openstack%2Fpython-keystoneclient~master~If5b196a734e7a0f0b3fa892d5c0436812a5bbd85","project":"openstack/python-keystoneclient","branch":"master","topic":"less_token_exposure","hashtags":[],"change_id":"If5b196a734e7a0f0b3fa892d5c0436812a5bbd85","subject":"Do not expose Token IDs in debug output","status":"ABANDONED","created":"2014-06-11 17:17:02.000000000","updated":"2014-07-03 17:20:12.000000000","total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0e3aee3bad1f90467a30680ec700ee89c8286aa7","_number":99432,"virtual_id_number":99432,"owner":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":-1,"date":"2014-06-18 18:17:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"date":"2014-06-20 23:04:02.000000000","_account_id":8180,"name":"Joel Friedly","email":"joelfriedly@gmail.com","username":"jfriedly"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},{"date":"2014-06-19 18:05:46.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8180,"name":"Joel Friedly","email":"joelfriedly@gmail.com","username":"jfriedly"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":-2,"date":"2014-06-18 17:12:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"date":"2014-06-26 16:13:03.000000000","_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8180,"name":"Joel Friedly","email":"joelfriedly@gmail.com","username":"jfriedly"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},{"_account_id":8180,"name":"Joel Friedly","email":"joelfriedly@gmail.com","username":"jfriedly"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-06-11 17:17:19.000000000","updated_by":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"reviewer":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"state":"REVIEWER"},{"updated":"2014-06-11 17:17:19.000000000","updated_by":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"reviewer":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"state":"REVIEWER"},{"updated":"2014-06-11 17:17:19.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2014-06-11 17:17:19.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2014-06-11 17:17:19.000000000","updated_by":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"reviewer":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"state":"REVIEWER"},{"updated":"2014-06-11 17:20:25.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2014-06-11 18:32:11.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-06-12 06:35:37.000000000","updated_by":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"reviewer":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"state":"REVIEWER"},{"updated":"2014-06-13 18:10:03.000000000","updated_by":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"reviewer":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"state":"REVIEWER"},{"updated":"2014-06-13 18:14:51.000000000","updated_by":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"reviewer":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"state":"REVIEWER"},{"updated":"2014-06-16 22:28:53.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2014-06-17 19:42:04.000000000","updated_by":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"reviewer":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"state":"REVIEWER"},{"updated":"2014-06-17 20:53:12.000000000","updated_by":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"reviewer":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"state":"REVIEWER"},{"updated":"2014-06-17 21:27:44.000000000","updated_by":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"reviewer":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"state":"REVIEWER"},{"updated":"2014-06-17 23:55:11.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-06-18 18:17:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-06-19 18:05:46.000000000","updated_by":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"reviewer":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"state":"REVIEWER"},{"updated":"2014-06-20 23:04:02.000000000","updated_by":{"_account_id":8180,"name":"Joel Friedly","email":"joelfriedly@gmail.com","username":"jfriedly"},"reviewer":{"_account_id":8180,"name":"Joel Friedly","email":"joelfriedly@gmail.com","username":"jfriedly"},"state":"REVIEWER"},{"updated":"2014-06-26 16:13:03.000000000","updated_by":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"reviewer":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"state":"REVIEWER"}],"messages":[{"id":"2abbd53d1034f60386f4936e9028fe487fbc7464","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-11 17:17:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"22655319b6610961e03972f2cfa102cf216bf3a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-11 17:17:03.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0120f449d22f2796effe2fba44af4ff23048af23","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2014-06-11 17:20:25.000000000","message":"Patch Set 1: Code-Review+1\n\nYes please.","accounts_in_message":[],"_revision_number":1},{"id":"971a36a86cac3ce12d8f0f79081413cd2653eee7","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-11 18:22:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ed3f616ec4c7f5d28ff33d614563247ba79d3468","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-11 18:22:30.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"6e45d8cd3174d9a7cd34a82912895e2992ef7191","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-06-11 18:32:11.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6926248442d37a8fd2b2d1ddea4c6f4106517025","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-11 20:18:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/99432/2/check/gate-python-keystoneclient-pep8/214beb7 : SUCCESS in 57s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/99432/2/check/gate-python-keystoneclient-docs/93468c2/doc/build/html/ : SUCCESS in 1m 26s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/99432/2/check/gate-python-keystoneclient-python26/597a5dc : SUCCESS in 3m 21s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/99432/2/check/gate-python-keystoneclient-python27/530212f : SUCCESS in 3m 31s\n- check-tempest-dsvm-full http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-full/1d06ab8 : SUCCESS in 1h 02m 16s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-postgres-full/2e2f04d : SUCCESS in 1h 03m 49s\n- check-tempest-dsvm-neutron http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-neutron/4f878b1 : SUCCESS in 1h 04m 34s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-neutron-heat-slow/e23e9ff : SUCCESS in 26m 21s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/32/99432/2/check/check-grenade-dsvm/d0789da : SUCCESS in 47m 09s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-full-havana/65b6d94 : SUCCESS in 40m 16s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-neutron-havana/4bf6d52 : SUCCESS in 32m 08s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-full-icehouse/b35ebbc : SUCCESS in 58m 13s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-neutron-icehouse/9c2c607 : SUCCESS in 1h 04m 21s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/99432/2/check/gate-python-keystoneclient-python33/7922db9 : SUCCESS in 6m 47s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/99432/2/check/check-devstack-dsvm-cells/7ec2c43 : SUCCESS in 15m 38s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/99432/2/check/gate-tempest-dsvm-large-ops/bd37dbc : SUCCESS in 32m 12s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/99432/2/check/gate-tempest-dsvm-neutron-large-ops/4f4b25b : SUCCESS in 25m 14s\n- check-tempest-dsvm-full-apache-services http://logs.openstack.org/32/99432/2/check/check-tempest-dsvm-full-apache-services/a1508cf : FAILURE in 8m 49s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e7904bf6147bd0930203d2edb15da59e0adaa1c0","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-06-12 03:36:03.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fe795088a3d09b0737a042b7e633bca4f5648055","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-12 03:38:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f4e09fe43971a2087c9a3d59cebfd7c5564e14cf","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-12 04:31:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d77ba398900d8b81a9644564b7c6f805c8108efc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 04:32:02.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"2dd3f7eeb4fa34c70a9bc0f8bd681a1517fac1ae","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-12 04:32:18.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"322e1aba5eb9eca3809a0a81c5583190c4676eb4","author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"date":"2014-06-12 04:36:50.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"db5d97840b5acae865c72e0d785e71dd28111136","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-12 05:01:55.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e79f9e6eb6cd902d1200e4edc6f187083b295d64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 05:01:57.000000000","message":"Patch Set 4:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"f55f06f7c1347ff7d9025669cbce4356d4b642db","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-06-12 06:13:57.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"bf22d39992b02932d779bff8b07ae0217ddc9769","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 06:16:38.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/99432/4/check/gate-python-keystoneclient-pep8/afa9096 : SUCCESS in 1m 49s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/99432/4/check/gate-python-keystoneclient-docs/04779b7/doc/build/html/ : SUCCESS in 2m 44s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/99432/4/check/gate-python-keystoneclient-python26/b899171 : SUCCESS in 58s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/99432/4/check/gate-python-keystoneclient-python27/2566e36 : SUCCESS in 1m 24s\n- check-tempest-dsvm-full http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-full/1ea8089 : SUCCESS in 57m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-postgres-full/84211c1 : SUCCESS in 56m 54s\n- check-tempest-dsvm-neutron http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-neutron/8505919 : SUCCESS in 59m 02s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-neutron-heat-slow/aa6495e : SUCCESS in 21m 42s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/32/99432/4/check/check-grenade-dsvm/e3625ad : SUCCESS in 40m 29s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-full-havana/6708588 : SUCCESS in 34m 16s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-neutron-havana/7b9413e : SUCCESS in 33m 47s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-full-icehouse/0991e27 : SUCCESS in 53m 32s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-neutron-icehouse/36a0985 : SUCCESS in 56m 04s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/99432/4/check/gate-python-keystoneclient-python33/3d6d8a3 : SUCCESS in 3m 22s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/99432/4/check/check-devstack-dsvm-cells/f3b2553 : SUCCESS in 13m 23s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/99432/4/check/gate-tempest-dsvm-large-ops/c884cd8 : SUCCESS in 27m 21s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/99432/4/check/gate-tempest-dsvm-neutron-large-ops/04dc874 : SUCCESS in 24m 33s\n- check-tempest-dsvm-full-apache-services http://logs.openstack.org/32/99432/4/check/check-tempest-dsvm-full-apache-services/4b83742 : FAILURE in 6m 11s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"57c033889292880ab1c23620035cb771e3d3b951","author":{"_account_id":11387,"name":"Sam Leong","email":"chio-fai-sam.leong@hpe.com","username":"Chioleong"},"date":"2014-06-12 06:35:37.000000000","message":"Patch Set 4: Code-Review-1\n\nHiding the token ID is good on the security side; however that piece of information may be helpful for debugging in some cases. So this is the down side for debugging.\n\nI would suggest to add a config parameter so that hiding(hashing) the token ID can be configurable.","accounts_in_message":[],"_revision_number":4},{"id":"8a85ad3efa14e8c6b2e9c02c4863804647588d5e","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-12 16:48:32.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"33fb0dac4fdc40701cbf9de9aee5ee6fd047f408","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 16:48:33.000000000","message":"Patch Set 5:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"9454bbd23324ca0bd64307f63969d6bf17a6cdb5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-12 18:45:29.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/99432/5/check/gate-python-keystoneclient-pep8/04cb648 : SUCCESS in 1m 03s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/99432/5/check/gate-python-keystoneclient-docs/3225941/doc/build/html/ : SUCCESS in 2m 37s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/99432/5/check/gate-python-keystoneclient-python26/745ce41 : SUCCESS in 1m 48s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/99432/5/check/gate-python-keystoneclient-python27/8956945 : SUCCESS in 2m 07s\n- check-tempest-dsvm-full http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-full/faea405 : SUCCESS in 57m 37s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-postgres-full/557ffb3 : SUCCESS in 52m 45s\n- check-tempest-dsvm-neutron http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-neutron/2d6190c : SUCCESS in 1h 00m 46s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-neutron-heat-slow/931457b : SUCCESS in 21m 11s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/32/99432/5/check/check-grenade-dsvm/7c604ca : SUCCESS in 36m 42s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-full-havana/86d2cf8 : SUCCESS in 37m 05s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-neutron-havana/201fc98 : SUCCESS in 33m 27s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-full-icehouse/a314b81 : SUCCESS in 57m 09s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-neutron-icehouse/e618f40 : SUCCESS in 1h 00m 04s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/99432/5/check/gate-python-keystoneclient-python33/8fcfb9e : SUCCESS in 5m 00s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/99432/5/check/check-devstack-dsvm-cells/8bc3e2a : SUCCESS in 12m 52s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/99432/5/check/gate-tempest-dsvm-large-ops/ac07232 : SUCCESS in 29m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/99432/5/check/gate-tempest-dsvm-neutron-large-ops/14269cb : SUCCESS in 22m 42s\n- check-tempest-dsvm-full-apache-services http://logs.openstack.org/32/99432/5/check/check-tempest-dsvm-full-apache-services/7df436d : FAILURE in 5m 25s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"2d953f130ab89e5220b9d0284f3fa2e4bf592cdb","author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"date":"2014-06-12 23:22:37.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"a8fbe9924064c1cbe110b15ba34fe33ad9a923bf","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-06-12 23:32:13.000000000","message":"Patch Set 5: Code-Review-1\n\n(2 comments)\n\nI don\u0027t think we should be excluding SHA1 being use in CMS. Its like given up the forest to save a tree. This is for sanitizing debug output only so why can\u0027t we use something like MD5 to obscure the token ID. My understanding is that the insecure claim against MD5 is that it produces higher rate of collisions. However it is still irreversible. So using it just for obscuring debug message should be fine so as long as token IDs are relative short-live (less than 24 hours) and not recyclable.","accounts_in_message":[],"_revision_number":5},{"id":"e43e2b15c6a69701ee87d8c84a39ee1d3cb2a812","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-12 23:35:54.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"8b5852d862a063862728653fbdfd637a7fcaa4bb","author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"date":"2014-06-13 04:21:33.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)\n\nClearly, we can\u0027t spit out tokens in cleartext but if this change is for debugging purposes then why do we need to hash the token? Is there a business case for having hashed tokens in the logs? Can we not simply replace the token with one or more asterisks?","accounts_in_message":[],"_revision_number":5},{"id":"5706e97cab9881cf18991669e107c7f86a926056","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-13 15:57:08.000000000","message":"Patch Set 5:\n\nThere has been an explicit ask for letting us correlate if a token has been used multiple times (across different requests). Some actions will reuse tokens, and it is important to know if the token was used repeatedly (maybe the token expired?).\n\nI started by redacting the token completely from the log and was asked for an alternative.","accounts_in_message":[],"_revision_number":5},{"id":"08dd614f70620253732068ad2eb654b870398406","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-13 15:59:39.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"845e9e7caffb67da423e13747761315e50ab9f2c","author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"date":"2014-06-13 18:10:03.000000000","message":"Patch Set 5: Code-Review+1\n\nThanks Morgan for the confirmation on the business case. Might be a nice addition to the commit message to mention the use case for hashing the token in the logs.","accounts_in_message":[],"_revision_number":5},{"id":"d843d371db45191dea0a1dd0f95d4176a25e12b2","author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"date":"2014-06-13 18:14:51.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"9ced5aeaa66067dfaad2065f5a638f8014cd4e8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-13 21:40:20.000000000","message":"Patch Set 6:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"71a1e1fef132f116f0792a1c4a70e0f4597f5ea5","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-13 21:40:20.000000000","message":"Patch Set 6: Commit message was updated","accounts_in_message":[],"_revision_number":6},{"id":"c7267819409516c6eaa2024c9bd7ac14362bf0f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-13 23:19:21.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/99432/6/check/gate-python-keystoneclient-pep8/8fda679 : SUCCESS in 1m 39s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/99432/6/check/gate-python-keystoneclient-docs/47f34ce/doc/build/html/ : SUCCESS in 2m 37s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/99432/6/check/gate-python-keystoneclient-python26/433836b : SUCCESS in 1m 46s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/99432/6/check/gate-python-keystoneclient-python27/2062022 : SUCCESS in 1m 53s\n- check-tempest-dsvm-full http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-full/4ce5436 : SUCCESS in 50m 37s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-postgres-full/356fe48 : SUCCESS in 50m 03s\n- check-tempest-dsvm-neutron http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-neutron/6104b7d : SUCCESS in 56m 48s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-neutron-heat-slow/d917b6f : SUCCESS in 20m 43s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/32/99432/6/check/check-grenade-dsvm/a966f5c : FAILURE in 55m 02s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-full-havana/bc420f4 : SUCCESS in 33m 32s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-neutron-havana/7c83398 : SUCCESS in 35m 20s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-full-icehouse/889ade3 : SUCCESS in 49m 42s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-neutron-icehouse/1fbadcc : SUCCESS in 59m 49s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/99432/6/check/gate-python-keystoneclient-python33/b943091 : SUCCESS in 5m 06s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/99432/6/check/check-devstack-dsvm-cells/5a2057b : SUCCESS in 12m 54s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/99432/6/check/gate-tempest-dsvm-large-ops/08dbcbe : SUCCESS in 30m 16s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/99432/6/check/gate-tempest-dsvm-neutron-large-ops/2347d47 : SUCCESS in 25m 40s\n- check-tempest-dsvm-full-apache-services http://logs.openstack.org/32/99432/6/check/check-tempest-dsvm-full-apache-services/fdcdc2d : FAILURE in 6m 03s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"41db50aee1d095d76274268af05e403d441d2290","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-16 19:23:23.000000000","message":"Patch Set 7: Patch Set 6 was rebased","accounts_in_message":[],"_revision_number":6},{"id":"d2e2114efabb5fa7e12014b15f6e39f4308e537d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-16 19:23:24.000000000","message":"Patch Set 7:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"b66ab81b3f835457bf39296b3bf391f70591cc2a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-16 21:45:15.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-pep8/4446d0a : SUCCESS in 1m 35s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/99432/7/check/gate-python-keystoneclient-docs/d7fccb4/doc/build/html/ : SUCCESS in 2m 27s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-python26/b992d6f : SUCCESS in 2m 02s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-python27/c0807c3 : SUCCESS in 1m 35s\n- check-tempest-dsvm-full http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full/3b284c3 : SUCCESS in 50m 21s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-postgres-full/34530e0 : SUCCESS in 55m 25s\n- check-tempest-dsvm-neutron http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron/16c0098 : SUCCESS in 58m 38s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron-heat-slow/3375bae : SUCCESS in 20m 57s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/32/99432/7/check/check-grenade-dsvm/d3e64fe : SUCCESS in 40m 54s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full-havana/da16acb : SUCCESS in 36m 25s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron-havana/34f481e : SUCCESS in 33m 21s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full-icehouse/2ad7706 : FAILURE in 57m 07s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron-icehouse/b0818a5 : SUCCESS in 57m 43s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-python33/1bf3e24 : SUCCESS in 5m 39s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/99432/7/check/check-devstack-dsvm-cells/377ed8f : SUCCESS in 12m 58s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/99432/7/check/gate-tempest-dsvm-large-ops/3556798 : SUCCESS in 30m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/99432/7/check/gate-tempest-dsvm-neutron-large-ops/32f6ba6 : SUCCESS in 24m 40s\n- check-tempest-dsvm-full-apache-services http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full-apache-services/4e5a6aa : FAILURE in 49m 33s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"0d848d789787507634b0f447d0888b2a6b32b7ce","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-06-16 22:28:53.000000000","message":"Patch Set 7:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- check-tempest-dsvm-full-icehouse: https://bugs.launchpad.net/bugs/1273292 https://bugs.launchpad.net/bugs/1254890 https://bugs.launchpad.net/bugs/1254972\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1273292\nFor bug details see: http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":7},{"id":"f5383ba3dd0333311e0d5bebc03cbd3d7ad6689e","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-17 17:03:44.000000000","message":"Patch Set 7:\n\nrecheck bug 1273292","accounts_in_message":[],"_revision_number":7},{"id":"58f2c3c4365c0af42c187a66ae82be1236af56a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-17 17:03:45.000000000","message":"Patch Set 7: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"7573154030dbf3f0ecb35df517add8b349af8afd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-17 18:27:50.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded.\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-pep8/a56f9d6 : SUCCESS in 1m 53s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/99432/7/check/gate-python-keystoneclient-docs/83d82c8/doc/build/html/ : SUCCESS in 2m 37s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-python26/3e51aff : SUCCESS in 1m 58s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-python27/3d83377 : SUCCESS in 1m 00s\n- check-tempest-dsvm-full http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full/d03ecc6 : SUCCESS in 43m 54s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-postgres-full/3a8a326 : SUCCESS in 45m 13s\n- check-tempest-dsvm-neutron http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron/e3aba39 : SUCCESS in 55m 18s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron-heat-slow/894fbf1 : SUCCESS in 20m 27s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/32/99432/7/check/check-grenade-dsvm/d9bf31d : SUCCESS in 41m 06s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full-havana/8cb4e0c : SUCCESS in 36m 05s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron-havana/afc47dc : SUCCESS in 33m 41s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full-icehouse/2c9bc3e : SUCCESS in 48m 49s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-neutron-icehouse/97fdff2 : SUCCESS in 59m 29s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/99432/7/check/gate-python-keystoneclient-python33/fe574ea : SUCCESS in 5m 15s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/99432/7/check/check-devstack-dsvm-cells/66c7818 : SUCCESS in 13m 09s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/99432/7/check/gate-tempest-dsvm-large-ops/c2d552b : SUCCESS in 29m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/99432/7/check/gate-tempest-dsvm-neutron-large-ops/9eee254 : SUCCESS in 26m 04s\n- check-tempest-dsvm-full-apache-services http://logs.openstack.org/32/99432/7/check/check-tempest-dsvm-full-apache-services/5d4a5ee : FAILURE in 43m 13s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"f981aa7b9d3d8c0192cf42134007fccf7dafe0fc","author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"date":"2014-06-17 19:42:04.000000000","message":"Patch Set 7: Code-Review+1\n\n(2 comments)\n\nI have one minor inline comment where we might want to improve the help output, but I\u0027m fine with it either way.","accounts_in_message":[],"_revision_number":7},{"id":"d1a904d222cae115a12168ead26ef7fd021836f8","author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"date":"2014-06-17 20:53:12.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"302307967f8d68cee12b5a27191fa5076a233c25","author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"date":"2014-06-17 21:27:44.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"bbe4b5d266c3736feeb54adf726fc02f83f2edca","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-06-17 21:29:40.000000000","message":"Patch Set 7: Code-Review-2\n\nWe can\u0027t introduce anything that requires  hash algorithm that will fail compliance.  SHA1 has the same issues as MD5.  It is not a security issue, just compliance.","accounts_in_message":[],"_revision_number":7},{"id":"3741efd6157e1e3a3fee1bd6460a109f9e28c53f","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-17 23:51:24.000000000","message":"Patch Set 7:\n\nWould this really fail compliance? I\u0027m curious if it would - since the data isn\u0027t usable for anything except tracking in the logs. I think this is a misplaced -2.\n\nI don\u0027t disagree there could be a better way, but i don\u0027t think this is a compliance issue.","accounts_in_message":[],"_revision_number":7},{"id":"5467f9bb73a273dc0231663127edcf12b83e9deb","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-17 23:55:00.000000000","message":"Patch Set 7: Code-Review-2 Workflow-1\n\nTalked over, will move to an opaque tracking id to solve compliance issues.","accounts_in_message":[],"_revision_number":7},{"id":"eedb0b65c9f2960d084efe819558ec020954e47d","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-06-17 23:55:11.000000000","message":"Patch Set 7: Code-Review-1\n\ngoing to go with a non-hashing solution.","accounts_in_message":[],"_revision_number":7},{"id":"135323087a250c2ec4a5a3e57105d5808be15983","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-18 17:12:50.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"7bc489aa4d55ddd86af7a790eedc17c3a275ee07","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-18 17:12:52.000000000","message":"Patch Set 8:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"a2154d1693e1030922361453d313a565fff612fb","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-06-18 17:13:29.000000000","message":"Patch Set 8:\n\nLeaving as -2 until Keystone change is in as well so we can confirm the format and tracking IDs look correct.","accounts_in_message":[],"_revision_number":8},{"id":"eb99e1f4d8984ad740d011a8633b30c8aedd66b2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-18 18:17:05.000000000","message":"Patch Set 8: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-keystoneclient-pep8 http://logs.openstack.org/32/99432/8/check/gate-python-keystoneclient-pep8/76c6535 : FAILURE in 1m 05s\n- gate-python-keystoneclient-docs http://docs-draft.openstack.org/32/99432/8/check/gate-python-keystoneclient-docs/6cd5076/doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-keystoneclient-python26 http://logs.openstack.org/32/99432/8/check/gate-python-keystoneclient-python26/4130ec4 : SUCCESS in 52s\n- gate-python-keystoneclient-python27 http://logs.openstack.org/32/99432/8/check/gate-python-keystoneclient-python27/424f1e4 : SUCCESS in 1m 59s\n- check-tempest-dsvm-full http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-full/8c8deaf : SUCCESS in 45m 15s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-postgres-full/f237b67 : SUCCESS in 36m 03s\n- check-tempest-dsvm-neutron http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-neutron/2873458 : SUCCESS in 54m 59s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-neutron-heat-slow/1d63655 : SUCCESS in 21m 33s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/32/99432/8/check/check-grenade-dsvm/628bc6c : SUCCESS in 38m 24s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-full-havana/c3355b3 : SUCCESS in 32m 29s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-neutron-havana/afcaafa : SUCCESS in 34m 41s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-full-icehouse/65ae30b : SUCCESS in 45m 22s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-neutron-icehouse/3b3bc4d : SUCCESS in 54m 03s\n- gate-python-keystoneclient-python33 http://logs.openstack.org/32/99432/8/check/gate-python-keystoneclient-python33/89d2fec : SUCCESS in 5m 15s\n- check-devstack-dsvm-cells http://logs.openstack.org/32/99432/8/check/check-devstack-dsvm-cells/92cae1c : SUCCESS in 12m 48s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/32/99432/8/check/gate-tempest-dsvm-large-ops/2e6dabd : SUCCESS in 30m 48s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/32/99432/8/check/gate-tempest-dsvm-neutron-large-ops/d553c85 : SUCCESS in 28m 00s\n- check-tempest-dsvm-full-apache-services http://logs.openstack.org/32/99432/8/check/check-tempest-dsvm-full-apache-services/0540673 : SUCCESS in 42m 48s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"034788231bd9f4eb367f94f685113e3c7a024601","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2014-06-19 18:05:46.000000000","message":"Patch Set 8:\n\nI think this one is impacted by the non-persistent token proposal.\n\nhttps://review.openstack.org/#/c/95976/","accounts_in_message":[],"_revision_number":8},{"id":"9b77f7b4e77352764d6fed9371396a587976cc9a","author":{"_account_id":8180,"name":"Joel Friedly","email":"joelfriedly@gmail.com","username":"jfriedly"},"date":"2014-06-20 23:04:02.000000000","message":"Patch Set 8:\n\nThis patch will resolve https://bugs.launchpad.net/keystone/+bug/1287938.  (For more details, see my comment on the bug from earlier today.)","accounts_in_message":[],"_revision_number":8},{"id":"3f12a4b59b6ca2e29c8ca1a3a26ec2256b198c35","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2014-07-03 17:20:12.000000000","message":"Abandoned\n\nThis needs to be revisited, but there are issues involving the django auth module that need to be resolved first.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"a4bc0127f553f801d97832d437d3c1464ed8bab5","revisions":{"57959e6606c09b34d10e4ba345139e4d0e369f6a":{"kind":"REWORK","_number":1,"created":"2014-06-11 17:17:02.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/1"}}},"commit":{"parents":[{"commit":"832d89681cd1c2470375a10d87018be7bf8d0ed9","subject":"Add service_name to URL discovery","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/832d89681cd1c2470375a10d87018be7bf8d0ed9"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nIt is only very slightly less of a security issue to expose\nToken IDs in the logs than it is to expose password details. This\nchange obscures the Token ID in the debug output in all cases to\nensure that the ID is not presented in any of the logs that could\nbe read by a unpriviledged source (e.g. lower priv log watchers,\ncentralized logging, etc).\n\nThe raw data elements from the token (e.g. user, roles, expiration\netc) could be added into debug/trace level logging at a future time.\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/57959e6606c09b34d10e4ba345139e4d0e369f6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/57959e6606c09b34d10e4ba345139e4d0e369f6a"}]},"branch":"refs/heads/master"},"27178c8186d382a8b0d0784f6d4057433d54dbe4":{"kind":"REWORK","_number":2,"created":"2014-06-11 18:22:26.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/2"}}},"commit":{"parents":[{"commit":"832d89681cd1c2470375a10d87018be7bf8d0ed9","subject":"Add service_name to URL discovery","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/832d89681cd1c2470375a10d87018be7bf8d0ed9"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 18:21:49.000000000","tz":-420},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nIt is only very slightly less of a security issue to expose\nToken IDs in the logs than it is to expose password details. This\nchange obscures the Token ID in the debug output in all cases to\nensure that the ID is not presented in any of the logs that could\nbe read by a unpriviledged source (e.g. lower priv log watchers,\ncentralized logging, etc).\n\nThe raw data elements from the token (e.g. user, roles, expiration\netc) could be added into debug/trace level logging at a future time.\n\nSecurityImpact\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/27178c8186d382a8b0d0784f6d4057433d54dbe4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/27178c8186d382a8b0d0784f6d4057433d54dbe4"}]},"branch":"refs/heads/master"},"74b39df685229957c86c98c3d595bfebb95bcea5":{"kind":"REWORK","_number":3,"created":"2014-06-12 04:31:34.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/3"}}},"commit":{"parents":[{"commit":"832d89681cd1c2470375a10d87018be7bf8d0ed9","subject":"Add service_name to URL discovery","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/832d89681cd1c2470375a10d87018be7bf8d0ed9"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-12 04:25:38.000000000","tz":-420},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nIt is only very slightly less of a security issue to expose\nToken IDs in the logs than it is to expose password details. This\nchange obscures the Token ID in the debug output in all cases to\nensure that the ID is not presented in any of the logs that could\nbe read by a unpriviledged source (e.g. lower priv log watchers,\ncentralized logging, etc).\n\nThe raw data elements from the token (e.g. user, roles, expiration\netc) could be added into debug/trace level logging at a future time.\n\nSecurityImpact\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/74b39df685229957c86c98c3d595bfebb95bcea5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/74b39df685229957c86c98c3d595bfebb95bcea5"}]},"branch":"refs/heads/master"},"ae03f3311920f56163b30edd6ae0d89e8954ec8a":{"kind":"REWORK","_number":4,"created":"2014-06-12 05:01:55.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/4"}}},"commit":{"parents":[{"commit":"832d89681cd1c2470375a10d87018be7bf8d0ed9","subject":"Add service_name to URL discovery","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/832d89681cd1c2470375a10d87018be7bf8d0ed9"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-12 05:01:03.000000000","tz":-420},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nIt is only very slightly less of a security issue to expose\nToken IDs in the logs than it is to expose password details. This\nchange obscures the Token ID in the debug output in all cases to\nensure that the ID is not presented in any of the logs that could\nbe read by a unpriviledged source (e.g. lower priv log watchers,\ncentralized logging, etc).\n\nThe raw data elements from the token (e.g. user, roles, expiration\netc) could be added into debug/trace level logging at a future time.\n\nSecurityImpact\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ae03f3311920f56163b30edd6ae0d89e8954ec8a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/ae03f3311920f56163b30edd6ae0d89e8954ec8a"}]},"branch":"refs/heads/master"},"299c88048468615d0fecf5e21a3fc4f17f428215":{"kind":"REWORK","_number":5,"created":"2014-06-12 16:48:32.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/5"}}},"commit":{"parents":[{"commit":"832d89681cd1c2470375a10d87018be7bf8d0ed9","subject":"Add service_name to URL discovery","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/832d89681cd1c2470375a10d87018be7bf8d0ed9"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-12 16:45:47.000000000","tz":-420},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nIt is only very slightly less of a security issue to expose\nToken IDs in the logs than it is to expose password details. This\nchange obscures the Token ID in the debug output in all cases to\nensure that the ID is not presented in any of the logs that could\nbe read by a unpriviledged source (e.g. lower priv log watchers,\ncentralized logging, etc).\n\nSHA1 is no longer allowed as a hashing mode for CMS token hashing.\nThis is because SHA1 is being used to obscure tokens in the\nsession object debug. This is done to  prevent the debug output\nfrom being potentially exposing a valid token (PKI-\u003esha1-short-id)\nin some configurations of Keystone / auth_token middleware.\n\nThe raw data elements from the token (e.g. user, roles, expiration\netc) could be added into debug/trace level logging at a future time.\n\nSecurityImpact\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/299c88048468615d0fecf5e21a3fc4f17f428215"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/299c88048468615d0fecf5e21a3fc4f17f428215"}]},"branch":"refs/heads/master"},"6500d795d58e2c642677547329908ba816ef1463":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2014-06-13 21:40:19.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/6"}}},"commit":{"parents":[{"commit":"832d89681cd1c2470375a10d87018be7bf8d0ed9","subject":"Add service_name to URL discovery","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/832d89681cd1c2470375a10d87018be7bf8d0ed9"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"m@metacloud.com","date":"2014-06-13 21:40:19.000000000","tz":0},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nIt is only very slightly less of a security issue to expose\nToken IDs in the logs than it is to expose password details. This\nchange obscures the Token ID in the debug output in all cases to\nensure that the ID is not presented in any of the logs that could\nbe read by a unprivileged source (e.g. lower priv log watchers,\ncentralized logging, etc).\n\nThe main use case is to ensure that it is possible to correlate a\ntoken to the various requests made. In some cases this has shown\nwhere a token has expired (tokens weren\u0027t properly refreshed).\nThis use case for debugging eliminates simple redaction of the\ntoken id from the logs.\n\nSHA1 is no longer allowed as a hashing mode for CMS token hashing.\nThis is because SHA1 is being used to obscure tokens in the\nsession object debug. This is done to  prevent the debug output\nfrom being potentially exposing a valid token (PKI-\u003esha1-short-id)\nin some configurations of Keystone / auth_token middleware.\n\nThe raw data elements from the token (e.g. user, roles, expiration\netc) could be added into debug/trace level logging at a future time.\n\nSecurityImpact\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6500d795d58e2c642677547329908ba816ef1463"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6500d795d58e2c642677547329908ba816ef1463"}]},"branch":"refs/heads/master"},"6e1ae752de4984246466e47aa72c2b4471aa30f9":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2014-06-16 19:23:23.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/7"}}},"commit":{"parents":[{"commit":"f83115b4a6d17c0acc27e2635b3adaa9c3b39c16","subject":"Merge \"Session Documentation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f83115b4a6d17c0acc27e2635b3adaa9c3b39c16"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-11 17:13:32.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-16 19:23:23.000000000","tz":0},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nIt is only very slightly less of a security issue to expose\nToken IDs in the logs than it is to expose password details. This\nchange obscures the Token ID in the debug output in all cases to\nensure that the ID is not presented in any of the logs that could\nbe read by a unprivileged source (e.g. lower priv log watchers,\ncentralized logging, etc).\n\nThe main use case is to ensure that it is possible to correlate a\ntoken to the various requests made. In some cases this has shown\nwhere a token has expired (tokens weren\u0027t properly refreshed).\nThis use case for debugging eliminates simple redaction of the\ntoken id from the logs.\n\nSHA1 is no longer allowed as a hashing mode for CMS token hashing.\nThis is because SHA1 is being used to obscure tokens in the\nsession object debug. This is done to  prevent the debug output\nfrom being potentially exposing a valid token (PKI-\u003esha1-short-id)\nin some configurations of Keystone / auth_token middleware.\n\nThe raw data elements from the token (e.g. user, roles, expiration\netc) could be added into debug/trace level logging at a future time.\n\nSecurityImpact\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6e1ae752de4984246466e47aa72c2b4471aa30f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/6e1ae752de4984246466e47aa72c2b4471aa30f9"}]},"branch":"refs/heads/master"},"a4bc0127f553f801d97832d437d3c1464ed8bab5":{"kind":"REWORK","_number":8,"created":"2014-06-18 17:12:50.000000000","uploader":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"ref":"refs/changes/32/99432/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-keystoneclient","ref":"refs/changes/32/99432/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-keystoneclient refs/changes/32/99432/8"}}},"commit":{"parents":[{"commit":"f88a9c641d62f50f6cce0462c6a30b4b920da757","subject":"Merge \"Added help text for the debug option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/f88a9c641d62f50f6cce0462c6a30b4b920da757"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-18 17:05:58.000000000","tz":-420},"committer":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2014-06-18 17:05:58.000000000","tz":-420},"subject":"Do not expose Token IDs in debug output","message":"Do not expose Token IDs in debug output\n\nExposing the raw Token ID in the debug log is almost\nas bad as exposing the username/password as a valid\ntoken conveys authorization as long as the token is\nvalid.\n\nThis change obscures the token from the debug logging\nand if the token contains a unique tracking id in the\ntoken_data, it will add that into the log-line.\n\nThe unique token tracking id will allow for correlating\na specific token to any and all requests made with that\ntoken.\n\nSecurityImpact\n\nChange-Id: If5b196a734e7a0f0b3fa892d5c0436812a5bbd85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a4bc0127f553f801d97832d437d3c1464ed8bab5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-keystoneclient/commit/a4bc0127f553f801d97832d437d3c1464ed8bab5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}