)]}'
{"keystoneclient/auth/identity/base.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e5d223f251a0d2769126ebf74ceaaa29f7026002","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        :returns bool: True if there was something that the plugin did to"},{"line_number":108,"context_line":"                       invalidate. This means that it makes sense to try again."},{"line_number":109,"context_line":"                       If nothing happens returns False to indicate give up."},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        self.auth_ref \u003d None"},{"line_number":112,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ab869014","line":109,"updated":"2014-06-16 19:19:19.000000000","message":"Doesn\u0027t this always return True?","commit_id":"cf28f5777b76e439bcb464d19dbe8f22b2cf84d9"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5cc856499182a19f5f5450086aad62c1edb893b7","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        :returns bool: True if there was something that the plugin did to"},{"line_number":108,"context_line":"                       invalidate. This means that it makes sense to try again."},{"line_number":109,"context_line":"                       If nothing happens returns False to indicate give up."},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        self.auth_ref \u003d None"},{"line_number":112,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_dfee09ed","line":109,"in_reply_to":"1ae5cdf2_ab869014","updated":"2014-06-25 00:29:56.000000000","message":"This has been copied across from the base class. In this case it will always return true because the invalidate call does something for this type of plugin. \n\nI\u0027m not sure if this should be updated to reflect the implementation or should it be the same as the base class?","commit_id":"cf28f5777b76e439bcb464d19dbe8f22b2cf84d9"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"cc4868d9b39ef33036f58b43975adb9089eb661d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        return self.auth_ref"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def invalidate(self):"},{"line_number":100,"context_line":"        \"\"\"Invalidate the current authentication data."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        This should result in fetching a new token on next call."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9d3c84e3","line":99,"updated":"2014-06-25 06:47:07.000000000","message":"401 also includes authz error, in that case there is no point in invalidating. Keystoneclient reauth param also does the same thing which is not correct","commit_id":"871882c1e51a4c94c4c49535b472306f279bed58"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"d3208d52b94e8dd94d72c3ca519ffea7bafb5059","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        return self.auth_ref"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def invalidate(self):"},{"line_number":100,"context_line":"        \"\"\"Invalidate the current authentication data."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        This should result in fetching a new token on next call."}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7ebcf706","line":99,"in_reply_to":"1ae5cdf2_9d3c84e3","updated":"2014-06-25 18:02:01.000000000","message":"Ignore the comments, as it is not applicable here.","commit_id":"871882c1e51a4c94c4c49535b472306f279bed58"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"0d1cbdbbc0aabe30d7ed25719e7f6f26174efc2e","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :returns bool: True if there was something that the plugin did to"},{"line_number":109,"context_line":"                       invalidate. This means that it makes sense to try again."},{"line_number":110,"context_line":"                       If nothing happens returns False to indicate give up."},{"line_number":111,"context_line":"        \"\"\""},{"line_number":112,"context_line":"        self.auth_ref \u003d None"},{"line_number":113,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0d4f2535","line":110,"updated":"2014-07-11 23:35:53.000000000","message":"How can this return False?","commit_id":"871882c1e51a4c94c4c49535b472306f279bed58"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"55a62c8d9a10a396cefa2c52b51f309206aaeaee","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :returns bool: True if there was something that the plugin did to"},{"line_number":109,"context_line":"                       invalidate. This means that it makes sense to try again."},{"line_number":110,"context_line":"                       If nothing happens returns False to indicate give up."},{"line_number":111,"context_line":"        \"\"\""},{"line_number":112,"context_line":"        self.auth_ref \u003d None"},{"line_number":113,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cadfc138","line":110,"in_reply_to":"baada198_0d4f2535","updated":"2014-07-13 23:15:09.000000000","message":"In this case it wont, though it possibly should if there is already on auth_ref.\n\nThis was copied over from the class that it overrides, what we are saying is that in the case of an identity plugin if you get an unauthorized response then you can clear the current auth and try again.","commit_id":"871882c1e51a4c94c4c49535b472306f279bed58"}]}