)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"c0bfddf62de0da9f1e869b1ddc310108886e9687","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jamie Lennox \u003cjamielennox@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-13 15:33:03 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a fixture for keystone version discovery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As we push out the session and expect people to test with proper URL"},{"line_number":10,"context_line":"responses we should provide a means to create a correct keystone version"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_3ef5b382","line":7,"updated":"2014-06-13 05:49:53.000000000","message":"Keystone","commit_id":"b6b50dc88604c4de8df98c0563ca7bc03d2447d5"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"c0bfddf62de0da9f1e869b1ddc310108886e9687","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add a fixture for keystone version discovery"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As we push out the session and expect people to test with proper URL"},{"line_number":10,"context_line":"responses we should provide a means to create a correct keystone version"},{"line_number":11,"context_line":"list to test with."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8309ab6cbc47ad159f3c6e018b60ff8c15c6d917"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_9e2de700","line":10,"updated":"2014-06-13 05:49:53.000000000","message":"Keystone","commit_id":"b6b50dc88604c4de8df98c0563ca7bc03d2447d5"}],"keystoneclient/fixture/__init__.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"c565d0b37a7bb91865e04bda16256b5ce5952e41","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from keystoneclient.fixture.discovery import *  # noqa"},{"line_number":25,"context_line":"from keystoneclient.fixture.exception import *  # noqa"},{"line_number":26,"context_line":"from keystoneclient.fixture.v2 import Token as V2Token  # noqa"},{"line_number":27,"context_line":"from keystoneclient.fixture.v3 import Token as V3Token  # noqa"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_b82f1b3d","line":25,"updated":"2014-06-27 19:58:16.000000000","message":"why * on both?","commit_id":"513c6ecbd69894568ebb48caf780018c1682c82e"}],"keystoneclient/fixture/discovery.py":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"c0bfddf62de0da9f1e869b1ddc310108886e9687","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.id \u003d id"},{"line_number":26,"context_line":"        self.status \u003d status or \u0027stable\u0027"},{"line_number":27,"context_line":"        self.updated \u003d updated or (timeutils.utcnow() -"},{"line_number":28,"context_line":"                                   datetime.timedelta(days\u003d30))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @property"},{"line_number":31,"context_line":"    def id(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_feffcb63","line":28,"updated":"2014-06-13 05:49:53.000000000","message":"make \"30\" a constant instead of a magic number. Is this period of time configurable?","commit_id":"b6b50dc88604c4de8df98c0563ca7bc03d2447d5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4fb48a56ed56ef0ae51b0417828214c4c0bfe3e3","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    Provides some default values and helper methods for creating a v2.0"},{"line_number":106,"context_line":"    endpoint version structure. Clients should use this instead of creating"},{"line_number":107,"context_line":"    there own structures."},{"line_number":108,"context_line":"    \"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    _DESC_URL \u003d \u0027http://docs.openstack.org/api/openstack-identity-service/2.0/\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_132274b9","line":107,"updated":"2014-07-01 00:09:11.000000000","message":"change \"there\" to \"their\"","commit_id":"1d1c0581065a066a0f488b8d1478586096372945"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"d01eb323db5d4579eb6d9857c4eeceaed9475217","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param bool json: Add JSON media-type elements to the structure."},{"line_number":168,"context_line":"        :param bool xml: Add XML media-type elements to the structure."},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        super(V3Discovery, self).__init__(id or \u0027v3.0\u0027, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.add_link(href)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_cf583359","line":170,"updated":"2014-07-01 16:38:16.000000000","message":"Can you please clarify the reason \u0027v3.0\u0027 is used here, but \u0027v3\u0027 was used in line 236.","commit_id":"6ad31593ba6b888325e92988a33a37194fc1378d"},{"author":{"_account_id":11333,"name":"David J Hu","email":"david.hu@hpe.com","username":"dhu"},"change_message_id":"1064de24e0a4f6acb8cd104de02c1e2b246f4b13","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param bool json: Add JSON media-type elements to the structure."},{"line_number":168,"context_line":"        :param bool xml: Add XML media-type elements to the structure."},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        super(V3Discovery, self).__init__(id or \u0027v3.0\u0027, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.add_link(href)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_bc9b0271","line":170,"in_reply_to":"baada198_70961f96","updated":"2014-07-02 21:01:15.000000000","message":"Thanks Jamie and Brant for the clarification.  The inconsistency is that the v3 URL path is /v3, but the v2 URL path is /v2.0.  v3 URL does not have the *.0 in the path.","commit_id":"6ad31593ba6b888325e92988a33a37194fc1378d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ef6828569f0f25fe76f4752b762ecffe9e13cf75","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param bool json: Add JSON media-type elements to the structure."},{"line_number":168,"context_line":"        :param bool xml: Add XML media-type elements to the structure."},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        super(V3Discovery, self).__init__(id or \u0027v3.0\u0027, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.add_link(href)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_70961f96","line":170,"in_reply_to":"baada198_7be7e512","updated":"2014-07-01 19:04:13.000000000","message":"Jamie\u0027s right, keystone returns v3.0 in id for the /v3 version response.","commit_id":"6ad31593ba6b888325e92988a33a37194fc1378d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"da8fa1fb83d7ce165e812053602a129a63c16b6d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param bool json: Add JSON media-type elements to the structure."},{"line_number":168,"context_line":"        :param bool xml: Add XML media-type elements to the structure."},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        super(V3Discovery, self).__init__(id or \u0027v3.0\u0027, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.add_link(href)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_1bd98957","line":170,"in_reply_to":"baada198_cf583359","updated":"2014-07-01 18:13:23.000000000","message":"I agree with this comment. We always using v3 and not v3.0 for some reason.","commit_id":"6ad31593ba6b888325e92988a33a37194fc1378d"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"76894cdf4fcdb098742706421da32ab4e72df161","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param bool json: Add JSON media-type elements to the structure."},{"line_number":168,"context_line":"        :param bool xml: Add XML media-type elements to the structure."},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        super(V3Discovery, self).__init__(id or \u0027v3.0\u0027, **kwargs)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        self.add_link(href)"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_7be7e512","line":170,"in_reply_to":"baada198_cf583359","updated":"2014-07-01 18:15:33.000000000","message":"They end up in different places. This \u0027v3.0\u0027 is the version id that ends up in the body of the discovery list. The \u0027v3\u0027 below is in association with a URL and typically the v3 path is /v3","commit_id":"6ad31593ba6b888325e92988a33a37194fc1378d"}],"keystoneclient/tests/test_auth_token_middleware.py":[{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"c0bfddf62de0da9f1e869b1ddc310108886e9687","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                          \u0027expires\u0027: \u00272022-10-03T16:58:01Z\u0027}}})"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"VERSION_LIST_v2 \u003d jsonutils.dumps(fixture.DiscoveryList(href\u003dBASE_URI,"},{"line_number":67,"context_line":"                                                        v3\u003dFalse))"},{"line_number":68,"context_line":"VERSION_LIST_v3 \u003d jsonutils.dumps(fixture.DiscoveryList(href\u003dBASE_URI))"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_de33ef5f","line":66,"updated":"2014-06-13 05:49:53.000000000","message":"For consistency with other version prefixed variable names should this be named V2_VERSION_LIST?","commit_id":"b6b50dc88604c4de8df98c0563ca7bc03d2447d5"},{"author":{"_account_id":11045,"name":"Bob Thyne","email":"bob.thyne@hp.com","username":"bobt"},"change_message_id":"c0bfddf62de0da9f1e869b1ddc310108886e9687","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"VERSION_LIST_v2 \u003d jsonutils.dumps(fixture.DiscoveryList(href\u003dBASE_URI,"},{"line_number":67,"context_line":"                                                        v3\u003dFalse))"},{"line_number":68,"context_line":"VERSION_LIST_v3 \u003d jsonutils.dumps(fixture.DiscoveryList(href\u003dBASE_URI))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"ERROR_TOKEN \u003d \u00277ae290c2a06244c4b41692eb4e9225f2\u0027"},{"line_number":71,"context_line":"MEMCACHED_SERVERS \u003d [\u0027localhost:11211\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5e47dfbb","line":68,"updated":"2014-06-13 05:49:53.000000000","message":"Likewise should this be named V3_VERSION_LIST?","commit_id":"b6b50dc88604c4de8df98c0563ca7bc03d2447d5"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4fb48a56ed56ef0ae51b0417828214c4c0bfe3e3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \u0027expires\u0027: \u00272022-10-03T16:58:01Z\u0027}}})"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"VERSION_LIST_v2 \u003d jsonutils.dumps(fixture.DiscoveryList(href\u003dBASE_URI,"},{"line_number":68,"context_line":"                                                        v3\u003dFalse))"},{"line_number":69,"context_line":"VERSION_LIST_v3 \u003d jsonutils.dumps(fixture.DiscoveryList(href\u003dBASE_URI))"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7e529714","line":67,"updated":"2014-07-01 00:09:11.000000000","message":"we need this in keystonemiddleware too once a new version of keystoneclient is released.","commit_id":"1d1c0581065a066a0f488b8d1478586096372945"}],"keystoneclient/tests/test_discovery.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"4fb48a56ed56ef0ae51b0417828214c4c0bfe3e3","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"def _create_single_version(version):"},{"line_number":221,"context_line":"    return jsonutils.dumps({\u0027version\u0027: version})"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"V3_VERSION_LIST \u003d _create_version_list([V3_VERSION, V2_VERSION])"},{"line_number":224,"context_line":"V2_VERSION_LIST \u003d _create_version_list([V2_VERSION])"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_fe3dc7bc","line":222,"updated":"2014-07-01 00:09:11.000000000","message":"revert whitespace change on previous line.","commit_id":"1d1c0581065a066a0f488b8d1478586096372945"}]}