)]}'
{"magnumclient/v1/shell.py":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"90dc2c5bd87dab5405fd0ccd6fb190194de57319","unresolved":false,"context_lines":[{"line_number":195,"context_line":"@utils.arg(\u0027--pod-file\u0027,"},{"line_number":196,"context_line":"           metavar\u003d\u0027\u003cpod-file\u003e\u0027,"},{"line_number":197,"context_line":"           help\u003d\u0027File path of the pod file to use for creating PODs.\u0027)"},{"line_number":198,"context_line":"@utils.arg(\u0027--bay_id\u0027,"},{"line_number":199,"context_line":"           metavar\u003d\u0027\u003cbay_id\u003e\u0027,"},{"line_number":200,"context_line":"           help\u003d\u0027The bay ID.\u0027)"},{"line_number":201,"context_line":"def do_pod_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_91f51653","line":198,"updated":"2015-01-05 22:31:08.000000000","message":"Where do we indicate that this is required? Perhaps this should have a \"required\u003dTrue,\" argument here?","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8d13f9c8f8dc07b9cb22d05c3de00aa00e4e3f79","unresolved":false,"context_lines":[{"line_number":195,"context_line":"@utils.arg(\u0027--pod-file\u0027,"},{"line_number":196,"context_line":"           metavar\u003d\u0027\u003cpod-file\u003e\u0027,"},{"line_number":197,"context_line":"           help\u003d\u0027File path of the pod file to use for creating PODs.\u0027)"},{"line_number":198,"context_line":"@utils.arg(\u0027--bay_id\u0027,"},{"line_number":199,"context_line":"           metavar\u003d\u0027\u003cbay_id\u003e\u0027,"},{"line_number":200,"context_line":"           help\u003d\u0027The bay ID.\u0027)"},{"line_number":201,"context_line":"def do_pod_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_4325a5c0","line":198,"in_reply_to":"3a961159_91f51653","updated":"2015-01-05 22:58:49.000000000","message":"Agree this is mandatory - should be specified as such.","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"8c85c932c52053fcda6d75ef08b4a7c0c98d7172","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if args.pod_file is not None and os.path.isfile(args.pod_file):"},{"line_number":208,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":209,"context_line":"            opts[\u0027pod_data\u0027] \u003d f.read()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    node \u003d cs.pods.create(**opts)"},{"line_number":212,"context_line":"    _show_pod(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_a1bbb373","line":209,"updated":"2015-01-05 13:57:45.000000000","message":"1. Just one question, if pod-url, pod-file and bay-id supported.\n\nWhat\u0027s the priority for them ?\n\n2.also for  \u0027Name/URL of the pod file to use for creating PODs.\u0027,\npod-url  is url or file name ? I am confused.","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8d13f9c8f8dc07b9cb22d05c3de00aa00e4e3f79","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if args.pod_file is not None and os.path.isfile(args.pod_file):"},{"line_number":208,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":209,"context_line":"            opts[\u0027pod_data\u0027] \u003d f.read()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    node \u003d cs.pods.create(**opts)"},{"line_number":212,"context_line":"    _show_pod(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_c62603ba","line":209,"in_reply_to":"3a961159_235c197d","updated":"2015-01-05 22:58:49.000000000","message":"If we continue to use kubectl, we don\u0027t want to use -f file.yaml but rather always use the stdin redirect.  There is also a different way to to stdin redirect that may be preferrable.\n\nI\u0027m not convinced we need to support pass by reference, but if we do, we need to record the data at the reference as soon as we access it, so that if it disappears magnum doesn\u0027t get stuck during delete.","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"5551a4cbf2b2bd1bdb881aa85078c781887e46ed","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if args.pod_file is not None and os.path.isfile(args.pod_file):"},{"line_number":208,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":209,"context_line":"            opts[\u0027pod_data\u0027] \u003d f.read()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    node \u003d cs.pods.create(**opts)"},{"line_number":212,"context_line":"    _show_pod(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_235c197d","line":209,"in_reply_to":"3a961159_a1bbb373","updated":"2015-01-05 22:51:23.000000000","message":"1) Agree with Kai Qiang, as pod-url and pod-file are conflict, can we add some logic to handle this?\n\n2) Actually, pod-url can also be pofd-file, but as pod-file on magnum client might be on different host with k8s master, so magnum will separate those two cases for supporting pod_url and pod_file. This can be mapped to two kubectl command:\nExamples:\n  $ kubectl create -f pod.json\n  \u003ccreate a pod using the data in pod.json\u003e\n \n  $ cat pod.json | kubectl create -f -\n  \u003ccreate a pod based on the json passed into stdin\u003e","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"90dc2c5bd87dab5405fd0ccd6fb190194de57319","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if args.pod_file is not None and os.path.isfile(args.pod_file):"},{"line_number":208,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":209,"context_line":"            opts[\u0027pod_data\u0027] \u003d f.read()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    node \u003d cs.pods.create(**opts)"},{"line_number":212,"context_line":"    _show_pod(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_316d4233","line":209,"in_reply_to":"3a961159_a1bbb373","updated":"2015-01-05 22:31:08.000000000","message":"pod-definition-url (args.pod_url above) indicates to the controller where it will fetch the pod definition. This allows the client, and the controller to be on different hosts without passing (potentially large) file contents in an RPC message. It also provides a way for implementers to re-use pod definition files that are hosted as web resources.\n\nIf --pod-file is given, then --pod-url should not be used by the controller, as we are passing the data by value rather than by reference.","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"48f55321f96fe1fb3e782efa3fe8602bbc0fe560","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if args.pod_file is not None and os.path.isfile(args.pod_file):"},{"line_number":208,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":209,"context_line":"            opts[\u0027pod_data\u0027] \u003d f.read()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    node \u003d cs.pods.create(**opts)"},{"line_number":212,"context_line":"    _show_pod(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_f4047e7f","line":209,"in_reply_to":"3a961159_b12be893","updated":"2015-01-06 05:05:46.000000000","message":"I think that it is better print some output telling end user what is happening if both template or template-url are specified, we can handle this in coming patches.","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"fc725eddd794c8595ef0050595ee2728da78266a","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if args.pod_file is not None and os.path.isfile(args.pod_file):"},{"line_number":208,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":209,"context_line":"            opts[\u0027pod_data\u0027] \u003d f.read()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    node \u003d cs.pods.create(**opts)"},{"line_number":212,"context_line":"    _show_pod(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_b12be893","line":209,"in_reply_to":"3a961159_c62603ba","updated":"2015-01-06 04:32:11.000000000","message":"About pod-url/pod-file.\nFor example, heat-client support template or template-url parameter when we create stack, and template parameter is a priority. server decides which one is used.","commit_id":"8b4d0eb55ef6f17f8b6f5045737861ef21e36c69"}]}