)]}'
{"magnumclient/v1/shell.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"1f3d5693123cb67277db8e871a9ce6b2982e2337","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                     {\u0027versions\u0027: _print_list_field(\u0027versions\u0027)})"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"@utils.arg(\u0027--service-ufl\u0027,"},{"line_number":284,"context_line":"           metavar\u003d\u0027\u003cservice-ufl\u003e\u0027,"},{"line_number":285,"context_line":"           help\u003d\u0027Name/URL of the serivce file to use for creating services.\u0027)"},{"line_number":286,"context_line":"@utils.arg(\u0027--service-file\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_125b8f86","line":283,"updated":"2015-01-08 12:02:00.000000000","message":"I think this should be url but not ufl ;)","commit_id":"58c1783f4fbe8beed1e594726722bb0459937a30"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"412f2d215d0cefab3b1e8e59d31de536f1010c25","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                     {\u0027versions\u0027: _print_list_field(\u0027versions\u0027)})"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"@utils.arg(\u0027--service-ufl\u0027,"},{"line_number":284,"context_line":"           metavar\u003d\u0027\u003cservice-ufl\u003e\u0027,"},{"line_number":285,"context_line":"           help\u003d\u0027Name/URL of the serivce file to use for creating services.\u0027)"},{"line_number":286,"context_line":"@utils.arg(\u0027--service-file\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3beea7ed","line":283,"in_reply_to":"3a961159_125b8f86","updated":"2015-01-08 13:15:11.000000000","message":"thanks, I will fix it tomorrow ^_^;","commit_id":"58c1783f4fbe8beed1e594726722bb0459937a30"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"91ac0d811ab1ac1f89584a44ae64c2a0f3a8a550","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                     {\u0027versions\u0027: _print_list_field(\u0027versions\u0027)})"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"@utils.arg(\u0027--service-ufl\u0027,"},{"line_number":284,"context_line":"           metavar\u003d\u0027\u003cservice-ufl\u003e\u0027,"},{"line_number":285,"context_line":"           help\u003d\u0027Name/URL of the serivce file to use for creating services.\u0027)"},{"line_number":286,"context_line":"@utils.arg(\u0027--service-file\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_2412f4fc","line":283,"in_reply_to":"3a961159_3beea7ed","updated":"2015-01-09 02:04:12.000000000","message":"Done","commit_id":"58c1783f4fbe8beed1e594726722bb0459937a30"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"6d25518c0bc066988db98c4fce6af8311a129ecc","unresolved":false,"context_lines":[{"line_number":293,"context_line":"def do_service_create(cs, args):"},{"line_number":294,"context_line":"    \"\"\"Create a service.\"\"\""},{"line_number":295,"context_line":"    opts \u003d {}"},{"line_number":296,"context_line":"    opts[\u0027service_definition_url\u0027] \u003d args.service_file"},{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9e30699f","line":296,"updated":"2015-01-08 13:54:20.000000000","message":"I suspect it was wrong for the args.\nutils.arg has service-file, while here it is args.service_file. (also url )\nPlease double check related setting.\n\nI have found many name def styles. sometime with \"_\", sometimes with \"-\", Which I think not good.","commit_id":"58c1783f4fbe8beed1e594726722bb0459937a30"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"91ac0d811ab1ac1f89584a44ae64c2a0f3a8a550","unresolved":false,"context_lines":[{"line_number":293,"context_line":"def do_service_create(cs, args):"},{"line_number":294,"context_line":"    \"\"\"Create a service.\"\"\""},{"line_number":295,"context_line":"    opts \u003d {}"},{"line_number":296,"context_line":"    opts[\u0027service_definition_url\u0027] \u003d args.service_file"},{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_44d4601f","line":296,"in_reply_to":"3a961159_6c1877cd","updated":"2015-01-09 02:04:12.000000000","message":"Done","commit_id":"58c1783f4fbe8beed1e594726722bb0459937a30"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"31069e27b6403e16423aa1745cbc509486b9248e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"def do_service_create(cs, args):"},{"line_number":294,"context_line":"    \"\"\"Create a service.\"\"\""},{"line_number":295,"context_line":"    opts \u003d {}"},{"line_number":296,"context_line":"    opts[\u0027service_definition_url\u0027] \u003d args.service_file"},{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6c1877cd","line":296,"in_reply_to":"3a961159_9e30699f","updated":"2015-01-08 15:05:34.000000000","message":"I agree.  We really should make a commitment as to what the arguments are to be (- or _).  OpenStack in general uses - (for example, nova keypair-add --pub-key ~/.ssh/id_rsa.pub).  This means fixing this issue in alot of the client.  Can someone tackle that before milestone #1?\n\nDeadline is the 13th!\n\nhttps://bugs.launchpad.net/python-magnumclient/+bug/1408667","commit_id":"58c1783f4fbe8beed1e594726722bb0459937a30"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"bc0052d31d52ed0a2ee7f271da2c7f77dbb820e5","unresolved":false,"context_lines":[{"line_number":293,"context_line":"def do_service_create(cs, args):"},{"line_number":294,"context_line":"    \"\"\"Create a service.\"\"\""},{"line_number":295,"context_line":"    opts \u003d {}"},{"line_number":296,"context_line":"    opts[\u0027service_definition_url\u0027] \u003d args.service_file"},{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_64679c25","line":296,"updated":"2015-01-09 02:48:13.000000000","message":"My question still as before\u003c\n\nfor arg it is ,service-file, could you access with this args.service_file ?\n\nCould you confirm that work ?","commit_id":"811232d3ece0a425098cc0776ad62e54ca54ac78"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"210f67ba027f15cd41425f0730f446821ba3e2e1","unresolved":false,"context_lines":[{"line_number":293,"context_line":"def do_service_create(cs, args):"},{"line_number":294,"context_line":"    \"\"\"Create a service.\"\"\""},{"line_number":295,"context_line":"    opts \u003d {}"},{"line_number":296,"context_line":"    opts[\u0027service_definition_url\u0027] \u003d args.service_file"},{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_ca0e9631","line":296,"in_reply_to":"3a961159_64679c25","updated":"2015-01-09 08:14:47.000000000","message":"It worked, I try it.","commit_id":"811232d3ece0a425098cc0776ad62e54ca54ac78"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"bc0052d31d52ed0a2ee7f271da2c7f77dbb820e5","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    opts[\u0027service_definition_url\u0027] \u003d args.service_file"},{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"},{"line_number":300,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":301,"context_line":"            opts[\u0027service_data\u0027] \u003d f.read()"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_247914c5","line":299,"updated":"2015-01-09 02:48:13.000000000","message":"seems if args.service_file  is enough, is it necessary with is not None here ?","commit_id":"811232d3ece0a425098cc0776ad62e54ca54ac78"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"210f67ba027f15cd41425f0730f446821ba3e2e1","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    opts[\u0027service_definition_url\u0027] \u003d args.service_file"},{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"},{"line_number":300,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":301,"context_line":"            opts[\u0027service_data\u0027] \u003d f.read()"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_ea19927a","line":299,"in_reply_to":"3a961159_247914c5","updated":"2015-01-09 08:14:47.000000000","message":"os.path.isfile raise exception when None is received.","commit_id":"811232d3ece0a425098cc0776ad62e54ca54ac78"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"bc0052d31d52ed0a2ee7f271da2c7f77dbb820e5","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"},{"line_number":300,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":301,"context_line":"            opts[\u0027service_data\u0027] \u003d f.read()"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    service \u003d cs.services.create(**opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e472ace1","line":300,"updated":"2015-01-09 02:48:13.000000000","message":"why args.pod_file here ? is it service_file ?","commit_id":"811232d3ece0a425098cc0776ad62e54ca54ac78"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"210f67ba027f15cd41425f0730f446821ba3e2e1","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    opts[\u0027bay_uuid\u0027] \u003d args.bay_id"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if args.service_file is not None and os.path.isfile(args.service_file):"},{"line_number":300,"context_line":"        with open(args.pod_file, \u0027r\u0027) as f:"},{"line_number":301,"context_line":"            opts[\u0027service_data\u0027] \u003d f.read()"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    service \u003d cs.services.create(**opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_2a271ab7","line":300,"in_reply_to":"3a961159_e472ace1","updated":"2015-01-09 08:14:47.000000000","message":"Thanks, I fix it.","commit_id":"811232d3ece0a425098cc0776ad62e54ca54ac78"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"11e9030d8dd4d50a665e9e42e759f10bbeeec043","unresolved":false,"context_lines":[{"line_number":288,"context_line":"           help\u003d\u0027File path of the service file to use for creating services.\u0027)"},{"line_number":289,"context_line":"@utils.arg(\u0027--bay-id\u0027,"},{"line_number":290,"context_line":"           required\u003dTrue,"},{"line_number":291,"context_line":"           metavar\u003d\u0027\u003cbay_id\u003e\u0027,"},{"line_number":292,"context_line":"           help\u003d\u0027The bay ID.\u0027)"},{"line_number":293,"context_line":"def do_service_create(cs, args):"},{"line_number":294,"context_line":"    \"\"\"Create a service.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_ec51ab31","line":291,"updated":"2015-01-09 14:04:54.000000000","message":"https://docs.python.org/dev/library/argparse.html#metavar\n\nideally we would be consistent with metavar as well ;-)  But I guess we can adjust that later.  It isn\u0027t critical like the actual argument name was, that was repaired.","commit_id":"b0bbeb3d99c03a07135c590226f8b0e4f268ad48"}]}