)]}'
{"magnumclient/v1/client.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"320f2190c2c2d45d146d75bc9cd25ee506636a55","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                auth_url\u003dauth_url,"},{"line_number":101,"context_line":"                endpoint\u003dauth_url)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.keystone_client.authenticate()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        return self.keystone_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_5399491e","side":"PARENT","line":103,"updated":"2015-04-09 00:20:00.000000000","message":"One question, why not change the indent of above line to the scope of \"if not getattr(self, \"keystone_client\", None):\"? This can also make sure we only authenticate once, comments?","commit_id":"7b45bac0164a87cf1c560ec08f225f997362f774"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"44296dc6eb637a1c9d48257a8e8c6203ff8e2d93","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                auth_url\u003dauth_url,"},{"line_number":101,"context_line":"                endpoint\u003dauth_url)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.keystone_client.authenticate()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        return self.keystone_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_7be41ae0","side":"PARENT","line":103,"in_reply_to":"9aa53dc9_5399491e","updated":"2015-04-09 08:39:43.000000000","message":"@jay: indeed, we would get the same result with a smaller change footprint. BUT proposed approach allows to simplify get_keystone_client implementation by removing overkill caching (it also garbages keystone client earlier).","commit_id":"7b45bac0164a87cf1c560ec08f225f997362f774"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"f6e82d3ca73504d40e367839fad8fcabe5c0ce03","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                auth_url\u003dauth_url,"},{"line_number":101,"context_line":"                endpoint\u003dauth_url)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.keystone_client.authenticate()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        return self.keystone_client"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_601a027f","side":"PARENT","line":103,"in_reply_to":"9aa53dc9_7be41ae0","updated":"2015-04-10 04:53:11.000000000","message":"I see, then you can follow Adrian\u0027s comments to split this to several patches ;-)","commit_id":"7b45bac0164a87cf1c560ec08f225f997362f774"}]}