)]}'
{"id":"openstack%2Fpython-magnumclient~171655","triplet_id":"openstack%2Fpython-magnumclient~master~I9877e1be5d2e531442774ee4627bdfe1745781d7","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1442457","hashtags":[],"change_id":"I9877e1be5d2e531442774ee4627bdfe1745781d7","subject":"Authenticate once","status":"MERGED","created":"2015-04-08 13:55:45.000000000","updated":"2015-04-15 10:36:37.000000000","submitted":"2015-04-15 10:36:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"162637d591bdf36c51ab856469a1a2db4bb70885","_number":171655,"virtual_id_number":171655,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-04-15 10:36:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":2,"date":"2015-04-15 10:34:28.000000000","_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":2,"date":"2015-04-15 10:31:41.000000000","_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":1,"date":"2015-04-15 10:34:28.000000000","_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-09 00:16:00.000000000","updated_by":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"reviewer":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"state":"REVIEWER"},{"updated":"2015-04-09 00:20:00.000000000","updated_by":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"reviewer":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"state":"REVIEWER"},{"updated":"2015-04-15 10:31:41.000000000","updated_by":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"reviewer":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"state":"REVIEWER"},{"updated":"2015-04-15 10:34:28.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2015-04-15 10:36:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1d488d55123ae1af87a780b3ecb3e52bbf55321a","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-08 13:55:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7d687d56c1af74665d0f62f48c0b592e0c43275b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-08 14:21:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/55/171655/1/check/gate-python-magnumclient-pep8/6c97170/ : SUCCESS in 41s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/55/171655/1/check/gate-python-magnumclient-docs/f8abb22//doc/build/html/ : SUCCESS in 43s\n- gate-python-magnumclient-python27 http://logs.openstack.org/55/171655/1/check/gate-python-magnumclient-python27/4739b21/ : FAILURE in 43s","accounts_in_message":[],"_revision_number":1},{"id":"743f7f90b97fd10272b96c7b966b019fc6437022","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-08 14:42:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ec2a792a76ecefdef32189cc177a7d6ff269e077","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-08 14:58:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/55/171655/2/check/gate-python-magnumclient-pep8/aba39c5/ : SUCCESS in 54s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/55/171655/2/check/gate-python-magnumclient-docs/f20275f//doc/build/html/ : SUCCESS in 44s\n- gate-python-magnumclient-python27 http://logs.openstack.org/55/171655/2/check/gate-python-magnumclient-python27/d5190b3/ : SUCCESS in 53s","accounts_in_message":[],"_revision_number":2},{"id":"b04216dcb4a4a0befa2c59a27bd57d910358077f","author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"date":"2015-04-09 00:16:00.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"320f2190c2c2d45d146d75bc9cd25ee506636a55","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2015-04-09 00:20:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"44296dc6eb637a1c9d48257a8e8c6203ff8e2d93","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-09 08:39:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9339ba98c2f61fb3c9b92f6a650b1a609d7d3f57","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-04-10 03:37:06.000000000","message":"Patch Set 2: Code-Review-1\n\nOkay, good work, but this should be three patches:\n\n1) Fix for double authentication. Last line of the commit message should be: \n\nCloses-bug: #1442457\n\nHere is the full link for your reference: \nhttps://bugs.launchpad.net/magnum/+bug/1442457\n\n2) Add a unit test for the client class \n\n3) Add unittest for the Client class and simplify\nget_keystone_client (remove a side effect) as the method is called at most once by magnumclient.\n\nThe number 2 and 3 patches should have bugs opened like the first. You can put in the bugs at:\n\nhttps://bugs.launchpad.net/magnum\n\nThey do not have to be approved to merge code with them linked in the commit message. The purpose of this is so that I can rack and credit us with all fixes and enhancements.\n\nThanks!","accounts_in_message":[],"_revision_number":2},{"id":"f6e82d3ca73504d40e367839fad8fcabe5c0ce03","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2015-04-10 04:53:11.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fd09c747157dbf0f08d7d2c3f6772baaedf967a6","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-04-14 17:44:57.000000000","message":"Patch Set 2:\n\nCedric, just a gentle nudge. See remarks above. I would love to split this up and merge it in. Let us know if you need a hand with it, or if you\u0027ll get to it soon.","accounts_in_message":[],"_revision_number":2},{"id":"f45241aad6c41ed0d5eb6e6db8f902328a2077a0","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-15 10:09:38.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c0f678b0018073b13e9af545be13fbfb2d80a7b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-15 10:23:11.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/55/171655/3/check/gate-python-magnumclient-pep8/42f0f4c/ : SUCCESS in 1m 22s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/55/171655/3/check/gate-python-magnumclient-docs/f7ce8e2//doc/build/html/ : SUCCESS in 1m 27s\n- gate-python-magnumclient-python27 http://logs.openstack.org/55/171655/3/check/gate-python-magnumclient-python27/c05c5a4/ : SUCCESS in 56s","accounts_in_message":[],"_revision_number":3},{"id":"f1f9e826bf9bf880c2fc062e278fba31abbe0198","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-04-15 10:31:41.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f24bc0b6294ee780a580ecd69e791f3b51210a20","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2015-04-15 10:34:28.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"173a7cf745635302110ec3f06eef70f8bcfd9914","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-15 10:34:33.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"7d0580c98fcfe6691ec4f6d72bc4ebfe91def69c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-15 10:36:35.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/55/171655/3/gate/gate-python-magnumclient-docs/a092af0//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/55/171655/3/gate/gate-python-magnumclient-pep8/235f71b/ : SUCCESS in 45s\n- gate-python-magnumclient-python27 http://logs.openstack.org/55/171655/3/gate/gate-python-magnumclient-python27/d9bc0d4/ : SUCCESS in 52s","accounts_in_message":[],"_revision_number":3},{"id":"d65abba723dd2df35c06a165e876f4fb0d609014","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-15 10:36:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"b760183f2159e1e76a9e948b765b49ead9635dc4","revisions":{"697f80a20f0e7163f988ce3f425643826be97ee6":{"kind":"REWORK","_number":1,"created":"2015-04-08 13:55:45.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/55/171655/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/171655/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/1"}}},"commit":{"parents":[{"commit":"7b45bac0164a87cf1c560ec08f225f997362f774","subject":"Remove unused get_projects_list method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7b45bac0164a87cf1c560ec08f225f997362f774"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-08 13:33:05.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-08 13:53:32.000000000","tz":120},"subject":"Authenticate once","message":"Authenticate once\n\nMagnumclient authenticates twice when no token and no magnum url are\nprovided by the user. This change avoids the 2nd authentication.\nThis change also adds unittest for the Client class and simplifies\nget_keystone_client (remove a side effect) as the method is called at\nmost once by magnumclient.\n\nChange-Id: I9877e1be5d2e531442774ee4627bdfe1745781d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/697f80a20f0e7163f988ce3f425643826be97ee6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/697f80a20f0e7163f988ce3f425643826be97ee6"}]},"branch":"refs/heads/master"},"c70b7c4d9ceac556f808cba0386629d98f2ffe64":{"kind":"REWORK","_number":2,"created":"2015-04-08 14:42:34.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/55/171655/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/171655/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/2"}}},"commit":{"parents":[{"commit":"7b45bac0164a87cf1c560ec08f225f997362f774","subject":"Remove unused get_projects_list method","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7b45bac0164a87cf1c560ec08f225f997362f774"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-08 13:33:05.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-08 14:42:15.000000000","tz":120},"subject":"Authenticate once","message":"Authenticate once\n\nMagnumclient authenticates twice when no token and no magnum url are\nprovided by the user. This change avoids the 2nd authentication.\nThis change also adds unittest for the Client class and simplifies\nget_keystone_client (remove a side effect) as the method is called at\nmost once by magnumclient.\n\nChange-Id: I9877e1be5d2e531442774ee4627bdfe1745781d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c70b7c4d9ceac556f808cba0386629d98f2ffe64"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c70b7c4d9ceac556f808cba0386629d98f2ffe64"}]},"branch":"refs/heads/master"},"b760183f2159e1e76a9e948b765b49ead9635dc4":{"kind":"REWORK","_number":3,"created":"2015-04-15 10:09:38.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/55/171655/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/171655/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/171655/3"}}},"commit":{"parents":[{"commit":"59729557b9232efa1ff69c8b5ffe674fa23ee4b6","subject":"Update bandit for latest usage","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/59729557b9232efa1ff69c8b5ffe674fa23ee4b6"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 09:58:06.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 09:58:06.000000000","tz":120},"subject":"Authenticate once","message":"Authenticate once\n\nMagnumclient authenticates twice when no token and no magnum url are\nprovided by the user. This change avoids the 2nd authentication.\n\nCloses-Bug: #1442457\nChange-Id: I9877e1be5d2e531442774ee4627bdfe1745781d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b760183f2159e1e76a9e948b765b49ead9635dc4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b760183f2159e1e76a9e948b765b49ead9635dc4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
