)]}'
{"id":"openstack%2Fpython-magnumclient~173764","triplet_id":"openstack%2Fpython-magnumclient~master~I832f4ef90fd9ec32ebf4d97675379b73620b0646","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1442457","hashtags":[],"change_id":"I832f4ef90fd9ec32ebf4d97675379b73620b0646","subject":"Remove side effect in get_keystoneclient","status":"MERGED","created":"2015-04-15 10:39:07.000000000","updated":"2015-04-19 00:13:40.000000000","submitted":"2015-04-19 00:13:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"441ad531dd8fde8c9f600edd22247f5f628993c0","_number":173764,"virtual_id_number":173764,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},{"value":2,"date":"2015-04-19 00:13:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"all":[{"value":2,"date":"2015-04-17 08:49:04.000000000","_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":2,"date":"2015-04-18 04:43:49.000000000","_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":1,"date":"2015-04-18 08:29:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},{"value":1,"date":"2015-04-17 08:49:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"all":[{"value":0,"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":1,"date":"2015-04-18 04:43:49.000000000","_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-16 02:12:20.000000000","updated_by":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"reviewer":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"state":"REVIEWER"},{"updated":"2015-04-17 00:48:06.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2015-04-17 06:09:20.000000000","updated_by":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"reviewer":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"state":"REVIEWER"},{"updated":"2015-04-18 04:43:49.000000000","updated_by":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"reviewer":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"state":"REVIEWER"},{"updated":"2015-04-18 08:29:46.000000000","updated_by":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"reviewer":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"state":"REVIEWER"},{"updated":"2015-04-19 00:13:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3cbce924108849764964f510dff7c29f88a610eb","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-15 10:39:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"813b64abab61591fcb1037e49c885e8a53a339f5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-15 11:06:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/64/173764/1/check/gate-python-magnumclient-pep8/9459fb9/ : SUCCESS in 48s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/64/173764/1/check/gate-python-magnumclient-docs/307fe03//doc/build/html/ : SUCCESS in 43s\n- gate-python-magnumclient-python27 http://logs.openstack.org/64/173764/1/check/gate-python-magnumclient-python27/023f2e4/ : SUCCESS in 56s","accounts_in_message":[],"_revision_number":1},{"id":"5f304196695adbf6c1f344d47479e322f81845b1","author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"date":"2015-04-16 02:12:20.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027d like to have unit for that change. Thanks","accounts_in_message":[],"_revision_number":1},{"id":"b1e9b837a8ee0034695613e757e98e744885bd6b","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2015-04-16 09:48:34.000000000","message":"Patch Set 1: Code-Review-1\n\nPlease add test case for this change.","accounts_in_message":[],"_revision_number":1},{"id":"8cd73fa5e48f2c1fe12d18683d87078d96c55701","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-16 20:26:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f9c1ef47d1d19f8f336a4fb98181a4355e41f1e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-16 21:10:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/64/173764/2/check/gate-python-magnumclient-pep8/2f577b2/ : SUCCESS in 40s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/64/173764/2/check/gate-python-magnumclient-docs/e9199b1//doc/build/html/ : SUCCESS in 39s\n- gate-python-magnumclient-python27 http://logs.openstack.org/64/173764/2/check/gate-python-magnumclient-python27/2714ce7/ : SUCCESS in 57s","accounts_in_message":[],"_revision_number":2},{"id":"d6827a6c2f7799faa61a862962d60dd3f35daf06","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2015-04-17 00:46:36.000000000","message":"Patch Set 2: Code-Review-1\n\nCedric,\nCan you add one more test like test_get_keystoneclient_no_auth_url for better coverage?\n\nConsider it as soft -1.\nThanks!","accounts_in_message":[],"_revision_number":2},{"id":"54b272b9d5b029d4100771a6ac6f7ca726ca7f9d","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2015-04-17 00:48:06.000000000","message":"Patch Set 2: Code-Review+1\n\nSeem you need to add test in base patch.","accounts_in_message":[],"_revision_number":2},{"id":"cbc7f3ecdc0b8c7eedcd5dce1f16d38835a5a681","author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"date":"2015-04-17 06:09:20.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"14f4c5748e56ffb05e7c9378ac6ba43b899d2891","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2015-04-17 08:49:04.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"8058536424af7c2411bf988d2b534d9ff900be57","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-17 09:04:00.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/64/173764/3/check/gate-python-magnumclient-pep8/d7500a3/ : SUCCESS in 34s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/64/173764/3/check/gate-python-magnumclient-docs/b2e25af//doc/build/html/ : SUCCESS in 37s\n- gate-python-magnumclient-python27 http://logs.openstack.org/64/173764/3/check/gate-python-magnumclient-python27/ee60588/ : SUCCESS in 1m 41s","accounts_in_message":[],"_revision_number":3},{"id":"b11f0211e9341c67a34e23d4f3593c37aceb2b2e","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-04-18 04:43:49.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"4f7ab11e6dd3ff66b9651b8e18385f349ae3c663","author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"date":"2015-04-18 08:29:46.000000000","message":"Patch Set 3: Code-Review+1\n\nCedric, LGTM, thanks!","accounts_in_message":[],"_revision_number":3},{"id":"e389cca98eb7462b20e86c7224bccb7bca248825","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-19 00:08:57.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"2eb29ee34e08c4edbe1a750982d8b5f8f84326c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-19 00:13:38.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/64/173764/3/gate/gate-python-magnumclient-docs/313c168//doc/build/html/ : SUCCESS in 34s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/64/173764/3/gate/gate-python-magnumclient-pep8/3563ecf/ : SUCCESS in 41s\n- gate-python-magnumclient-python27 http://logs.openstack.org/64/173764/3/gate/gate-python-magnumclient-python27/000e444/ : SUCCESS in 46s","accounts_in_message":[],"_revision_number":3},{"id":"abbef01c2f6aa85cf6b12e65ca69d7b127f8f159","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-19 00:13:40.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"431554b43ebc59183f9eb3efaed32d8f56686c6b","revisions":{"63dc543f0caa95cd9c44ceaf3c635278c5b01523":{"kind":"REWORK","_number":1,"created":"2015-04-15 10:39:07.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/64/173764/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/64/173764/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/1"}}},"commit":{"parents":[{"commit":"d9ba11dd6820ee25a241a14070f42bbaa2773938","subject":"Add unittests for magnumclient.v1.client module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/d9ba11dd6820ee25a241a14070f42bbaa2773938"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-08 13:33:05.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-15 10:38:29.000000000","tz":120},"subject":"Remove side effect in get_keystoneclient","message":"Remove side effect in get_keystoneclient\n\nCurrently get_keystoneclient uses a side effect (keystone_client\nattribute) to cache keystone client instance but it\u0027s not more required\nas get_keystoneclient is called at most once, thanks to parent changes.\n\nCloses-Bug: #1444405\nChange-Id: I832f4ef90fd9ec32ebf4d97675379b73620b0646\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/63dc543f0caa95cd9c44ceaf3c635278c5b01523"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/63dc543f0caa95cd9c44ceaf3c635278c5b01523"}]},"branch":"refs/heads/master"},"5a2b6b9ec6c04dfae9b2335736a47221355c2cca":{"kind":"REWORK","_number":2,"created":"2015-04-16 20:26:53.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/64/173764/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/64/173764/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/2"}}},"commit":{"parents":[{"commit":"6cacf5b5d042c10f623c2de04058932d3a3d6576","subject":"Add unittests for magnumclient.v1.client module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/6cacf5b5d042c10f623c2de04058932d3a3d6576"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-08 13:33:05.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-16 20:25:05.000000000","tz":120},"subject":"Remove side effect in get_keystoneclient","message":"Remove side effect in get_keystoneclient\n\nCurrently get_keystoneclient uses a side effect (keystone_client\nattribute) to cache keystone client instance but it\u0027s not more required\nas get_keystoneclient is called at most once, thanks to parent changes.\n\nCloses-Bug: #1444405\nChange-Id: I832f4ef90fd9ec32ebf4d97675379b73620b0646\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5a2b6b9ec6c04dfae9b2335736a47221355c2cca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5a2b6b9ec6c04dfae9b2335736a47221355c2cca"}]},"branch":"refs/heads/master"},"431554b43ebc59183f9eb3efaed32d8f56686c6b":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2015-04-17 08:49:04.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/64/173764/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/64/173764/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/64/173764/3"}}},"commit":{"parents":[{"commit":"115d17320e9fcd3eab4e60f222f382a7d551948b","subject":"Add unittests for magnumclient.v1.client module","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/115d17320e9fcd3eab4e60f222f382a7d551948b"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-08 13:33:05.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2015-04-17 08:49:04.000000000","tz":0},"subject":"Remove side effect in get_keystoneclient","message":"Remove side effect in get_keystoneclient\n\nCurrently get_keystoneclient uses a side effect (keystone_client\nattribute) to cache keystone client instance but it\u0027s not more required\nas get_keystoneclient is called at most once, thanks to parent changes.\n\nCloses-Bug: #1444405\nChange-Id: I832f4ef90fd9ec32ebf4d97675379b73620b0646\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/431554b43ebc59183f9eb3efaed32d8f56686c6b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/431554b43ebc59183f9eb3efaed32d8f56686c6b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
