)]}'
{"id":"openstack%2Fpython-magnumclient~173883","triplet_id":"openstack%2Fpython-magnumclient~master~Ie268ea8445e9b10e4466fefea2a8ea9c44cb91f3","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1444383","hashtags":[],"change_id":"Ie268ea8445e9b10e4466fefea2a8ea9c44cb91f3","subject":"Support update a replication controller","status":"MERGED","created":"2015-04-15 13:47:26.000000000","updated":"2015-04-17 06:04:08.000000000","submitted":"2015-04-17 06:04:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a53c9e1dbd81b55336cfe29fdb95f2823b2fafce","_number":173883,"virtual_id_number":173883,"owner":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-04-17 06:04:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-04-16 18:41:26.000000000","_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":2,"date":"2015-04-16 17:54:47.000000000","_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-04-16 18:41:26.000000000","_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-16 02:11:19.000000000","updated_by":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"reviewer":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"state":"REVIEWER"},{"updated":"2015-04-16 09:47:44.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2015-04-16 17:54:47.000000000","updated_by":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"reviewer":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"state":"REVIEWER"},{"updated":"2015-04-16 18:41:26.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2015-04-17 06:04:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7231b15955737b7f058e4ff3fe4faf882ad2d1f5","author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"date":"2015-04-15 13:47:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"51019119a4616c799f1b8285b291ca2c3cee5080","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-15 17:14:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/83/173883/1/check/gate-python-magnumclient-pep8/bcab98c/ : SUCCESS in 41s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/83/173883/1/check/gate-python-magnumclient-docs/9ac219c//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-magnumclient-python27 http://logs.openstack.org/83/173883/1/check/gate-python-magnumclient-python27/8ebdf6a/ : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":1},{"id":"cdbb116ab12b967b087cc152f6060e4684696159","author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"date":"2015-04-16 02:11:19.000000000","message":"Patch Set 1: Code-Review-1\n\n1. I\u0027d like to get the usage senario for update the such service.\nCould you give some backgroud or link in kubernetes examples ?\n2. Does you update here just happen in magnum side or include happend in kubernetes ?","accounts_in_message":[],"_revision_number":1},{"id":"ac55d551b250cd5183f4fbf51480ac93857bea84","author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"date":"2015-04-16 02:28:49.000000000","message":"Patch Set 1:\n\n@Kai Qiang, thanks for your review.\n\n1. In kubernetes, we can use \"kubectl update -f rc.json\" to update the label, replica counts or something else of a replication controller.\n\n2. The update can be happened in both magnum side and kubernetes side(if you pass the manifest file)","accounts_in_message":[],"_revision_number":1},{"id":"90c3bce60b00dbc2f557413d2c291db73521c425","author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"date":"2015-04-16 02:29:07.000000000","message":"Patch Set 1:\n\n@Kai Qiang, thanks for your review.\n\n1. In kubernetes, we can use \"kubectl update -f rc.json\" to update the label, something else of a service.\n\n2. The update can be happened in both magnum side and kubernetes side(if you pass the manifest file)","accounts_in_message":[],"_revision_number":1},{"id":"123672eea92fc2684e4c71ca19672cd115de238a","author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"date":"2015-04-16 03:20:47.000000000","message":"Patch Set 1:\n\nCheck my comment for service comment.\n\nPls make sure well tested it, and hope you can give your test appened here as comments. \n\nIt can help other reviers make understand it is works.and they can try that or test that.","accounts_in_message":[],"_revision_number":1},{"id":"96dc31ca6d04ef4f902d131962dc450d8d71cf13","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2015-04-16 09:47:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nHi Lan,\n\nPlease see my comments inline and also. 1.Please add more test cases in v1/test_shell.py. 2.Update your commit message to show it depends on below patch. \nhttps://review.openstack.org/#/c/174209/","accounts_in_message":[],"_revision_number":1},{"id":"19a8420eafc90d9d119b6d5341c802aa6c74adea","author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"date":"2015-04-16 16:26:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"223e03f8795dc11bdaaa47487269bc3f8db0adea","author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"date":"2015-04-16 16:27:18.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"c4e9d15f251009066fa069ef3d936087afdd2e64","author":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"date":"2015-04-16 16:28:13.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nThanks Madhuri, address your comment.","accounts_in_message":[],"_revision_number":1},{"id":"cc8bb5aa02a23714d0a4c757b42cb35f2fa43d97","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-16 16:48:07.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/83/173883/3/check/gate-python-magnumclient-pep8/e80df58/ : SUCCESS in 47s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/83/173883/3/check/gate-python-magnumclient-docs/11ffa3b//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-magnumclient-python27 http://logs.openstack.org/83/173883/3/check/gate-python-magnumclient-python27/10e1899/ : SUCCESS in 48s","accounts_in_message":[],"_revision_number":3},{"id":"4b038586c250356f44524e78ed65d1c38d29bda4","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-04-16 17:54:47.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f7d095b34ebf71caf815d7347f158f95fc63f2a9","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2015-04-16 18:41:26.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"4d479777364655c32145894a27319bfff2db347e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-17 06:02:35.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"80760e336ab46e9b4aae9f1131167dc9db3a2e30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-17 06:04:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3},{"id":"a3095c7cbcb0308f45b691c98a774867121adff9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-17 06:04:08.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/83/173883/3/gate/gate-python-magnumclient-docs/c36133c//doc/build/html/ : SUCCESS in 43s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/83/173883/3/gate/gate-python-magnumclient-pep8/37f9ed4/ : SUCCESS in 45s\n- gate-python-magnumclient-python27 http://logs.openstack.org/83/173883/3/gate/gate-python-magnumclient-python27/c263281/ : SUCCESS in 39s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"553647e85e2c12f0d7815bf127fbc183e336b9c1","revisions":{"34dd29d903319b3250d3ee37c7915a1d26900e43":{"kind":"REWORK","_number":1,"created":"2015-04-15 13:47:26.000000000","uploader":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"ref":"refs/changes/83/173883/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/83/173883/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/1"}}},"commit":{"parents":[{"commit":"1f0cd6eabe7f412e27d970db25f6f67bdcc1d7a6","subject":"Support update a service","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/1f0cd6eabe7f412e27d970db25f6f67bdcc1d7a6"}]}],"author":{"name":"Lan Qi song","email":"lqslan@cn.ibm.com","date":"2015-04-15 13:46:46.000000000","tz":480},"committer":{"name":"Lan Qi song","email":"lqslan@cn.ibm.com","date":"2015-04-15 13:46:46.000000000","tz":480},"subject":"Support update a replication controller","message":"Support update a replication controller\n\nAdd the support to update a rc. Using the following command:\nmagnum rc-update \u003crc\u003e \u003cop\u003e [\u003cpath\u003dvalue\u003e]\n\nChange-Id: Ie268ea8445e9b10e4466fefea2a8ea9c44cb91f3\nPartial-Bug: #1444383\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/34dd29d903319b3250d3ee37c7915a1d26900e43"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/34dd29d903319b3250d3ee37c7915a1d26900e43"}]},"branch":"refs/heads/master"},"4e42294480dc3ca2d786ce09eb5ae02600a87594":{"kind":"REWORK","_number":2,"created":"2015-04-16 16:26:55.000000000","uploader":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"ref":"refs/changes/83/173883/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/83/173883/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/2"}}},"commit":{"parents":[{"commit":"1f0cd6eabe7f412e27d970db25f6f67bdcc1d7a6","subject":"Support update a service","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/1f0cd6eabe7f412e27d970db25f6f67bdcc1d7a6"}]}],"author":{"name":"Lan Qi song","email":"lqslan@cn.ibm.com","date":"2015-04-15 13:46:46.000000000","tz":480},"committer":{"name":"Lan Qi song","email":"lqslan@cn.ibm.com","date":"2015-04-16 16:26:16.000000000","tz":480},"subject":"Support update a replication controller","message":"Support update a replication controller\n\nAdd the support to update a rc. Using the following command:\nmagnum rc-update \u003crc\u003e \u003cop\u003e [\u003cpath\u003dvalue\u003e]\n\nIt depends on this patch: https://review.openstack.org/#/c/174209/\n\nChange-Id: Ie268ea8445e9b10e4466fefea2a8ea9c44cb91f3\nPartial-Bug: #1444383\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/4e42294480dc3ca2d786ce09eb5ae02600a87594"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/4e42294480dc3ca2d786ce09eb5ae02600a87594"}]},"branch":"refs/heads/master"},"553647e85e2c12f0d7815bf127fbc183e336b9c1":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2015-04-16 16:27:18.000000000","uploader":{"_account_id":12927,"name":"Lan Qi song","email":"lqs933@foxmail.com","username":"lqisong"},"ref":"refs/changes/83/173883/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/83/173883/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/83/173883/3"}}},"commit":{"parents":[{"commit":"545934f16d923d8e3aebf4572276a1fe5498fdd3","subject":"Support update a service","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/545934f16d923d8e3aebf4572276a1fe5498fdd3"}]}],"author":{"name":"Lan Qi song","email":"lqslan@cn.ibm.com","date":"2015-04-15 13:46:46.000000000","tz":480},"committer":{"name":"Lan Qi Song","email":"lqslan@cn.ibm.com","date":"2015-04-16 16:27:18.000000000","tz":0},"subject":"Support update a replication controller","message":"Support update a replication controller\n\nAdd the support to update a rc. Using the following command:\nmagnum rc-update \u003crc\u003e \u003cop\u003e [\u003cpath\u003dvalue\u003e]\n\nIt depends on this patch: https://review.openstack.org/#/c/174209/\n\nChange-Id: Ie268ea8445e9b10e4466fefea2a8ea9c44cb91f3\nPartial-Bug: #1444383\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/553647e85e2c12f0d7815bf127fbc183e336b9c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/553647e85e2c12f0d7815bf127fbc183e336b9c1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
