)]}'
{"magnumclient/tests/test_shell_args.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e39df9071218ebd057fc7038db5fea13a9f7fa58","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self._test_arg_success(\u0027bay-create --baymodel xxx --node-count 123\u0027)"},{"line_number":92,"context_line":"        self.assertTrue(mock_create.called)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self._test_arg_success(\u0027bay-create --baymodel xxx \u0027 +"},{"line_number":95,"context_line":"                               \u0027--bay-create-timeout 15\u0027)"},{"line_number":96,"context_line":"        self.assertTrue(mock_create.called)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_8f7809f4","line":94,"updated":"2015-04-24 00:34:59.000000000","message":"You don\u0027t need \u0027+\u0027 here.","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":14652,"name":"Jennifer Carlucci","email":"joffter@us.ibm.com","username":"joffter"},"change_message_id":"1302e4042c2a604839423329f452288abdf4a48a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self._test_arg_success(\u0027bay-create --baymodel xxx --node-count 123\u0027)"},{"line_number":92,"context_line":"        self.assertTrue(mock_create.called)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self._test_arg_success(\u0027bay-create --baymodel xxx \u0027 +"},{"line_number":95,"context_line":"                               \u0027--bay-create-timeout 15\u0027)"},{"line_number":96,"context_line":"        self.assertTrue(mock_create.called)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_226a04b4","line":94,"in_reply_to":"bab921fb_8f7809f4","updated":"2015-04-24 15:54:01.000000000","message":"Done","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"}],"magnumclient/v1/shell.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e39df9071218ebd057fc7038db5fea13a9f7fa58","unresolved":false,"context_lines":[{"line_number":77,"context_line":"@utils.arg(\u0027--discovery-url\u0027,"},{"line_number":78,"context_line":"           metavar\u003d\u0027\u003cdiscovery_url\u003e\u0027,"},{"line_number":79,"context_line":"           help\u003d\u0027Specifies custom discovery url for node discovery.\u0027)"},{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_6ff8154a","line":80,"updated":"2015-04-24 00:34:59.000000000","message":"I think \u0027--timeout\u0027 is more friendly then long option \u0027--bay-create-timeout\u0027.","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":15697,"name":"Fang Fenghua","email":"fang_fenghua@hotmail.com","username":"F"},"change_message_id":"4f97f23b9a49d3f7239aba9cf33cd549a940c396","unresolved":false,"context_lines":[{"line_number":77,"context_line":"@utils.arg(\u0027--discovery-url\u0027,"},{"line_number":78,"context_line":"           metavar\u003d\u0027\u003cdiscovery_url\u003e\u0027,"},{"line_number":79,"context_line":"           help\u003d\u0027Specifies custom discovery url for node discovery.\u0027)"},{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_dae8fde4","line":80,"in_reply_to":"bab921fb_6ff8154a","updated":"2015-04-24 00:54:49.000000000","message":"bay-create-time is much better i think.this config just for bay-create","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":14652,"name":"Jennifer Carlucci","email":"joffter@us.ibm.com","username":"joffter"},"change_message_id":"1302e4042c2a604839423329f452288abdf4a48a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"@utils.arg(\u0027--discovery-url\u0027,"},{"line_number":78,"context_line":"           metavar\u003d\u0027\u003cdiscovery_url\u003e\u0027,"},{"line_number":79,"context_line":"           help\u003d\u0027Specifies custom discovery url for node discovery.\u0027)"},{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_620a3c23","line":80,"in_reply_to":"bab921fb_7127cfb6","updated":"2015-04-24 15:54:01.000000000","message":"Makes sense, I changed the name to --timeout","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":8580,"name":"Digambar","email":"digambarpatil15@yahoo.co.in","username":"digambar"},"change_message_id":"67e46bd5d78c0c742f39331d54cbecee973ac1ab","unresolved":false,"context_lines":[{"line_number":77,"context_line":"@utils.arg(\u0027--discovery-url\u0027,"},{"line_number":78,"context_line":"           metavar\u003d\u0027\u003cdiscovery_url\u003e\u0027,"},{"line_number":79,"context_line":"           help\u003d\u0027Specifies custom discovery url for node discovery.\u0027)"},{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_7127cfb6","line":80,"in_reply_to":"bab921fb_dae8fde4","updated":"2015-04-24 03:58:05.000000000","message":"+1 madhuri because its arg of bay create, dont need to specify bay-create again in the arg.","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e39df9071218ebd057fc7038db5fea13a9f7fa58","unresolved":false,"context_lines":[{"line_number":79,"context_line":"           help\u003d\u0027Specifies custom discovery url for node discovery.\u0027)"},{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"},{"line_number":84,"context_line":"def do_bay_create(cs, args):"},{"line_number":85,"context_line":"    \"\"\"Create a bay.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_8f4fe9bc","line":82,"updated":"2015-04-24 00:34:59.000000000","message":"ditto","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":14652,"name":"Jennifer Carlucci","email":"joffter@us.ibm.com","username":"joffter"},"change_message_id":"1302e4042c2a604839423329f452288abdf4a48a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"           help\u003d\u0027Specifies custom discovery url for node discovery.\u0027)"},{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"},{"line_number":84,"context_line":"def do_bay_create(cs, args):"},{"line_number":85,"context_line":"    \"\"\"Create a bay.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_e21e4c62","line":82,"in_reply_to":"bab921fb_8f4fe9bc","updated":"2015-04-24 15:54:01.000000000","message":"Done","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e39df9071218ebd057fc7038db5fea13a9f7fa58","unresolved":false,"context_lines":[{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"},{"line_number":84,"context_line":"def do_bay_create(cs, args):"},{"line_number":85,"context_line":"    \"\"\"Create a bay.\"\"\""},{"line_number":86,"context_line":"    baymodel \u003d cs.baymodels.get(args.baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_2ff21d70","line":83,"updated":"2015-04-24 00:34:59.000000000","message":"Jeniffer what is the default value of timeout if user doesn\u0027t provide it?","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":14652,"name":"Jennifer Carlucci","email":"joffter@us.ibm.com","username":"joffter"},"change_message_id":"1302e4042c2a604839423329f452288abdf4a48a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"@utils.arg(\u0027--bay-create-timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003cbay_create_timeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027 +"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout.\u0027)"},{"line_number":84,"context_line":"def do_bay_create(cs, args):"},{"line_number":85,"context_line":"    \"\"\"Create a bay.\"\"\""},{"line_number":86,"context_line":"    baymodel \u003d cs.baymodels.get(args.baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_e24c0c72","line":83,"in_reply_to":"bab921fb_2ff21d70","updated":"2015-04-24 15:54:01.000000000","message":"The default is no timeout. I updated the help to show that.","commit_id":"df3f8d35fb1809bf1b73ed06572ebc78a039ca32"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"8a8d56e94b620634e546b2efde3df99178982a2a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"@utils.arg(\u0027--timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003ctimeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout. The default is no timeout.\u0027)"},{"line_number":84,"context_line":"def do_bay_create(cs, args):"},{"line_number":85,"context_line":"    \"\"\"Create a bay.\"\"\""},{"line_number":86,"context_line":"    baymodel \u003d cs.baymodels.get(args.baymodel)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_be6736b6","line":83,"updated":"2015-04-25 02:23:19.000000000","message":"Why would anyone set it to 0 when default is also no timeout?\n\nYou can remove the line \u0027Set to ...\u0027","commit_id":"ffd24a44b7c7edf3ea43e22e4706e0881864a73f"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"a173cbdf394cc9a3094098477eb292aceb201ee5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"@utils.arg(\u0027--timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003ctimeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout. The default is no timeout.\u0027)"},{"line_number":84,"context_line":"def do_bay_create(cs, args):"},{"line_number":85,"context_line":"    \"\"\"Create a bay.\"\"\""},{"line_number":86,"context_line":"    baymodel \u003d cs.baymodels.get(args.baymodel)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_169c9b0d","line":83,"in_reply_to":"bab921fb_34cd7e66","updated":"2015-04-27 01:39:32.000000000","message":"Agree we can merge this first.","commit_id":"ffd24a44b7c7edf3ea43e22e4706e0881864a73f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0bdc6dd613212219236644bc1b4f6b71953055a7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"@utils.arg(\u0027--timeout\u0027,"},{"line_number":81,"context_line":"           metavar\u003d\u0027\u003ctimeout\u003e\u0027,"},{"line_number":82,"context_line":"           help\u003d\u0027The timeout for bay creation in minutes. Set \u0027"},{"line_number":83,"context_line":"                \u0027to 0 for no timeout. The default is no timeout.\u0027)"},{"line_number":84,"context_line":"def do_bay_create(cs, args):"},{"line_number":85,"context_line":"    \"\"\"Create a bay.\"\"\""},{"line_number":86,"context_line":"    baymodel \u003d cs.baymodels.get(args.baymodel)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_34cd7e66","line":83,"in_reply_to":"bab921fb_be6736b6","updated":"2015-04-25 06:21:21.000000000","message":"Agree the language is imprecise but looks acceptable for merge as is.","commit_id":"ffd24a44b7c7edf3ea43e22e4706e0881864a73f"}]}