)]}'
{"id":"openstack%2Fpython-magnumclient~181839","triplet_id":"openstack%2Fpython-magnumclient~master~I6d1de3390597da91921096e927fae69a8d69ce39","project":"openstack/python-magnumclient","branch":"master","topic":"baymodel_name","hashtags":[],"change_id":"I6d1de3390597da91921096e927fae69a8d69ce39","subject":"Make baymodel name a required option","status":"ABANDONED","created":"2015-05-11 09:19:05.000000000","updated":"2015-06-08 00:38:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4cf8ab038b89fbbf600ca85800094d808fcf95b4","_number":181839,"virtual_id_number":181839,"owner":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":1,"date":"2015-05-12 05:04:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"date":"2015-05-13 02:13:27.000000000","_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-05-13 02:01:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},{"value":-1,"date":"2015-05-12 05:48:10.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-05-11 10:28:21.000000000","updated_by":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"reviewer":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"state":"REVIEWER"},{"updated":"2015-05-12 05:04:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-05-12 05:48:10.000000000","updated_by":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"reviewer":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"state":"REVIEWER"},{"updated":"2015-05-13 02:01:01.000000000","updated_by":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"reviewer":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"state":"REVIEWER"}],"messages":[{"id":"96f00f11837366ce070dbd047d0bed72059174ae","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2015-05-11 09:19:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66e4729a33f59414da2a54b61e7d10adb10f414b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-11 09:21:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/39/181839/1/check/gate-python-magnumclient-pep8/610279d/ : SUCCESS in 41s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/39/181839/1/check/gate-python-magnumclient-docs/ef61eb5//doc/build/html/ : SUCCESS in 48s\n- gate-python-magnumclient-python27 http://logs.openstack.org/39/181839/1/check/gate-python-magnumclient-python27/dc7e585/ : SUCCESS in 1m 00s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/39/181839/1/check/gate-python-magnumclient-tox-bandit/0c82297/ : SUCCESS in 37s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1445017e3c0e017f09c4550bff95a2ec1d9385cc","author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"date":"2015-05-11 10:28:21.000000000","message":"Patch Set 1: Code-Review-1\n\nPlease add a test.","accounts_in_message":[],"_revision_number":1},{"id":"d9016fe00abc9813018f80ce50d8afe8d56d2a9e","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2015-05-12 04:56:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b30cf15e7e8393ae0fb82ab35f35c57224033278","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-12 05:04:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/39/181839/2/check/gate-python-magnumclient-pep8/01789b5/ : SUCCESS in 33s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/39/181839/2/check/gate-python-magnumclient-docs/9150a72//doc/build/html/ : SUCCESS in 34s\n- gate-python-magnumclient-python27 http://logs.openstack.org/39/181839/2/check/gate-python-magnumclient-python27/6ff1e78/ : SUCCESS in 46s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/39/181839/2/check/gate-python-magnumclient-tox-bandit/0c488d7/ : SUCCESS in 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"be93b407b448b1e7809f740dbb894f542232550d","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-05-12 05:48:10.000000000","message":"Patch Set 2: Code-Review-1\n\nI have updated the bug ticket with an example of how baymodels can be used without names. I think this is a legitimate use case. Why should we prohibit creation of nameless baymodels? We can still act on them using UUID values when names are not set.","accounts_in_message":[],"_revision_number":2},{"id":"1eb7e3d3eb9a86681633c386a08e192d1494c4cf","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2015-05-13 02:01:01.000000000","message":"Patch Set 2: Code-Review-1\n\nAgree with Adrian, baymodel name is not a MUST.","accounts_in_message":[],"_revision_number":2},{"id":"64f495c77e88cea947e2b3622b16b0bff3c32f1a","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2015-05-13 02:13:27.000000000","message":"Patch Set 2:\n\nIf don\u0027t give a name, the name column will be \u0027None\u0027, and running \u0027baymodel-show None\u0027 of course you will get an error.\nSo what about making the name column blank, if don\u0027t give a name. The same solution to bay-create.","accounts_in_message":[],"_revision_number":2},{"id":"aaba34bb7319f18469cfaeed4ab400b0da93f246","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2015-05-13 02:20:14.000000000","message":"Patch Set 2:\n\nThanks haiwei, I think that we can first discuss at bug 1453732 \n\nOne option for adding name as a MUST might be remove --name option, but make name as a MUST just like \"nova boot\" or \"nova flavor-create\"","accounts_in_message":[],"_revision_number":2},{"id":"0005d7ace8bf36c39362a338b15a6e2b4440e58d","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-06-02 06:16:58.000000000","message":"Patch Set 2:\n\nIf the name is not offered by the user, we should not set the name to the string \"None\". We should set it to NULL, and display it as an empty string when a show or list operation is performed.","accounts_in_message":[],"_revision_number":2},{"id":"216d7c59c6e45fe81d27decad2f5cbdfb76ccea6","author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"date":"2015-06-08 00:38:23.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4c8bb2d84101f562d0aec5c0ad329a0c890354aa","revisions":{"f7f49f7ef51f37d0158525758e73efcedc47d475":{"kind":"REWORK","_number":1,"created":"2015-05-11 09:19:05.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/39/181839/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/39/181839/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/1"}}},"commit":{"parents":[{"commit":"a6b486d3e0e2421e3e3380c5d5b11c2a59f3ee7b","subject":"Drop use of \u0027oslo\u0027 namespace package","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/a6b486d3e0e2421e3e3380c5d5b11c2a59f3ee7b"}]}],"author":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2015-05-11 09:15:50.000000000","tz":540},"committer":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2015-05-11 09:15:50.000000000","tz":540},"subject":"Make baymodel name a required option","message":"Make baymodel name a required option\n\nChange-Id: I6d1de3390597da91921096e927fae69a8d69ce39\nCloses-Bug: #1453725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f7f49f7ef51f37d0158525758e73efcedc47d475"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f7f49f7ef51f37d0158525758e73efcedc47d475"}]},"branch":"refs/heads/master"},"4c8bb2d84101f562d0aec5c0ad329a0c890354aa":{"kind":"REWORK","_number":2,"created":"2015-05-12 04:56:22.000000000","uploader":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"ref":"refs/changes/39/181839/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/39/181839/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/39/181839/2"}}},"commit":{"parents":[{"commit":"a6b486d3e0e2421e3e3380c5d5b11c2a59f3ee7b","subject":"Drop use of \u0027oslo\u0027 namespace package","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/a6b486d3e0e2421e3e3380c5d5b11c2a59f3ee7b"}]}],"author":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2015-05-11 09:15:50.000000000","tz":540},"committer":{"name":"Haiwei Xu","email":"xu-haiwei@mxw.nes.nec.co.jp","date":"2015-05-12 04:54:56.000000000","tz":540},"subject":"Make baymodel name a required option","message":"Make baymodel name a required option\n\nChange-Id: I6d1de3390597da91921096e927fae69a8d69ce39\nCloses-Bug: #1453725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/4c8bb2d84101f562d0aec5c0ad329a0c890354aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/4c8bb2d84101f562d0aec5c0ad329a0c890354aa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}