)]}'
{"magnumclient/tests/v1/test_shell.py":[{"author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"change_message_id":"c0be9ab547e8348310829e38e74ffa888b09d348","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            discovery_url\u003dNone, bay_create_timeout\u003dNone, master_count\u003d1,"},{"line_number":136,"context_line":"            security_group_id\u003dsecurity_group_id)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_do_bay_create_with_security_group_id(self):"},{"line_number":139,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":140,"context_line":"        baymodel \u003d mock.MagicMock()"},{"line_number":141,"context_line":"        baymodel.uuid \u003d \u0027uuid\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_6f80678c","line":138,"updated":"2015-10-01 18:02:29.000000000","message":"@Manjeet: I don\u0027t think you need this test because you already added security group to all tests. It\u0027s better to add test which show that you can create without security_group or test with only required parameters.","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c054f3f5450fbca660866ef935bf62cd6efdfdb8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            discovery_url\u003dNone, bay_create_timeout\u003dNone, master_count\u003d1,"},{"line_number":136,"context_line":"            security_group_id\u003dsecurity_group_id)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_do_bay_create_with_security_group_id(self):"},{"line_number":139,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":140,"context_line":"        baymodel \u003d mock.MagicMock()"},{"line_number":141,"context_line":"        baymodel.uuid \u003d \u0027uuid\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_d047cb1b","line":138,"in_reply_to":"7a2fa921_28e048cc","updated":"2015-10-12 16:53:41.000000000","message":"I will remove this once i discuss it with daneyon.","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"4373c486a19199e02ba9d54b8a70811bcc462d78","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            discovery_url\u003dNone, bay_create_timeout\u003dNone, master_count\u003d1,"},{"line_number":136,"context_line":"            security_group_id\u003dsecurity_group_id)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_do_bay_create_with_security_group_id(self):"},{"line_number":139,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":140,"context_line":"        baymodel \u003d mock.MagicMock()"},{"line_number":141,"context_line":"        baymodel.uuid \u003d \u0027uuid\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_28e048cc","line":138,"in_reply_to":"7a2fa921_82b642f7","updated":"2015-10-09 21:48:29.000000000","message":"+1 This will be better.","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"112dccad220d579e85dbc5e25a5b48e367b115c1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            discovery_url\u003dNone, bay_create_timeout\u003dNone, master_count\u003d1,"},{"line_number":136,"context_line":"            security_group_id\u003dsecurity_group_id)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_do_bay_create_with_security_group_id(self):"},{"line_number":139,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":140,"context_line":"        baymodel \u003d mock.MagicMock()"},{"line_number":141,"context_line":"        baymodel.uuid \u003d \u0027uuid\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a0816efd","line":138,"in_reply_to":"9a1a9d01_6f80678c","updated":"2015-10-03 13:09:24.000000000","message":"+1 to Egor","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"0c4fb145f03b2ee3024c7f15ccd095489932b479","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            discovery_url\u003dNone, bay_create_timeout\u003dNone, master_count\u003d1,"},{"line_number":136,"context_line":"            security_group_id\u003dsecurity_group_id)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test_do_bay_create_with_security_group_id(self):"},{"line_number":139,"context_line":"        client_mock \u003d mock.MagicMock()"},{"line_number":140,"context_line":"        baymodel \u003d mock.MagicMock()"},{"line_number":141,"context_line":"        baymodel.uuid \u003d \u0027uuid\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_82b642f7","line":138,"in_reply_to":"9a1a9d01_a0816efd","updated":"2015-10-09 06:41:38.000000000","message":"+1","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"}],"magnumclient/v1/shell.py":[{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"3fd8176b7eb83594acee228c801d07413ff1e846","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                \u0027to 0 for no timeout. The default is no timeout.\u0027)"},{"line_number":91,"context_line":"@utils.arg(\u0027--security-group-id\u0027,"},{"line_number":92,"context_line":"           metavar\u003d\u0027\u003csecurity-group-id\u003e\u0027,"},{"line_number":93,"context_line":"           help\u003d\u0027The security group id for bay creation. It is the\u0027"},{"line_number":94,"context_line":"                \u0027security group rule to be used in template.\u0027)"},{"line_number":95,"context_line":"def do_bay_create(cs, args):"},{"line_number":96,"context_line":"    \"\"\"Create a bay.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_eb174752","line":93,"updated":"2015-10-03 17:18:47.000000000","message":"1. extra \u0027\n2. security group rule \u003d\u003e security group","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"0c4fb145f03b2ee3024c7f15ccd095489932b479","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                \u0027to 0 for no timeout. The default is no timeout.\u0027)"},{"line_number":91,"context_line":"@utils.arg(\u0027--security-group-id\u0027,"},{"line_number":92,"context_line":"           metavar\u003d\u0027\u003csecurity-group-id\u003e\u0027,"},{"line_number":93,"context_line":"           help\u003d\u0027The security group id for bay creation. It is the\u0027"},{"line_number":94,"context_line":"                \u0027security group rule to be used in template.\u0027)"},{"line_number":95,"context_line":"def do_bay_create(cs, args):"},{"line_number":96,"context_line":"    \"\"\"Create a bay.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_62aa0687","line":93,"updated":"2015-10-09 06:41:38.000000000","message":"Please add a space at the end of line.","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"1eef719c4f6689fb2a1bd2039a2e20021d736829","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                \u0027to 0 for no timeout. The default is no timeout.\u0027)"},{"line_number":91,"context_line":"@utils.arg(\u0027--security-group-id\u0027,"},{"line_number":92,"context_line":"           metavar\u003d\u0027\u003csecurity-group-id\u003e\u0027,"},{"line_number":93,"context_line":"           help\u003d\u0027The security group id for bay creation. It is the\u0027"},{"line_number":94,"context_line":"                \u0027security group rule to be used in template.\u0027)"},{"line_number":95,"context_line":"def do_bay_create(cs, args):"},{"line_number":96,"context_line":"    \"\"\"Create a bay.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_b87323e7","line":93,"in_reply_to":"7a2fa921_62aa0687","updated":"2015-10-12 13:18:25.000000000","message":"Make this an id or name to make this consistent with the other arguments.","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c054f3f5450fbca660866ef935bf62cd6efdfdb8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                \u0027to 0 for no timeout. The default is no timeout.\u0027)"},{"line_number":91,"context_line":"@utils.arg(\u0027--security-group-id\u0027,"},{"line_number":92,"context_line":"           metavar\u003d\u0027\u003csecurity-group-id\u003e\u0027,"},{"line_number":93,"context_line":"           help\u003d\u0027The security group id for bay creation. It is the\u0027"},{"line_number":94,"context_line":"                \u0027security group rule to be used in template.\u0027)"},{"line_number":95,"context_line":"def do_bay_create(cs, args):"},{"line_number":96,"context_line":"    \"\"\"Create a bay.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_700277b6","line":93,"in_reply_to":"7a2fa921_b87323e7","updated":"2015-10-12 16:53:41.000000000","message":"ok will do that","commit_id":"99f301000704213c1d1402b72358cbb7a5600a30"}]}
