)]}'
{"id":"openstack%2Fpython-magnumclient~229724","triplet_id":"openstack%2Fpython-magnumclient~master~I846d37bc980a04c696c66671412ae84ad3f49d51","project":"openstack/python-magnumclient","branch":"master","hashtags":[],"change_id":"I846d37bc980a04c696c66671412ae84ad3f49d51","subject":"Add Security group id to magnum client","status":"ABANDONED","created":"2015-10-01 05:02:42.000000000","updated":"2016-05-02 22:39:30.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bc71e69cc92c802e370124be9a589d74b537f817","_number":229724,"virtual_id_number":229724,"owner":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-10-12 16:53:41.000000000","_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},{"value":-1,"date":"2015-11-19 22:11:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"date":"2015-10-03 17:18:47.000000000","_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},{"date":"2015-10-01 18:02:29.000000000","_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"disliked":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},{"value":-1,"date":"2015-10-12 13:18:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-10-03 13:09:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":-1,"date":"2015-10-09 21:48:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":2,"date":"2015-10-01 19:11:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":-1,"date":"2015-10-09 06:41:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":-1,"date":"2015-10-03 17:18:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-01 18:02:29.000000000","updated_by":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"reviewer":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"state":"REVIEWER"},{"updated":"2015-10-01 19:11:08.000000000","updated_by":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"reviewer":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"state":"REVIEWER"},{"updated":"2015-10-03 13:09:24.000000000","updated_by":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"reviewer":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"state":"REVIEWER"},{"updated":"2015-10-03 17:18:47.000000000","updated_by":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"reviewer":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"state":"REVIEWER"},{"updated":"2015-10-09 06:41:38.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2015-10-09 21:48:29.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2015-10-12 13:18:25.000000000","updated_by":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"reviewer":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"state":"REVIEWER"},{"updated":"2015-11-19 22:11:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9ecc9a30289c83b01c584c8187fdc5971dbeca0c","author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"date":"2015-10-01 05:02:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"24d0a4c9fa6e2b88c78c9aeac58ab51614e7795a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 05:04:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/24/229724/1/check/gate-python-magnumclient-pep8/55a2a9c/ : SUCCESS in 45s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/24/229724/1/check/gate-python-magnumclient-docs/61b7b55//doc/build/html/ : SUCCESS in 49s\n- gate-python-magnumclient-python27 http://logs.openstack.org/24/229724/1/check/gate-python-magnumclient-python27/2f90634/ : SUCCESS in 1m 02s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/24/229724/1/check/gate-python-magnumclient-tox-bandit/d0da726/ : SUCCESS in 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a38e226afdc7b96092d9a2cc397a4c59fc8c5792","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-10-01 16:03:59.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks!","accounts_in_message":[],"_revision_number":1},{"id":"c0be9ab547e8348310829e38e74ffa888b09d348","author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"date":"2015-10-01 18:02:29.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4dc4d1b854b61504c1f5d175bb95aa5771694cc7","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2015-10-01 19:11:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"112dccad220d579e85dbc5e25a5b48e367b115c1","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2015-10-03 13:09:24.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3fd8176b7eb83594acee228c801d07413ff1e846","author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"date":"2015-10-03 17:18:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3b4fbb771f5954006b76ae011c0c65dfa3b1bb5d","author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"date":"2015-10-03 17:18:59.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"0c4fb145f03b2ee3024c7f15ccd095489932b479","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2015-10-09 06:41:38.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nManjeet, just wondering can\u0027t we pass this id in baymodel?","accounts_in_message":[],"_revision_number":1},{"id":"4373c486a19199e02ba9d54b8a70811bcc462d78","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-10-09 21:48:29.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nPlease see comments inline.","accounts_in_message":[],"_revision_number":1},{"id":"1eef719c4f6689fb2a1bd2039a2e20021d736829","author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"date":"2015-10-12 13:18:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c054f3f5450fbca660866ef935bf62cd6efdfdb8","author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"date":"2015-10-12 16:53:41.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nmadhuri: - I propose this should be with bay so that different security group can be configured with different bays under same bay model. All bays under a bay model having same security rule make less sense at this point.","accounts_in_message":[],"_revision_number":1},{"id":"31bf2063a7c315a1b45206044008ccf40ef0b861","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-10-12 19:02:53.000000000","message":"Patch Set 1:\n\n@Manjeet : Madhuri has a point. \n\nIn which scenario will the security group id be needed ? What is the granularity of it ? I think answering this would help us decide whether security group id should be part of a baymodel or bay.\n\nIf we add security-group-id to a baymodel as madhuri is suggesting we need to have different flavours of baymodel so that they differentiate various security group. Since a bay created from a specific flavor of a baymodel will have those security group attributes.\n\nV/S\n\nWhat you are suggesting is we keep the same blueprint of a baymodel and while bay creation specify the security group id.","accounts_in_message":[],"_revision_number":1},{"id":"443546e222022fd474134560bd79980beb0b2e5c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-19 22:11:01.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"bc71e69cc92c802e370124be9a589d74b537f817","author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"date":"2016-05-02 22:39:30.000000000","message":"Abandoned\n\nNo activity for 6 months, abandoning.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"99f301000704213c1d1402b72358cbb7a5600a30","revisions":{"99f301000704213c1d1402b72358cbb7a5600a30":{"kind":"REWORK","_number":1,"created":"2015-10-01 05:02:42.000000000","uploader":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"ref":"refs/changes/24/229724/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/24/229724/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/24/229724/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/24/229724/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/24/229724/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/24/229724/1"}}},"commit":{"parents":[{"commit":"9793da624bb01518659028dbbd34f8d26a0b73d9","subject":"Add insecure flag to baymodel","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/9793da624bb01518659028dbbd34f8d26a0b73d9"}]}],"author":{"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","date":"2015-10-01 04:59:43.000000000","tz":-240},"committer":{"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","date":"2015-10-01 05:02:31.000000000","tz":-240},"subject":"Add Security group id to magnum client","message":"Add Security group id to magnum client\n\nThis patch add parameter security_group_id to python magnum client for\nbay creation.\n\nChange-Id: I846d37bc980a04c696c66671412ae84ad3f49d51\nPartial-Bug: #1501050\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/99f301000704213c1d1402b72358cbb7a5600a30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/99f301000704213c1d1402b72358cbb7a5600a30"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
