)]}'
{"magnumclient/tests/test_shell_args.py":[{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"59a8e0466fa4c3c6b46fe2720bbfea4dc0269d00","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    # baymodel commands"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    @mock.patch(\u0027magnumclient.v1.baymodels.BayModelManager.create\u0027)"},{"line_number":207,"context_line":"    def test_baymodel_create_success(self, mock_create):"},{"line_number":208,"context_line":"        self._test_arg_success(\u0027baymodel-create \u0027"},{"line_number":209,"context_line":"                               \u0027--name test \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_ca00b904","line":206,"updated":"2015-11-12 05:34:16.000000000","message":"Could you check the default value to be \"vm\" when server-type is not specified ?","commit_id":"a4d2fc77a0efacc8409a56f601ac3241e6a250c4"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"219545b459a17500f256ca20b4e987c7e87e1cde","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    # baymodel commands"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    @mock.patch(\u0027magnumclient.v1.baymodels.BayModelManager.create\u0027)"},{"line_number":207,"context_line":"    def test_baymodel_create_success(self, mock_create):"},{"line_number":208,"context_line":"        self._test_arg_success(\u0027baymodel-create \u0027"},{"line_number":209,"context_line":"                               \u0027--name test \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_4680288b","line":206,"in_reply_to":"da85f559_34bc35ba","updated":"2015-11-20 01:50:41.000000000","message":"Sure","commit_id":"a4d2fc77a0efacc8409a56f601ac3241e6a250c4"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"8c62d74b58df3900f2505f2689ee506bcfac02df","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    # baymodel commands"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    @mock.patch(\u0027magnumclient.v1.baymodels.BayModelManager.create\u0027)"},{"line_number":207,"context_line":"    def test_baymodel_create_success(self, mock_create):"},{"line_number":208,"context_line":"        self._test_arg_success(\u0027baymodel-create \u0027"},{"line_number":209,"context_line":"                               \u0027--name test \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_34bc35ba","line":206,"in_reply_to":"da85f559_ca00b904","updated":"2015-11-12 13:42:01.000000000","message":"+1","commit_id":"a4d2fc77a0efacc8409a56f601ac3241e6a250c4"}],"magnumclient/v1/baymodels_shell.py":[{"author":{"_account_id":10511,"name":"Ligong Duan","email":"duanlg@live.cn","username":"duanlg"},"change_message_id":"2485e5e6af1a241e88236e0e07704df020041ff7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"           default\u003d\u0027vm\u0027,"},{"line_number":96,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":97,"context_line":"                \u0027for example vm. For this release \u0027"},{"line_number":98,"context_line":"                \u0027default server type will be vm.\u0027)"},{"line_number":99,"context_line":"def do_baymodel_create(cs, args):"},{"line_number":100,"context_line":"    \"\"\"Create a baymodel.\"\"\""},{"line_number":101,"context_line":"    opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_e172de48","line":98,"updated":"2015-12-07 07:18:45.000000000","message":"What about specifying the possible values here? People might don\u0027t know what is the correct value if they want to specify it for baremetal machines.","commit_id":"803fc32e0e44c09a15186bbf64bc9ec8681ae155"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"cda823367f9fd5bdb77c0f3cc708f29c4da6febb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"           default\u003d\u0027vm\u0027,"},{"line_number":96,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":97,"context_line":"                \u0027for example vm. For this release \u0027"},{"line_number":98,"context_line":"                \u0027default server type will be vm.\u0027)"},{"line_number":99,"context_line":"def do_baymodel_create(cs, args):"},{"line_number":100,"context_line":"    \"\"\"Create a baymodel.\"\"\""},{"line_number":101,"context_line":"    opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1fc5d05a","line":98,"in_reply_to":"7a740942_e172de48","updated":"2015-12-12 01:17:21.000000000","message":"Providing more details in the help like vm, baremetal, xyz will just confuse users IMHO. Hence I have clearly mentioned that for *this release* the default server type will be VM.","commit_id":"803fc32e0e44c09a15186bbf64bc9ec8681ae155"}],"magnumclient/v1/shell.py":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"c04d02b1e470952fefb7e0bff4029f4e8740f50e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           help\u003d\u0027Make baymodel public.\u0027)"},{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           required\u003dTrue,"},{"line_number":220,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_22a3bdb3","line":220,"updated":"2015-11-03 03:48:02.000000000","message":"I think it is here has some issue for required, it need have default \u0027 default\u003d\u0027vm\u0027,\u0027, as we only support vm case, bm seems can not support in M release, as there are still some issue for ironic intergration with neutron for vlan support.","commit_id":"c8a34fd37c83abd45d83dd443f5e3293ad096335"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"181db0b7fff47516bfebb6df15e0846e77f9da5f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           help\u003d\u0027Make baymodel public.\u0027)"},{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           required\u003dTrue,"},{"line_number":220,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_934cbe43","line":220,"in_reply_to":"1a26ad4f_22a3bdb3","updated":"2015-11-04 17:09:52.000000000","message":"+1. Less required parameter is better.","commit_id":"c8a34fd37c83abd45d83dd443f5e3293ad096335"},{"author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"change_message_id":"600c7c334306e00947c014da45d4a47cad92e73a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           help\u003d\u0027Make baymodel public.\u0027)"},{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           required\u003dTrue,"},{"line_number":220,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_f29db866","line":220,"in_reply_to":"1a26ad4f_22a3bdb3","updated":"2015-11-11 02:06:31.000000000","message":"@kennan,+1. Here should have default.","commit_id":"c8a34fd37c83abd45d83dd443f5e3293ad096335"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"ce461ff642bc382bedb9b9500bba7e1dbadd832c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           help\u003d\u0027Make baymodel public.\u0027)"},{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           required\u003dTrue,"},{"line_number":220,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_a29eccb6","line":220,"in_reply_to":"1a26ad4f_22a3bdb3","updated":"2015-11-11 22:05:26.000000000","message":"Done","commit_id":"c8a34fd37c83abd45d83dd443f5e3293ad096335"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"ce461ff642bc382bedb9b9500bba7e1dbadd832c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           help\u003d\u0027Make baymodel public.\u0027)"},{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           required\u003dTrue,"},{"line_number":220,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_e26134d4","line":220,"in_reply_to":"da85f559_f29db866","updated":"2015-11-11 22:05:26.000000000","message":"Done","commit_id":"c8a34fd37c83abd45d83dd443f5e3293ad096335"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"ce461ff642bc382bedb9b9500bba7e1dbadd832c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"           help\u003d\u0027Make baymodel public.\u0027)"},{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           required\u003dTrue,"},{"line_number":220,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_025d5814","line":220,"in_reply_to":"fa80f949_934cbe43","updated":"2015-11-11 22:05:26.000000000","message":"Done","commit_id":"c8a34fd37c83abd45d83dd443f5e3293ad096335"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"4eda762e18c7636f9ec27d380e44800d546379d7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":220,"context_line":"           default\u003d\u0027vm\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"},{"line_number":224,"context_line":"    \"\"\"Create a baymodel.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_11e59fa6","line":221,"updated":"2015-11-12 02:55:27.000000000","message":"s/used/used,","commit_id":"a4d2fc77a0efacc8409a56f601ac3241e6a250c4"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"219545b459a17500f256ca20b4e987c7e87e1cde","unresolved":false,"context_lines":[{"line_number":218,"context_line":"@utils.arg(\u0027--server-type\u0027,"},{"line_number":219,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":220,"context_line":"           default\u003d\u0027vm\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"},{"line_number":224,"context_line":"    \"\"\"Create a baymodel.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_0037674d","line":221,"in_reply_to":"da85f559_11e59fa6","updated":"2015-11-20 01:50:41.000000000","message":"Done","commit_id":"a4d2fc77a0efacc8409a56f601ac3241e6a250c4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"4eda762e18c7636f9ec27d380e44800d546379d7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":220,"context_line":"           default\u003d\u0027vm\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"},{"line_number":224,"context_line":"    \"\"\"Create a baymodel.\"\"\""},{"line_number":225,"context_line":"    opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_31a54346","line":222,"updated":"2015-11-12 02:55:27.000000000","message":"What about \"only vm and baremetal are supportted\"","commit_id":"a4d2fc77a0efacc8409a56f601ac3241e6a250c4"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"219545b459a17500f256ca20b4e987c7e87e1cde","unresolved":false,"context_lines":[{"line_number":219,"context_line":"           metavar\u003d\u0027\u003cserver-type\u003e\u0027,"},{"line_number":220,"context_line":"           default\u003d\u0027vm\u0027,"},{"line_number":221,"context_line":"           help\u003d\u0027Specify the server type to be used \u0027"},{"line_number":222,"context_line":"                \u0027for example vm, baremetal.\u0027)"},{"line_number":223,"context_line":"def do_baymodel_create(cs, args):"},{"line_number":224,"context_line":"    \"\"\"Create a baymodel.\"\"\""},{"line_number":225,"context_line":"    opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_e058238c","line":222,"in_reply_to":"da85f559_31a54346","updated":"2015-11-20 01:50:41.000000000","message":"Made it more explicit that only server-type\u003dvm is supported in this release","commit_id":"a4d2fc77a0efacc8409a56f601ac3241e6a250c4"}]}