)]}'
{"magnumclient/common/httpclient.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"33e2ee0fdbd542fbdc3003120817bf56573d53f4","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def json_request(self, method, url, **kwargs):"},{"line_number":313,"context_line":"        if url.startswith(API_VERSION):"},{"line_number":314,"context_line":"            url \u003d url[len(API_VERSION):]"},{"line_number":315,"context_line":"        kwargs.setdefault(\u0027headers\u0027, {})"},{"line_number":316,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Content-Type\u0027, \u0027application/json\u0027)"},{"line_number":317,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Accept\u0027, \u0027application/json\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_ea22ab51","line":314,"updated":"2015-11-10 19:02:48.000000000","message":"The method \u0027raw_request\u0027 needs a similar tweak, or you can move it to \u0027_http_request\u0027 to consolidate.","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"185c644a58643a4ac32469bc8f07960e4b23cdcd","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    def json_request(self, method, url, **kwargs):"},{"line_number":313,"context_line":"        if url.startswith(API_VERSION):"},{"line_number":314,"context_line":"            url \u003d url[len(API_VERSION):]"},{"line_number":315,"context_line":"        kwargs.setdefault(\u0027headers\u0027, {})"},{"line_number":316,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Content-Type\u0027, \u0027application/json\u0027)"},{"line_number":317,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Accept\u0027, \u0027application/json\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_ce28ede4","line":314,"in_reply_to":"da85f559_ea22ab51","updated":"2015-11-11 16:21:58.000000000","message":"Done","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"}],"magnumclient/v1/client.py":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"a2d758b29e24d4db34092bb5dc047402238d854a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                 session\u003dNone, password\u003dNone, auth_type\u003d\u0027password\u0027,"},{"line_number":37,"context_line":"                 interface\u003d\u0027public\u0027, service_name\u003dNone):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # We have to keep the api_key are for backwards compat, but let\u0027s"},{"line_number":40,"context_line":"        # remove it from the rest of our code since it\u0027s not a keystone"},{"line_number":41,"context_line":"        # concept"},{"line_number":42,"context_line":"        if not password:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_24093f96","line":39,"updated":"2015-11-07 18:40:52.000000000","message":"nit, the syntax of that comment looks confusing","commit_id":"f5821ad8eb59c38178933890242ed90129545673"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"a2d758b29e24d4db34092bb5dc047402238d854a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # concept"},{"line_number":42,"context_line":"        if not password:"},{"line_number":43,"context_line":"            password \u003d api_key"},{"line_number":44,"context_line":"        # Backwards compat for people assing in endpoint_type"},{"line_number":45,"context_line":"        if endpoint_type:"},{"line_number":46,"context_line":"            interface \u003d endpoint_type"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_c4fdd36f","line":44,"updated":"2015-11-07 18:40:52.000000000","message":"typo","commit_id":"f5821ad8eb59c38178933890242ed90129545673"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"15b4c429e5a585444a451f5228140f8bf325d359","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            try:"},{"line_number":85,"context_line":"                # Trigger an auth error so that we can throw the exception"},{"line_number":86,"context_line":"                # we always have"},{"line_number":87,"context_line":"                session.get_endpoint("},{"line_number":88,"context_line":"                    service_type\u003dservice_type,"},{"line_number":89,"context_line":"                    service_name\u003dservice_name,"},{"line_number":90,"context_line":"                    interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_2a250ec0","line":87,"updated":"2015-11-10 21:18:56.000000000","message":"magnum_url \u003d session.get_endpoint(","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"185c644a58643a4ac32469bc8f07960e4b23cdcd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            try:"},{"line_number":85,"context_line":"                # Trigger an auth error so that we can throw the exception"},{"line_number":86,"context_line":"                # we always have"},{"line_number":87,"context_line":"                session.get_endpoint("},{"line_number":88,"context_line":"                    service_type\u003dservice_type,"},{"line_number":89,"context_line":"                    service_name\u003dservice_name,"},{"line_number":90,"context_line":"                    interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_2e38993c","line":87,"in_reply_to":"da85f559_2a250ec0","updated":"2015-11-11 16:21:58.000000000","message":"Done","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"d494fbe88408813b3c6d87ca046effdf5652583a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            try:"},{"line_number":85,"context_line":"                # Trigger an auth error so that we can throw the exception"},{"line_number":86,"context_line":"                # we always have"},{"line_number":87,"context_line":"                session.get_endpoint("},{"line_number":88,"context_line":"                    service_type\u003dservice_type,"},{"line_number":89,"context_line":"                    service_name\u003dservice_name,"},{"line_number":90,"context_line":"                    interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_0d0fd288","line":87,"in_reply_to":"da85f559_2e38993c","updated":"2015-11-11 19:15:31.000000000","message":"no need to store that magnum_url , we are not using anywhere","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"15b4c429e5a585444a451f5228140f8bf325d359","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    interface\u003dinterface,"},{"line_number":91,"context_line":"                    region_name\u003dregion_name)"},{"line_number":92,"context_line":"            except Exception:"},{"line_number":93,"context_line":"                raise RuntimeError(\"Not Authorized\")"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.http_client \u003d httpclient.SessionClient("},{"line_number":96,"context_line":"            service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_4d074c18","line":93,"updated":"2015-11-10 21:18:56.000000000","message":"I tested it. It looks line #83-93 is not needed, because \u0027SessionClient\u0027 can get an endpoint if not provided.","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"185c644a58643a4ac32469bc8f07960e4b23cdcd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    interface\u003dinterface,"},{"line_number":91,"context_line":"                    region_name\u003dregion_name)"},{"line_number":92,"context_line":"            except Exception:"},{"line_number":93,"context_line":"                raise RuntimeError(\"Not Authorized\")"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.http_client \u003d httpclient.SessionClient("},{"line_number":96,"context_line":"            service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_4e063d87","line":93,"in_reply_to":"da85f559_4d074c18","updated":"2015-11-11 16:21:58.000000000","message":"Done","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"d494fbe88408813b3c6d87ca046effdf5652583a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    interface\u003dinterface,"},{"line_number":91,"context_line":"                    region_name\u003dregion_name)"},{"line_number":92,"context_line":"            except Exception:"},{"line_number":93,"context_line":"                raise RuntimeError(\"Not Authorized\")"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        self.http_client \u003d httpclient.SessionClient("},{"line_number":96,"context_line":"            service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_ed804ec1","line":93,"in_reply_to":"da85f559_4e063d87","updated":"2015-11-11 19:15:31.000000000","message":"Tested, if i remove that lines, tests fail with an unauthorized access exception. We need to properly trap this","commit_id":"11d2157def2e1d10f228ec1b241c766c0bbc1789"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"4af2dbb9ba0faa28b82d132a1bfb290ca17b59cf","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            try:"},{"line_number":85,"context_line":"                # Trigger an auth error so that we can throw the exception"},{"line_number":86,"context_line":"                # we always have"},{"line_number":87,"context_line":"                session.get_endpoint("},{"line_number":88,"context_line":"                    service_type\u003dservice_type,"},{"line_number":89,"context_line":"                    service_name\u003dservice_name,"},{"line_number":90,"context_line":"                    interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_c358888c","line":87,"updated":"2015-11-12 15:02:53.000000000","message":"As my previous comment, the endpoint retrieval here is unnecessary, since SessionClient is able to retrieve it if not provided. However, this patch looks good in overall. I am going to +2 on it. The issue is minor and we can revisit it later.","commit_id":"5cbc5e722e4878e35399be575a6cc36d266b00ff"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"59f91bdeb2622d25a04f5e964396c7ab15bfd187","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            try:"},{"line_number":85,"context_line":"                # Trigger an auth error so that we can throw the exception"},{"line_number":86,"context_line":"                # we always have"},{"line_number":87,"context_line":"                session.get_endpoint("},{"line_number":88,"context_line":"                    service_type\u003dservice_type,"},{"line_number":89,"context_line":"                    service_name\u003dservice_name,"},{"line_number":90,"context_line":"                    interface\u003dinterface,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_6643eaaf","line":87,"in_reply_to":"da85f559_c358888c","updated":"2015-11-12 15:14:54.000000000","message":"Hi, i kept adding that, because without that endpoint retrieval, we were not passing tests. It was complaining at this point due to unauthorized access.","commit_id":"5cbc5e722e4878e35399be575a6cc36d266b00ff"}]}