)]}'
{"magnumclient/v1/bays_shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7163c3d2cd95df86a7a6c9484f7e3e1c01c58774","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    opts[\u0027node_count\u0027] \u003d args.node_count"},{"line_number":61,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":62,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"},{"line_number":63,"context_line":"    if args.timeout:"},{"line_number":64,"context_line":"        opts[\u0027bay_create_timeout\u0027] \u003d args.timeout"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    bay \u003d cs.bays.create(**opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_8b4b572b","line":63,"updated":"2015-12-03 20:37:39.000000000","message":"Better to check against None instead:\n\nif args.timeout is not None:\n    ....","commit_id":"3b42486e8f4e495c7ca6a05a5ae99dae99c6b231"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"58e71aaf3f77ca113c55b1dab3fef7faaa24fade","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":62,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"},{"line_number":63,"context_line":"    if args.timeout is not None:"},{"line_number":64,"context_line":"        opts[\u0027bay_create_timeout\u0027] \u003d args.timeout"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    bay \u003d cs.bays.create(**opts)"},{"line_number":67,"context_line":"    _show_bay(bay)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_5299691e","line":64,"updated":"2015-12-04 20:35:55.000000000","message":"With is even if timeout \u003d \u0027 \u0027 it will go through. Is that acceptable ?\n\nHow about using \n\nif agrs.timeout:\n     opts[\u0027bay_create_timeout\u0027] \u003d args.timeout\n\n\n\u003e\u003e\u003e timeout \u003d \u0027 \u0027\n\n\u003e\u003e\u003e if timeout is not None:\n...     print True\n... else:\n...     print False\n... \nTrue\n\n\u003e\u003e\u003e if timeout:\n...     print True\n... else:\n...     print False\n... \nFalse\n\n\u003e\u003e\u003e timeout \u003d 20\n\n\u003e\u003e\u003e if timeout:\n...     print True\n... else:\n...     print False\n... \nTrue\n\u003e\u003e\u003e","commit_id":"803a3402c18627628d2d6cea5594947c578777d9"},{"author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"change_message_id":"993dd79f2f1325567ba1b2881a37e3af7eb90beb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":62,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"},{"line_number":63,"context_line":"    if args.timeout is not None:"},{"line_number":64,"context_line":"        opts[\u0027bay_create_timeout\u0027] \u003d args.timeout"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    bay \u003d cs.bays.create(**opts)"},{"line_number":67,"context_line":"    _show_bay(bay)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_ae01416c","line":64,"in_reply_to":"7a740942_5299691e","updated":"2015-12-05 01:07:29.000000000","message":"Hi Vilobh, good catch, from server side: bay_create_timeout \u003d wsme.wsattr(wtypes.IntegerType(minimum\u003d0), default\u003d0)\nmaybe we can add type\u003dint, default\u003d0 to timeout arg define. but there\u0027s another problem, bay_create_timeout\u003dNone is acceptable by server, how can we pass None to server through comand line? I tried --timeout None , no luck, maybe we need to add check like:\nif args.timeout is \"None\"\n    args.timeout \u003d None\n?","commit_id":"803a3402c18627628d2d6cea5594947c578777d9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"7a24c3ec6f23815e97b7863489b5c4a802eec316","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":62,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"},{"line_number":63,"context_line":"    if args.timeout is not None:"},{"line_number":64,"context_line":"        opts[\u0027bay_create_timeout\u0027] \u003d args.timeout"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    bay \u003d cs.bays.create(**opts)"},{"line_number":67,"context_line":"    _show_bay(bay)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_5b165ef2","line":64,"in_reply_to":"7a740942_5299691e","updated":"2015-12-05 03:04:54.000000000","message":"I think it is fine. Just let it go through. Sever will validate the input and return a 400 error. The goal here is to set a default timeout if users doesn\u0027t input one. If users explicitly set an invalid input, it is OK to defer the validation to sever.","commit_id":"803a3402c18627628d2d6cea5594947c578777d9"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"bdd85b7a2415b86dd83f3b06edf1ebfc49255c0f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":62,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"},{"line_number":63,"context_line":"    if args.timeout is not None:"},{"line_number":64,"context_line":"        opts[\u0027bay_create_timeout\u0027] \u003d args.timeout"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    bay \u003d cs.bays.create(**opts)"},{"line_number":67,"context_line":"    _show_bay(bay)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_f2316b0c","line":64,"in_reply_to":"7a740942_5b165ef2","updated":"2015-12-16 02:40:03.000000000","message":"Ok :)","commit_id":"803a3402c18627628d2d6cea5594947c578777d9"}]}