)]}'
{"id":"openstack%2Fpython-magnumclient~252772","triplet_id":"openstack%2Fpython-magnumclient~master~I07614c6431897836362b06c73fefc02bf42497bc","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1465097","hashtags":[],"change_id":"I07614c6431897836362b06c73fefc02bf42497bc","subject":"Fix default node_count","status":"ABANDONED","created":"2015-12-03 06:37:43.000000000","updated":"2015-12-29 06:51:33.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d015bb0f6d0ca0a1c2bb92726ef08b6c595de21c","_number":252772,"virtual_id_number":252772,"owner":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":1,"date":"2015-12-03 23:35:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},{"date":"2015-12-04 02:23:06.000000000","_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-12-04 06:28:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":-1,"date":"2015-12-04 01:47:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":-1,"date":"2015-12-08 18:09:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"value":1,"date":"2015-12-04 00:58:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"all":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},{"value":-1,"date":"2015-12-07 02:30:48.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-03 19:37:06.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2015-12-03 23:35:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-12-04 00:58:27.000000000","updated_by":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"reviewer":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"state":"REVIEWER"},{"updated":"2015-12-04 01:47:54.000000000","updated_by":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"reviewer":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"state":"REVIEWER"},{"updated":"2015-12-04 06:28:34.000000000","updated_by":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"reviewer":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"state":"REVIEWER"},{"updated":"2015-12-08 18:09:40.000000000","updated_by":{"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},"reviewer":{"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},"state":"REVIEWER"}],"messages":[{"id":"fc59e83fd98c1572d9b61c9cc58ffc7f34952d40","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-03 06:37:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4253b8edd24626071c333393f164d81cc7d7def","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 06:49:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/72/252772/1/check/gate-python-magnumclient-pep8/dd34ae6/ : SUCCESS in 57s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/72/252772/1/check/gate-python-magnumclient-docs/cd824e3//doc/build/html/ : SUCCESS in 48s\n- gate-python-magnumclient-python27 http://logs.openstack.org/72/252772/1/check/gate-python-magnumclient-python27/7ff5772/ : SUCCESS in 59s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/72/252772/1/check/gate-python-magnumclient-tox-bandit/51e6522/ : SUCCESS in 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"65cc9f9090c08e679194a1eb54e82ddc1196088a","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2015-12-03 19:37:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2b509e3e9fd35125f05df144c9b3fe1746eebe4f","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-03 23:33:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d2b9966797657a883b237bbcaadeea19ed3bb6c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-03 23:35:35.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/72/252772/2/check/gate-python-magnumclient-pep8/8caa746/ : SUCCESS in 51s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/72/252772/2/check/gate-python-magnumclient-docs/0b3c631//doc/build/html/ : SUCCESS in 51s\n- gate-python-magnumclient-python27 http://logs.openstack.org/72/252772/2/check/gate-python-magnumclient-python27/6dfa14e/ : SUCCESS in 1m 01s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/72/252772/2/check/gate-python-magnumclient-tox-bandit/a5c5e12/ : SUCCESS in 50s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"de48042a61c2789b2d72e62371c5d6fecc00af01","author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"date":"2015-12-04 00:58:27.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b6302218c1b1fc40172880730cb48eb5c6542277","author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"date":"2015-12-04 01:47:54.000000000","message":"Patch Set 2: Code-Review-1\n\nNeed more input, if pass None, whether in CLI or REST API, we both need handle correctly in  server part. Please provide more input.","accounts_in_message":[],"_revision_number":2},{"id":"a32eeb8ddcf72ca5aaf3f071acdd470c6328a177","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-04 02:23:06.000000000","message":"Patch Set 2:\n\n@Kennan, I don\u0027t think if the user set node_count\u003dNone, we should convert it to default value, I think what default means is if the user do not provide node_count, we will use the default value(this is also what WSME framework does). If the user explicitly provide the node_count param, we should not set the default value, we should add param validation if the node_count is wrong(both server/client side), for example, currently magnum client will not take \u0027--node-count None\u0027, it will report invalid node-count:\n$ magnum bay-create --name k8sbay-test2 --baymodel k8sbaymodel --node-count None\nERROR: Invalid input for field/attribute bay. Value: \u0027{\u0027name\u0027: \u0027k8sbay-test2\u0027, \u0027node_count\u0027: \u0027None\u0027, \u0027master_count\u0027: 1, \u0027baymodel_id\u0027: \u00276f5a653a-d608-4914-879b-dc20e1c27fe7\u0027, \u0027discovery_url\u0027: None}\u0027. invalid literal for int() with base 10: \u0027None\u0027 (HTTP 400)\n\nAnother example, bay_create_timeout\u003dNone, is valid on server side, users can explicitly pass bay_create_timeout\u003dNone to magnum API, so that the timeout will fallback to: cfg.CONF.bay_heat.bay_create_timeout in magnum/conductor/handlers/bay_conductor.py. if the user ommit bay_create_timeout, it will be set to default 0.","accounts_in_message":[],"_revision_number":2},{"id":"029da84eb0fda6c99a9b9bc875ec68a4346d938d","author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"date":"2015-12-04 03:25:23.000000000","message":"Patch Set 2:\n\nHi @Yang, from what I found according to your message, some potenetial issues.\n\n1. client not good at checking node_count\n\nI opened one https://bugs.launchpad.net/magnum/+bug/1522668 \n\n2. Also for your comments above, I did not think if Pass None to server from REST API, we need fallback to default value, we also need handle in server side, and validate it is invalid, and throw meaningful exception.\n\n\nSo this patch is not good at address the node_count, I did not think it is enough in this patch, it need further enhance for it.","accounts_in_message":[],"_revision_number":2},{"id":"a15763bf2e661628bf9dd21d84e42db41680de45","author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"date":"2015-12-04 06:28:34.000000000","message":"Patch Set 2: Code-Review-1\n\nThis patch addresses a good point but does not seem to be related to the bug being linked here.  The bug Kennan mentioned is a good candidate. Since we are defining the API and user interface, we can expect a lot of different opinions. Maybe a good place for this discussion is in the bug, and if necessary, we should discuss on the IRC meeting for quicker resolution from the team.","accounts_in_message":[],"_revision_number":2},{"id":"29880e64045f9e3f8fe1964c369b841dbef41d2e","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-07 02:30:48.000000000","message":"Patch Set 2: Workflow-1\n\nI think this patch no longer needed after https://review.openstack.org/#/c/253312/\nbeen merged.","accounts_in_message":[],"_revision_number":2},{"id":"d4198c69ed4310a85886bf94c967fc809dcebb0c","author":{"_account_id":6698,"name":"Robert Pothier","email":"robpothier35@gmail.com","username":"rpothier"},"date":"2015-12-08 18:09:40.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e I think this patch no longer needed\nIf this is no longer needed, please mark it as abandoned.","accounts_in_message":[],"_revision_number":2},{"id":"8e2853bcf4387716948afea7ab67ffa0ad67dce1","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-29 06:51:33.000000000","message":"Abandoned\n\nno longer needed","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"67dc62b08774e1466138484a39c2a1d0cefe0c60","revisions":{"6bcf78faad267b41bf2e92c13ead628aedd5a316":{"kind":"REWORK","_number":1,"created":"2015-12-03 06:37:43.000000000","uploader":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"ref":"refs/changes/72/252772/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/72/252772/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/1"}}},"commit":{"parents":[{"commit":"dfe22bcf6b6b3fde83f3918b462c0884cb5c88c6","subject":"Fix Service CLI to work with Object from Bay","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/dfe22bcf6b6b3fde83f3918b462c0884cb5c88c6"}]}],"author":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-03 06:34:14.000000000","tz":480},"committer":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-03 06:35:55.000000000","tz":480},"subject":"Fix default node_count","message":"Fix default node_count\n\nIf --node-count is ommitted, we should not pass node_count\u003dNone\nto magnum api, this will cause magnum api won\u0027t set it\u0027s default\nvalue 1.\n\nChange-Id: I07614c6431897836362b06c73fefc02bf42497bc\nCloses-Bug: #1465097\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/6bcf78faad267b41bf2e92c13ead628aedd5a316"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/6bcf78faad267b41bf2e92c13ead628aedd5a316"}]},"branch":"refs/heads/master"},"67dc62b08774e1466138484a39c2a1d0cefe0c60":{"kind":"REWORK","_number":2,"created":"2015-12-03 23:33:48.000000000","uploader":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"ref":"refs/changes/72/252772/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/72/252772/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/72/252772/2"}}},"commit":{"parents":[{"commit":"dfe22bcf6b6b3fde83f3918b462c0884cb5c88c6","subject":"Fix Service CLI to work with Object from Bay","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/dfe22bcf6b6b3fde83f3918b462c0884cb5c88c6"}]}],"author":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-03 06:34:14.000000000","tz":480},"committer":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-03 23:33:19.000000000","tz":480},"subject":"Fix default node_count","message":"Fix default node_count\n\nIf --node-count is ommitted, we should not pass node_count\u003dNone\nto magnum api, this will cause magnum api won\u0027t set it\u0027s default\nvalue 1.\n\nChange-Id: I07614c6431897836362b06c73fefc02bf42497bc\nCloses-Bug: #1465097\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/67dc62b08774e1466138484a39c2a1d0cefe0c60"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/67dc62b08774e1466138484a39c2a1d0cefe0c60"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
