)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"ae78176e2cca2dccc373124f017051f4d12d948a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently client rely node_count validation on server side,"},{"line_number":10,"context_line":"this is not good, the patch fix this."},{"line_number":11,"context_line":"Also make node_count default to 1."},{"line_number":12,"context_line":"Add invalid --node-cound test."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I21109682358e125ae99326978eee73e09db476ba"},{"line_number":15,"context_line":"Closes-Bug: #1522668"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_661b8b1c","line":12,"updated":"2015-12-04 18:31:06.000000000","message":"--node-cound \u003d\u003e --node-count","commit_id":"3e4aa15da67ab2ecf50e1637a554d6bdfabeeb0c"}],"magnumclient/tests/v1/shell_test_base.py":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"ae78176e2cca2dccc373124f017051f4d12d948a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    _few_argument_error \u003d ["},{"line_number":43,"context_line":"        \u0027.*?^usage: magnum \u0027,"},{"line_number":44,"context_line":"        \u0027.*?^error: (the following arguments|too few arguments)\u0027,"},{"line_number":45,"context_line":"        \".*?^Try\""},{"line_number":46,"context_line":"        ]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _invalid_value_error \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_c6e35f04","line":45,"updated":"2015-12-04 18:31:06.000000000","message":"Since you are here would appreciate you fix this and add\n\nmagnum help as done with other arg_error","commit_id":"3e4aa15da67ab2ecf50e1637a554d6bdfabeeb0c"},{"author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"change_message_id":"12fae4b03f9c62ec1b8e5d924d9ce2eb701e1760","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    _few_argument_error \u003d ["},{"line_number":43,"context_line":"        \u0027.*?^usage: magnum \u0027,"},{"line_number":44,"context_line":"        \u0027.*?^error: (the following arguments|too few arguments)\u0027,"},{"line_number":45,"context_line":"        \".*?^Try\""},{"line_number":46,"context_line":"        ]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    _invalid_value_error \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_8e20059d","line":45,"in_reply_to":"7a740942_c6e35f04","updated":"2015-12-05 00:28:36.000000000","message":"ok, I think this nit fix should be another patch, because it has nothing to do with the bug referenced, But I\u0027m ok to fix this as you require, will submit a new patchset, thank you.","commit_id":"3e4aa15da67ab2ecf50e1637a554d6bdfabeeb0c"}],"magnumclient/v1/bays_shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"53e9ca214397236b02bd22803dd161e5e0fbb451","unresolved":false,"context_lines":[{"line_number":38,"context_line":"           help\u003d\u0027ID or name of the baymodel.\u0027)"},{"line_number":39,"context_line":"@utils.arg(\u0027--node-count\u0027,"},{"line_number":40,"context_line":"           metavar\u003d\u0027\u003cnode-count\u003e\u0027,"},{"line_number":41,"context_line":"           type\u003dint,"},{"line_number":42,"context_line":"           default\u003d1,"},{"line_number":43,"context_line":"           help\u003d\u0027The bay node count.\u0027)"},{"line_number":44,"context_line":"@utils.arg(\u0027--master-count\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_69a60955","line":41,"updated":"2015-12-04 15:30:53.000000000","message":"It seems setting \u0027type\u003dint\u0027 is unnecessary. In below, master-count doesn\u0027t set this and it still works. Could you elaborate what is the effect of this keyword argument?","commit_id":"a2bb2468f6c4b14a92a6b039dcbed90a98a67ff2"},{"author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"change_message_id":"6f0c7703c1f98d9c26df91977c18979f81e9797c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"           help\u003d\u0027ID or name of the baymodel.\u0027)"},{"line_number":39,"context_line":"@utils.arg(\u0027--node-count\u0027,"},{"line_number":40,"context_line":"           metavar\u003d\u0027\u003cnode-count\u003e\u0027,"},{"line_number":41,"context_line":"           type\u003dint,"},{"line_number":42,"context_line":"           default\u003d1,"},{"line_number":43,"context_line":"           help\u003d\u0027The bay node count.\u0027)"},{"line_number":44,"context_line":"@utils.arg(\u0027--master-count\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_0c899326","line":41,"in_reply_to":"7a740942_69a60955","updated":"2015-12-04 15:45:11.000000000","message":"If set this argument, the client command will check the type if it is valid. Otherwise, invalid param will be sent to server and rely server on the validation. That\u0027s why master-count doesn\u0027t set but still works(my another patch also set this argument to improve master-count validation), the ERROR was returned by server. Adding this line is to improve the validation, we should validate the argument both on client/server side.","commit_id":"a2bb2468f6c4b14a92a6b039dcbed90a98a67ff2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fd418076bd1ef53c679bd554041005205fc8add0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"           help\u003d\u0027ID or name of the baymodel.\u0027)"},{"line_number":39,"context_line":"@utils.arg(\u0027--node-count\u0027,"},{"line_number":40,"context_line":"           metavar\u003d\u0027\u003cnode-count\u003e\u0027,"},{"line_number":41,"context_line":"           type\u003dint,"},{"line_number":42,"context_line":"           default\u003d1,"},{"line_number":43,"context_line":"           help\u003d\u0027The bay node count.\u0027)"},{"line_number":44,"context_line":"@utils.arg(\u0027--master-count\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_cc994b70","line":41,"in_reply_to":"7a740942_69a60955","updated":"2015-12-04 15:45:58.000000000","message":"Never mind. I saw you explained it in the bug.","commit_id":"a2bb2468f6c4b14a92a6b039dcbed90a98a67ff2"}]}