)]}'
{"id":"openstack%2Fpython-magnumclient~253313","triplet_id":"openstack%2Fpython-magnumclient~master~Icf2b850f78989365814437e2c22c994c6ebc1fc1","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1522668","hashtags":[],"change_id":"Icf2b850f78989365814437e2c22c994c6ebc1fc1","subject":"Improve client master_count validation","status":"MERGED","created":"2015-12-04 04:12:27.000000000","updated":"2015-12-07 01:07:08.000000000","submitted":"2015-12-07 01:07:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1fa100021d666e67047130faf50de84a0f52ca55","_number":253313,"virtual_id_number":253313,"owner":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":2,"date":"2015-12-07 01:07:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"date":"2015-12-07 01:00:42.000000000","_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"value":0,"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-06 09:01:08.000000000","_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":2,"date":"2015-12-07 01:01:30.000000000","_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"value":1,"date":"2015-12-05 07:02:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":1,"date":"2015-12-07 01:01:30.000000000","_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"value":0,"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},{"value":0,"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-04 15:39:21.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2015-12-05 07:02:51.000000000","updated_by":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"reviewer":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"state":"REVIEWER"},{"updated":"2015-12-06 09:01:08.000000000","updated_by":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"reviewer":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"state":"REVIEWER"},{"updated":"2015-12-07 01:01:30.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2015-12-07 01:07:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"aaee9f4c164f323e967abc1af77f64a5b7d14f15","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-04 04:12:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a67691aa831f46d5ecab5787944b3e53c362e33","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-04 04:25:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/13/253313/1/check/gate-python-magnumclient-pep8/5ac83bd/ : SUCCESS in 49s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/13/253313/1/check/gate-python-magnumclient-docs/68e8652//doc/build/html/ : SUCCESS in 48s\n- gate-python-magnumclient-python27 http://logs.openstack.org/13/253313/1/check/gate-python-magnumclient-python27/6c39d25/ : SUCCESS in 59s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/13/253313/1/check/gate-python-magnumclient-tox-bandit/d0fafb4/ : SUCCESS in 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"56e2558352c571b3d5e1bc1dfe469f819b071cc5","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2015-12-04 15:36:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"27ee9bd06cbf53bc4675c0c035161612eafd304a","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2015-12-04 15:39:21.000000000","message":"Patch Set 1: Code-Review-1\n\nSorry for changing my vote. I think it is better to have a test case for this scenario.","accounts_in_message":[],"_revision_number":1},{"id":"ddb2e63e4f77b94494cb5d4f380c16f67a18bcfa","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-04 16:18:37.000000000","message":"Patch Set 1:\n\n@Hongbin I want to address the test case after https://review.openstack.org/#/c/253312/ been merged, because they can share self._invalid_value_error","accounts_in_message":[],"_revision_number":1},{"id":"bf386da856bad27b4b6d74d3bc6a18255b8e926e","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-12-04 18:32:01.000000000","message":"Patch Set 1: Code-Review-1\n\nUnit test please. Would prefer a complete patch.","accounts_in_message":[],"_revision_number":1},{"id":"e216ccd1b424502e4419580cd3c331b2841d4516","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2015-12-05 00:54:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5dc0eb55ae67b0239b3863badefc6526f5a6ae90","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-05 01:00:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/13/253313/2/check/gate-python-magnumclient-pep8/004bfe3/ : SUCCESS in 1m 00s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/13/253313/2/check/gate-python-magnumclient-docs/5515c40//doc/build/html/ : SUCCESS in 48s\n- gate-python-magnumclient-python27 http://logs.openstack.org/13/253313/2/check/gate-python-magnumclient-python27/b68c7c9/ : SUCCESS in 1m 31s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/13/253313/2/check/gate-python-magnumclient-tox-bandit/bdd5089/ : SUCCESS in 1m 02s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"124d2116ca9f5625363df35edd84eb851883caa0","author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"date":"2015-12-05 07:02:51.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"dcb066dec9276f86f644528ba74d2358fc41ca6a","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2015-12-06 09:01:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"29cd17c4d5d743309347d4df3b4aa6e316868d76","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-12-07 01:01:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0fb6018f55fd4f70ff3478d913df1a647d18331b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-07 01:01:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"93b42f213d17470a17239ed2b19a7974fb8e218a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-07 01:07:07.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/13/253313/2/gate/gate-python-magnumclient-docs/bd13e18//doc/build/html/ : SUCCESS in 54s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/13/253313/2/gate/gate-python-magnumclient-pep8/9f8a935/ : SUCCESS in 52s\n- gate-python-magnumclient-python27 http://logs.openstack.org/13/253313/2/gate/gate-python-magnumclient-python27/1de776f/ : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":2},{"id":"536177e261db9afc6e18f19cbc99481808e49e56","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-07 01:07:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c8810bef54d12487d06449676f6b49ab1f6970c7","revisions":{"8e7736d6448b856389655879aa236e5a7e684bf3":{"kind":"REWORK","_number":1,"created":"2015-12-04 04:12:27.000000000","uploader":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"ref":"refs/changes/13/253313/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/13/253313/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/1"}}},"commit":{"parents":[{"commit":"d25bd6e3c388885572f53b9b1ba8d67d59de43f8","subject":"Merge \"Fix RC CLI to work with Object from Bay\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/d25bd6e3c388885572f53b9b1ba8d67d59de43f8"}]}],"author":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-04 04:10:33.000000000","tz":480},"committer":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-04 04:10:33.000000000","tz":480},"subject":"Improve client master_count validation","message":"Improve client master_count validation\n\nCurrently client rely master_count validation on server side,\nthis is not good, the patch fix this.\n\nChange-Id: Icf2b850f78989365814437e2c22c994c6ebc1fc1\nRelated-Bug: #1522668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/8e7736d6448b856389655879aa236e5a7e684bf3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/8e7736d6448b856389655879aa236e5a7e684bf3"}]},"branch":"refs/heads/master"},"c8810bef54d12487d06449676f6b49ab1f6970c7":{"kind":"REWORK","_number":2,"created":"2015-12-05 00:54:04.000000000","uploader":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"ref":"refs/changes/13/253313/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/13/253313/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/13/253313/2"}}},"commit":{"parents":[{"commit":"e3a796aae6ab80927c03e35c3838fca64056cc07","subject":"Improve client node_count validation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/e3a796aae6ab80927c03e35c3838fca64056cc07"}]}],"author":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-04 04:10:33.000000000","tz":480},"committer":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2015-12-05 00:51:02.000000000","tz":480},"subject":"Improve client master_count validation","message":"Improve client master_count validation\n\nCurrently client rely master_count validation on server side,\nthis is not good, the patch fix this.\nAlso add unit test for invalid --master-count.\n\nChange-Id: Icf2b850f78989365814437e2c22c994c6ebc1fc1\nRelated-Bug: #1522668\nDepends-On: I21109682358e125ae99326978eee73e09db476ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c8810bef54d12487d06449676f6b49ab1f6970c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c8810bef54d12487d06449676f6b49ab1f6970c7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}