)]}'
{"id":"openstack%2Fpython-magnumclient~267321","triplet_id":"openstack%2Fpython-magnumclient~master~Ib869f6e9a187a3e99a2e38ea19b882c87c195726","project":"openstack/python-magnumclient","branch":"master","topic":"misc-improvements","hashtags":[],"change_id":"Ib869f6e9a187a3e99a2e38ea19b882c87c195726","subject":"Prevent list rcs when bay is not ready","status":"MERGED","created":"2016-01-14 06:04:59.000000000","updated":"2016-01-25 07:56:09.000000000","submitted":"2016-01-25 07:56:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bc9d57a7de0c25459ad4a2a2ebb77f2feaa3ac9a","_number":267321,"virtual_id_number":267321,"owner":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"value":2,"date":"2016-01-25 07:56:09.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":2,"date":"2016-01-22 20:21:34.000000000","_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":1,"date":"2016-01-24 04:11:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-24 04:11:22.000000000","_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":1,"date":"2016-01-24 07:43:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":-1,"date":"2016-01-22 23:04:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-24 04:11:22.000000000","_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-22 20:21:34.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2016-01-22 23:04:31.000000000","updated_by":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"reviewer":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"state":"REVIEWER"},{"updated":"2016-01-24 04:11:05.000000000","updated_by":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"reviewer":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"state":"REVIEWER"},{"updated":"2016-01-24 04:11:22.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2016-01-24 07:43:17.000000000","updated_by":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"reviewer":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"state":"REVIEWER"},{"updated":"2016-01-25 07:56:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ac5ea9532672b75f77a94629e0000e96cd509a37","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2016-01-14 06:04:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6dfc446c2bdc50ce481a86eb1c9a8356dadca0f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-14 06:08:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/21/267321/1/check/gate-python-magnumclient-pep8/6163752/ : SUCCESS in 47s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/21/267321/1/check/gate-python-magnumclient-docs/b0ef8b9//doc/build/html/ : SUCCESS in 56s\n- gate-python-magnumclient-python27 http://logs.openstack.org/21/267321/1/check/gate-python-magnumclient-python27/cd17981/ : SUCCESS in 56s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/21/267321/1/check/gate-python-magnumclient-tox-bandit/cd0668f/ : SUCCESS in 1m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a4c5a5754e0277491008d5583352c65f8a263d8f","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2016-01-22 00:47:59.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"7b73be0a72df378373b7e4e8146ce274dca5d871","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-22 00:55:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/21/267321/2/check/gate-python-magnumclient-pep8/761a2f7/ : SUCCESS in 48s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/21/267321/2/check/gate-python-magnumclient-docs/1cb1612//doc/build/html/ : SUCCESS in 52s\n- gate-python-magnumclient-python27 http://logs.openstack.org/21/267321/2/check/gate-python-magnumclient-python27/103f44e/ : SUCCESS in 1m 00s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/21/267321/2/check/gate-python-magnumclient-tox-bandit/f1f6ec8/ : SUCCESS in 1m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"75ff791aef063e99b08262a65e8c13b96518f46a","author":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"date":"2016-01-22 02:06:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2f86358b57b1b77ef8a706770d036acf49af269b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-22 02:14:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/21/267321/3/check/gate-python-magnumclient-pep8/6aa24fb/ : SUCCESS in 1m 04s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/21/267321/3/check/gate-python-magnumclient-docs/ed12d49//doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-magnumclient-python27 http://logs.openstack.org/21/267321/3/check/gate-python-magnumclient-python27/3bc5b79/ : SUCCESS in 1m 28s\n- gate-python-magnumclient-tox-bandit http://logs.openstack.org/21/267321/3/check/gate-python-magnumclient-tox-bandit/92993b8/ : SUCCESS in 1m 12s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"701cfbdd0da2245fc7a33ccefc2c6db14ff1cf61","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2016-01-22 20:21:34.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"39006779f7ed1447f93bc60ecb60260d4cc3dd68","author":{"_account_id":8143,"name":"Egor Guz","email":"egor.guz@gmail.com","username":"eghobo"},"date":"2016-01-22 23:04:31.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"0761267aea5a8f5739e1ef8345cba7a0a9d5704b","author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"date":"2016-01-24 04:11:05.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"6a6373f2dab1e601d35d020cca128dd289840fdb","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2016-01-24 04:11:22.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"ec5a68e4d298790c323211db41dda28b1ad6df96","author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"date":"2016-01-24 07:43:17.000000000","message":"Patch Set 3: Code-Review+1\n\nThe message can be made a little less developer oriented, but otherwise it looks fine.","accounts_in_message":[],"_revision_number":3},{"id":"c3b978544486ac1a37990d4f41d17c9aa611882a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-25 07:54:15.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"c1cd8934180912994dd35c4c6edf823ebe1f819b","date":"2016-01-25 07:56:09.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"bc350b2ea82dd64833236e12ab55a4273f203fe9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-25 07:56:09.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/21/267321/3/gate/gate-python-magnumclient-docs/c687397//doc/build/html/ : SUCCESS in 58s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/21/267321/3/gate/gate-python-magnumclient-pep8/1fc98e8/ : SUCCESS in 46s\n- gate-python-magnumclient-python27 http://logs.openstack.org/21/267321/3/gate/gate-python-magnumclient-python27/426851d/ : SUCCESS in 54s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6091ddf6c5011e2ff977ab84e582db4eed04e33b","revisions":{"0f9f90f4959f2923057dc027100189ed3e8513b4":{"kind":"REWORK","_number":1,"created":"2016-01-14 06:04:59.000000000","uploader":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"ref":"refs/changes/21/267321/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/21/267321/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/1"}}},"commit":{"parents":[{"commit":"43c8ba55423a845bb07c490b4c008927364945ed","subject":"raise exception when create rc with invalid bay status","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/43c8ba55423a845bb07c490b4c008927364945ed"}]}],"author":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2016-01-14 05:54:16.000000000","tz":480},"committer":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2016-01-14 05:59:27.000000000","tz":480},"subject":"Prevent list rcs when bay is not ready","message":"Prevent list rcs when bay is not ready\n\nPrevent list rcs when bay is not ready, otherwise it will return:\n$ magnum rc-list --bay k8sbay\nERROR: unsupported operand type(s) for +: \u0027NoneType\u0027 and \u0027str\u0027 (HTTP 500)\n\nWhich makes no sense.\n\nAlso added unit test for this case.\n\nChange-Id: Ib869f6e9a187a3e99a2e38ea19b882c87c195726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/0f9f90f4959f2923057dc027100189ed3e8513b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/0f9f90f4959f2923057dc027100189ed3e8513b4"}]},"branch":"refs/heads/master"},"88f577a76bcff2d83ddfd69723a5388e0c055d18":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-01-22 00:47:59.000000000","uploader":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"ref":"refs/changes/21/267321/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/21/267321/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/2"}}},"commit":{"parents":[{"commit":"25459287fcac91296917fa3b99e971d67690718e","subject":"raise exception when create rc with invalid bay status","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/25459287fcac91296917fa3b99e971d67690718e"}]}],"author":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2016-01-14 05:54:16.000000000","tz":480},"committer":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2016-01-16 02:33:59.000000000","tz":480},"subject":"Prevent list rcs when bay is not ready","message":"Prevent list rcs when bay is not ready\n\nPrevent list rcs when bay is not ready, otherwise it will return:\n$ magnum rc-list --bay k8sbay\nERROR: unsupported operand type(s) for +: \u0027NoneType\u0027 and \u0027str\u0027 (HTTP 500)\n\nWhich makes no sense.\n\nAlso added unit test for this case.\n\nChange-Id: Ib869f6e9a187a3e99a2e38ea19b882c87c195726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/88f577a76bcff2d83ddfd69723a5388e0c055d18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/88f577a76bcff2d83ddfd69723a5388e0c055d18"}]},"branch":"refs/heads/master"},"6091ddf6c5011e2ff977ab84e582db4eed04e33b":{"kind":"REWORK","_number":3,"created":"2016-01-22 02:06:41.000000000","uploader":{"_account_id":19133,"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","username":"macrosheep"},"ref":"refs/changes/21/267321/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/21/267321/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/21/267321/3"}}},"commit":{"parents":[{"commit":"99b5279bd1687b83c309d45031973f4b72129c86","subject":"raise exception when create rc with invalid bay status","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/99b5279bd1687b83c309d45031973f4b72129c86"}]}],"author":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2016-01-14 05:54:16.000000000","tz":480},"committer":{"name":"Yang Hongyang","email":"hongyang.yang@easystack.cn","date":"2016-01-16 03:51:51.000000000","tz":480},"subject":"Prevent list rcs when bay is not ready","message":"Prevent list rcs when bay is not ready\n\nPrevent list rcs when bay is not ready, otherwise it will return:\n$ magnum rc-list --bay k8sbay\nERROR: unsupported operand type(s) for +: \u0027NoneType\u0027 and \u0027str\u0027 (HTTP 500)\n\nWhich makes no sense.\n\nAlso added unit test for this case.\n\nChange-Id: Ib869f6e9a187a3e99a2e38ea19b882c87c195726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/6091ddf6c5011e2ff977ab84e582db4eed04e33b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/6091ddf6c5011e2ff977ab84e582db4eed04e33b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}