)]}'
{"id":"openstack%2Fpython-magnumclient~294461","triplet_id":"openstack%2Fpython-magnumclient~master~I8c27976ab8a1ac395f816f13a1a562fe2fad06f0","project":"openstack/python-magnumclient","branch":"master","topic":"rc-param","hashtags":[],"change_id":"I8c27976ab8a1ac395f816f13a1a562fe2fad06f0","subject":"Add limit/sort-key/sort/dir features for rc-list","status":"ABANDONED","created":"2016-03-18 08:52:57.000000000","updated":"2016-04-08 09:31:02.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"40a24186b2630c94f6ca1089648bf010f541a081","_number":294461,"virtual_id_number":294461,"owner":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"date":"2016-03-21 10:01:51.000000000","_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":1,"date":"2016-03-18 08:59:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-04-08 09:18:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},{"value":-1,"date":"2016-03-19 20:13:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2016-03-25 02:38:59.000000000","_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-18 08:59:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-19 20:13:25.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2016-03-25 02:38:59.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2016-04-08 09:18:03.000000000","updated_by":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"reviewer":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"state":"REVIEWER"}],"messages":[{"id":"835f02a5c2a696e749a2a1a2c175c98db3062293","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-03-18 08:52:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87ea4fbc7313847af11c98cf8fd0d8f34974248c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 08:59:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-pep8 http://logs.openstack.org/61/294461/1/check/gate-python-magnumclient-pep8/144343e/ : SUCCESS in 4m 27s\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/61/294461/1/check/gate-python-magnumclient-docs/a0c24f7//doc/build/html/ : SUCCESS in 3m 15s\n- gate-python-magnumclient-python27 http://logs.openstack.org/61/294461/1/check/gate-python-magnumclient-python27/07f10a2/ : SUCCESS in 4m 01s\n- gate-python-magnumclient-python34 http://logs.openstack.org/61/294461/1/check/gate-python-magnumclient-python34/880392d/ : SUCCESS in 2m 31s","accounts_in_message":[],"_revision_number":1},{"id":"cb7de0318672efba5ab5db83dfb599529fddc166","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2016-03-19 20:07:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"255bc63a32ad476fb1303f3692bab6cdb2a487a2","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2016-03-19 20:13:25.000000000","message":"Patch Set 1: Code-Review-1\n\nDo you think we also need some tests here for rc-list with limits, sort_key and sort_dir specified ?\n\nhttps://github.com/openstack/python-magnumclient/blob/master/magnumclient/tests/v1/test_replicationcontrollers.py","accounts_in_message":[],"_revision_number":1},{"id":"77c26d76cc4c59be76fb28f7a5495ae6d89f5e55","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-03-21 10:01:51.000000000","message":"Patch Set 1:\n\nHi, Vilobh,\n\nThanks for your review.\nYes, I also think we should enhance the test cases, no only for ReplicationControllerManager.list() but also for all *Manager.list() methods, as I found there no coverage test at all for all these methods to cover the filter parameters. So, I launched a new bug (#1559838) to track them.","accounts_in_message":[],"_revision_number":1},{"id":"ad9e0d0bb5610f5296979f5809d34734237cb775","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-03-25 02:47:20.000000000","message":"Patch Set 1:\n\nHi, Vilobh,\nI\u0027m not sure if i should abandon this patch (and the related patch [2]) or not, as Lu said the Pod/Service/ReplicationController APIs are going to deprecate.\n[1] https://bugs.launchpad.net/magnum/+bug/1559960\n[2] https://review.openstack.org/#/c/295201/","accounts_in_message":[],"_revision_number":1},{"id":"50b446f0a5c9c5d363de7aec933add4bb63338c3","author":{"_account_id":12053,"name":"Hua Wang","email":"wanghua.humble@gmail.com","username":"humble00"},"date":"2016-04-08 09:18:03.000000000","message":"Patch Set 1: Code-Review-1\n\nPod, Service and ReplicationController will be removed from Magnum api soon,  so i think it is not necessary to fix bugs about them now.","accounts_in_message":[],"_revision_number":1},{"id":"fee8a5edbfe136f63e11f79b733be391b5bd153d","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-04-08 09:30:54.000000000","message":"Patch Set 1:\n\nI will abandon it. Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"21d46f43c07b087cdd5d7dc66c44ca97dd7caefe","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-04-08 09:31:02.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"803d4cfc4e8d91c3f2b4a6e2fe6ef8b15c0db905","revisions":{"803d4cfc4e8d91c3f2b4a6e2fe6ef8b15c0db905":{"kind":"REWORK","_number":1,"created":"2016-03-18 08:52:57.000000000","uploader":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"ref":"refs/changes/61/294461/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/61/294461/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/61/294461/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/61/294461/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/61/294461/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/61/294461/1"}}},"commit":{"parents":[{"commit":"c991639a6b24c34350945d653c2620b7d9c42d10","subject":"Fix incorrect initialization of OrderedDict","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c991639a6b24c34350945d653c2620b7d9c42d10"}]}],"author":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-03-18 08:35:16.000000000","tz":-240},"committer":{"name":"xiexs","email":"xiexs@cn.fujitsu.com","date":"2016-03-18 08:41:07.000000000","tz":-240},"subject":"Add limit/sort-key/sort/dir features for rc-list","message":"Add limit/sort-key/sort/dir features for rc-list\n\nThe parameters \u0027limit\u0027, \u0027sort_key\u0027 and \u0027sort_dir\u0027 has already\nbeen supported by magnum, so this patch tries to add support\nof them for rc-list.\n\nChange-Id: I8c27976ab8a1ac395f816f13a1a562fe2fad06f0\nCloses-Bug: #1558961\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/803d4cfc4e8d91c3f2b4a6e2fe6ef8b15c0db905"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/803d4cfc4e8d91c3f2b4a6e2fe6ef8b15c0db905"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
