)]}'
{"id":"openstack%2Fpython-magnumclient~295113","triplet_id":"openstack%2Fpython-magnumclient~master~I5a0dea75fdb9d96b4803a70e8ea069072c9acc00","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1559909","hashtags":[],"change_id":"I5a0dea75fdb9d96b4803a70e8ea069072c9acc00","subject":"Make \"--name\" become required when creating the baymodel","status":"ABANDONED","created":"2016-03-21 08:18:58.000000000","updated":"2016-04-05 02:02:47.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aef1369416e54733aa1f269664d3b22283120590","_number":295113,"virtual_id_number":295113,"owner":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-03-21 08:32:50.000000000","_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"value":1,"date":"2016-03-21 08:31:42.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"all":[{"value":-1,"date":"2016-03-22 09:53:59.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-03-21 08:22:47.000000000","_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-21 08:22:47.000000000","updated_by":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"reviewer":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"state":"REVIEWER"},{"updated":"2016-03-21 08:31:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"414cc5e45f1a6c546cb3ab95bd30db9658d2ed58","author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"date":"2016-03-21 08:18:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3e42e3b31e7fc0a2b134e07bad061171744b9cdf","author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"date":"2016-03-21 08:21:03.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"fde3ff89780684e8ee6c73702cc2be1ee059869b","author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"date":"2016-03-21 08:24:26.000000000","message":"Patch Set 2:\n\nI think this is by designed, for bay\u0027s name we allow it to be None too, if you are going to fix them, I think we need to consider them in a whole picture.","accounts_in_message":[],"_revision_number":2},{"id":"71c50dae93eb1d224f8b23059edf6a57b038ae06","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-21 08:31:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/13/295113/2/check/gate-python-magnumclient-docs/f1e9d57//doc/build/html/ : SUCCESS in 2m 01s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/13/295113/2/check/gate-python-magnumclient-pep8/27ec3e1/ : SUCCESS in 1m 30s\n- gate-python-magnumclient-python27 http://logs.openstack.org/13/295113/2/check/gate-python-magnumclient-python27/5bec41c/ : SUCCESS in 1m 37s\n- gate-python-magnumclient-python34 http://logs.openstack.org/13/295113/2/check/gate-python-magnumclient-python34/298a68c/ : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":2},{"id":"86dedd5ee3afb4dae54f2ddcb7b076514944a070","author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"date":"2016-03-21 08:32:50.000000000","message":"Patch Set 2:\n\n@Eli, yes, but I don\u0027t understand why the baymodel name can be created. It isn\u0027t easy to find the baymodel. Or why we need the name attr ? So I think we need to perfect it. I will fix the bay. what do you think?\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"6b2ec0836ca3f2deaad3fc24cc4e519a2619b225","author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"date":"2016-03-21 08:37:00.000000000","message":"Patch Set 2:\n\nI would suggest to send to mailing list to ask why make bay/baymodel\u0027s name to support None, I don\u0027t know the history.\n\nbut to be honest, we require to use pass name when create a bay/baymodel.\nso\n1) align all object creation, for example, bay/baymodel etc..\n2) not only we restrict it from CLI but also we need to restrict it in REST API layer.","accounts_in_message":[],"_revision_number":2},{"id":"4e00591f73f96aa186abbffba6b8b7aff10e3e6f","author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"date":"2016-03-21 08:42:45.000000000","message":"Patch Set 2:\n\n@Eli, Thank you to answer me. I will continue to work it.","accounts_in_message":[],"_revision_number":2},{"id":"f9dfa88e65c837caf1e92ad1405de1b9a0a36580","author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"date":"2016-03-22 09:53:59.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"a48c857d6adf4ed81779a277087aabeb4c7c0d6f","author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"date":"2016-04-05 02:02:47.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8d7ce9c5406ac975ab81f6cc273b496f387aef49","revisions":{"7207b8113cfe74c53374a986c0d3ec803b3b6191":{"kind":"REWORK","_number":1,"created":"2016-03-21 08:18:58.000000000","uploader":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"ref":"refs/changes/13/295113/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/13/295113/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/1"}}},"commit":{"parents":[{"commit":"c991639a6b24c34350945d653c2620b7d9c42d10","subject":"Fix incorrect initialization of OrderedDict","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c991639a6b24c34350945d653c2620b7d9c42d10"}]}],"author":{"name":"wangqun","email":"bjwqun@cn.ibm.com","date":"2016-03-21 08:14:44.000000000","tz":0},"committer":{"name":"wangqun","email":"bjwqun@cn.ibm.com","date":"2016-03-21 08:18:57.000000000","tz":0},"subject":"Make \"--name\" become required when creating the baymodel","message":"Make \"--name\" become required when creating the baymodel\n\nNow we can create the baymodel without name attr, So when we list\nthe baymodel to find the baymodel we need. Its name is None so that\nit isn\u0027t convenient to find the suitable baymodel.\n\nChange-Id: I5a0dea75fdb9d96b4803a70e8ea069072c9acc00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7207b8113cfe74c53374a986c0d3ec803b3b6191"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7207b8113cfe74c53374a986c0d3ec803b3b6191"}]},"branch":"refs/heads/master"},"8d7ce9c5406ac975ab81f6cc273b496f387aef49":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-03-21 08:21:03.000000000","uploader":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"ref":"refs/changes/13/295113/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/13/295113/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/13/295113/2"}}},"commit":{"parents":[{"commit":"c991639a6b24c34350945d653c2620b7d9c42d10","subject":"Fix incorrect initialization of OrderedDict","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c991639a6b24c34350945d653c2620b7d9c42d10"}]}],"author":{"name":"wangqun","email":"bjwqun@cn.ibm.com","date":"2016-03-21 08:14:44.000000000","tz":0},"committer":{"name":"wangqun","email":"bjwqun@cn.ibm.com","date":"2016-03-21 08:20:51.000000000","tz":0},"subject":"Make \"--name\" become required when creating the baymodel","message":"Make \"--name\" become required when creating the baymodel\n\nNow we can create the baymodel without name attr, So when we list\nthe baymodel to find the baymodel we need. Its name is None so that\nit isn\u0027t convenient to find the suitable baymodel.\n\nChange-Id: I5a0dea75fdb9d96b4803a70e8ea069072c9acc00\nCloses-Bug: #1559909\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/8d7ce9c5406ac975ab81f6cc273b496f387aef49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/8d7ce9c5406ac975ab81f6cc273b496f387aef49"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}