)]}'
{"magnumclient/tests/v1/test_bays.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"9339ce9f8f2a865496718e4fa2318e23fae4d085","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        expect \u003d ["},{"line_number":170,"context_line":"            (\u0027GET\u0027, \u0027/v1/bays/?limit\u003d2\u0027, {}, None),"},{"line_number":171,"context_line":"        ]"},{"line_number":172,"context_line":"        self.assertEqual(expect, self.api.calls)"},{"line_number":173,"context_line":"        self.assertThat(bays_listed, matchers.HasLength(2))"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def test_bay_list_with_marker(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_9413635c","line":172,"updated":"2016-03-21 13:10:51.000000000","message":"lots of duplicated code, can you create a private function and let  other cases reuse it?","commit_id":"36e54e31ee0a064ed378141b5489e1fc00b51a81"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"1c22a0418ca73cd15d689f948e9b51ef60c0c3e5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    },"},{"line_number":99,"context_line":"}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"fake_responses_pagination \u003d {"},{"line_number":102,"context_line":"    \u0027/v1/bays/?limit\u003d2\u0027:"},{"line_number":103,"context_line":"    {"},{"line_number":104,"context_line":"        \u0027GET\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_02c0557a","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":25},"updated":"2016-03-23 02:34:28.000000000","message":"fake_responses_pagination and fake_responses_sorting is not needed for this case,\nthese responses can be merged into fake_responses.","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"88f83e1410fd77b8a7cb9747a0eba47680742c38","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    limit\u003dNone, marker\u003dNone,"},{"line_number":167,"context_line":"                                    sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":168,"context_line":"                                    detail\u003dFalse, expect\u003d[]):"},{"line_number":169,"context_line":"        self.api \u003d utils.FakeAPI(fake_resp)"},{"line_number":170,"context_line":"        self.mgr \u003d bays.BayManager(self.api)"},{"line_number":171,"context_line":"        bays_filter \u003d self.mgr.list(limit\u003dlimit, marker\u003dmarker,"},{"line_number":172,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":173,"context_line":"                                    sort_dir\u003dsort_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_6b220903","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":44},"updated":"2016-03-22 04:57:48.000000000","message":"There is nothing help in each test case we change sale.api and self.mgr, we can just use them as private variable.\n\nIt\u0027s not good to change them in each case, I believe the initial reason is we use self.api , and self.mgr in every case without set them.\n\nI doubt that this may bring side effect for other case which using self.api and self.mgr.","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"ea3cc5073f29ce6768c9be35944be4baf4f081d0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    limit\u003dNone, marker\u003dNone,"},{"line_number":167,"context_line":"                                    sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":168,"context_line":"                                    detail\u003dFalse, expect\u003d[]):"},{"line_number":169,"context_line":"        self.api \u003d utils.FakeAPI(fake_resp)"},{"line_number":170,"context_line":"        self.mgr \u003d bays.BayManager(self.api)"},{"line_number":171,"context_line":"        bays_filter \u003d self.mgr.list(limit\u003dlimit, marker\u003dmarker,"},{"line_number":172,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":173,"context_line":"                                    sort_dir\u003dsort_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_765af051","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":44},"updated":"2016-03-22 06:17:36.000000000","message":"To be clear, if you want to change self.api self.mgr in each case, you can just use a local variable. please don\u0027t change self.api, self.mgr in cases cause other case may use the initial value.","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"543ca439c66b1a0e0212da4909cf4226d99519fc","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    limit\u003dNone, marker\u003dNone,"},{"line_number":167,"context_line":"                                    sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":168,"context_line":"                                    detail\u003dFalse, expect\u003d[]):"},{"line_number":169,"context_line":"        self.api \u003d utils.FakeAPI(fake_resp)"},{"line_number":170,"context_line":"        self.mgr \u003d bays.BayManager(self.api)"},{"line_number":171,"context_line":"        bays_filter \u003d self.mgr.list(limit\u003dlimit, marker\u003dmarker,"},{"line_number":172,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":173,"context_line":"                                    sort_dir\u003dsort_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_7678302c","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":44},"in_reply_to":"fa0719c6_6b220903","updated":"2016-03-22 05:53:53.000000000","message":"Hi, Eli,\nThanks for your review.\nActually, I changed them in the private method, just because I added two new fake responses so that we must reassign them based on the actual fake objects respectively.\n\n\u003eI doubt that this may bring side effect for other case which using self.api and self.mgr.\nAnd I think there is no side effect as the setup() method will be executed before each test cases.","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"2b7f6183a2de2a2e6f490ed18c77cf015953442e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    limit\u003dNone, marker\u003dNone,"},{"line_number":167,"context_line":"                                    sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":168,"context_line":"                                    detail\u003dFalse, expect\u003d[]):"},{"line_number":169,"context_line":"        self.api \u003d utils.FakeAPI(fake_resp)"},{"line_number":170,"context_line":"        self.mgr \u003d bays.BayManager(self.api)"},{"line_number":171,"context_line":"        bays_filter \u003d self.mgr.list(limit\u003dlimit, marker\u003dmarker,"},{"line_number":172,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":173,"context_line":"                                    sort_dir\u003dsort_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_9cd245ff","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":44},"in_reply_to":"fa0719c6_765af051","updated":"2016-03-22 07:25:21.000000000","message":"Hi, Eli, \nThanks for your kind reply.\nI really understood what you meant and don\u0027t worry about it as the self.* objects are independent of each other for every test case.\nPlease refer to the following url:\nhttps://docs.python.org/2/library/unittest.html\n\nAnd especially, there are some words for the setup():\nThe setUp() and tearDown() methods allow you to define instructions that will be executed before and after each test method. They are covered in more detail in the section Organizing test code.","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"40671ee424dc5709bfedecd8f84ba9fbef4c6b4a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    limit\u003dNone, marker\u003dNone,"},{"line_number":167,"context_line":"                                    sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":168,"context_line":"                                    detail\u003dFalse, expect\u003d[]):"},{"line_number":169,"context_line":"        self.api \u003d utils.FakeAPI(fake_resp)"},{"line_number":170,"context_line":"        self.mgr \u003d bays.BayManager(self.api)"},{"line_number":171,"context_line":"        bays_filter \u003d self.mgr.list(limit\u003dlimit, marker\u003dmarker,"},{"line_number":172,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":173,"context_line":"                                    sort_dir\u003dsort_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_76f4b086","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":44},"in_reply_to":"fa0719c6_7678302c","updated":"2016-03-22 06:03:47.000000000","message":"yes, I know you changed it, I mean this is not in good manner.","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"1c22a0418ca73cd15d689f948e9b51ef60c0c3e5","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    limit\u003dNone, marker\u003dNone,"},{"line_number":167,"context_line":"                                    sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":168,"context_line":"                                    detail\u003dFalse, expect\u003d[]):"},{"line_number":169,"context_line":"        self.api \u003d utils.FakeAPI(fake_resp)"},{"line_number":170,"context_line":"        self.mgr \u003d bays.BayManager(self.api)"},{"line_number":171,"context_line":"        bays_filter \u003d self.mgr.list(limit\u003dlimit, marker\u003dmarker,"},{"line_number":172,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":173,"context_line":"                                    sort_dir\u003dsort_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_e251e1d9","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":44},"in_reply_to":"fa0719c6_973b3ed1","updated":"2016-03-23 02:34:28.000000000","message":"Related to my above comment, overwriting `self.api` and `self.mgr` is not needed here. we can use self.api without changes.","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"eae13a19e464fae6bd40e5389961e46ae9e47019","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                    limit\u003dNone, marker\u003dNone,"},{"line_number":167,"context_line":"                                    sort_key\u003dNone, sort_dir\u003dNone,"},{"line_number":168,"context_line":"                                    detail\u003dFalse, expect\u003d[]):"},{"line_number":169,"context_line":"        self.api \u003d utils.FakeAPI(fake_resp)"},{"line_number":170,"context_line":"        self.mgr \u003d bays.BayManager(self.api)"},{"line_number":171,"context_line":"        bays_filter \u003d self.mgr.list(limit\u003dlimit, marker\u003dmarker,"},{"line_number":172,"context_line":"                                    sort_key\u003dsort_key,"},{"line_number":173,"context_line":"                                    sort_dir\u003dsort_dir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_973b3ed1","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":44},"in_reply_to":"fa0719c6_9cd245ff","updated":"2016-03-22 07:38:09.000000000","message":"sure, they are in setUp(). I am okay with this, but I just don\u0027t like this manner, if you\u0027d change them in each case,  should remove them in setUp() to avoiding misleading.. but anyway...","commit_id":"20d62b6091bc3300c36c92982066e1923756d7a9"}]}