)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"949fc893ce10acaf10074f5c23539357d8937405","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Only allow semicolons to split in labels"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"labels has mesos_slave_isolation\u003ddocker/runtime,filesystem/linux"},{"line_number":10,"context_line":"If we use the \",\" to split and it will split the mesos_slave_"},{"line_number":11,"context_line":"isolation value to be \u0027docker/runtime\u0027 and \u0027filesystem/linux\u0027."},{"line_number":12,"context_line":"However they is a whole value for mesos_slave_isolation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_22e2abd5","line":9,"updated":"2016-05-05 00:07:28.000000000","message":"@wangqun, I think it is better to solve the problem in a different way. How about adding support for two options:\n* --labels KEY1\u003dVALUE1,KEY2\u003dVALUE2\n* --label KEY\u003dVALUE\nThen, you can use the \"--label\" option if you don\u0027t want the CLI to parse \",\". How about that?","commit_id":"02b40048c727fe5a573b4b286f96492b45be6bb5"},{"author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"change_message_id":"d46a3855d2ee6691892d8eacd8741100a2796219","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Only allow semicolons to split in labels"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"labels has mesos_slave_isolation\u003ddocker/runtime,filesystem/linux"},{"line_number":10,"context_line":"If we use the \",\" to split and it will split the mesos_slave_"},{"line_number":11,"context_line":"isolation value to be \u0027docker/runtime\u0027 and \u0027filesystem/linux\u0027."},{"line_number":12,"context_line":"However they is a whole value for mesos_slave_isolation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_fbc4d592","line":9,"in_reply_to":"1a122d0e_22e2abd5","updated":"2016-05-05 06:00:37.000000000","message":"@hongbin. It\u0027s a good idea. I have submitted the patch again. please help to review it. Thanks","commit_id":"02b40048c727fe5a573b4b286f96492b45be6bb5"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"949fc893ce10acaf10074f5c23539357d8937405","unresolved":false,"context_lines":[{"line_number":11,"context_line":"isolation value to be \u0027docker/runtime\u0027 and \u0027filesystem/linux\u0027."},{"line_number":12,"context_line":"However they is a whole value for mesos_slave_isolation."},{"line_number":13,"context_line":"So we only allow semicolons to split in labels."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1553b512e4e2efa7677efadf44e959f1601d39ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_024b2fb2","line":14,"updated":"2016-05-05 00:07:28.000000000","message":"I think it is better to create a bug for this patch.","commit_id":"02b40048c727fe5a573b4b286f96492b45be6bb5"},{"author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"change_message_id":"d46a3855d2ee6691892d8eacd8741100a2796219","unresolved":false,"context_lines":[{"line_number":11,"context_line":"isolation value to be \u0027docker/runtime\u0027 and \u0027filesystem/linux\u0027."},{"line_number":12,"context_line":"However they is a whole value for mesos_slave_isolation."},{"line_number":13,"context_line":"So we only allow semicolons to split in labels."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1553b512e4e2efa7677efadf44e959f1601d39ad"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_dbc11982","line":14,"in_reply_to":"1a122d0e_024b2fb2","updated":"2016-05-05 06:00:37.000000000","message":"Done","commit_id":"02b40048c727fe5a573b4b286f96492b45be6bb5"}],"magnumclient/common/utils.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"5cfabb62374927f09fabf8e8d286d75140eb9e86","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    if parse_comma:"},{"line_number":90,"context_line":"        # expect multiple invocations of --labels but fall back"},{"line_number":91,"context_line":"        # to either , or ; delimited if only one --labels is specified"},{"line_number":92,"context_line":"        if len(lbls) \u003d\u003d 1:"},{"line_number":93,"context_line":"            lbls \u003d lbls[0].split(\u0027;\u0027)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_9dfc2774","line":91,"range":{"start_line":91,"start_character":24,"end_line":91,"end_character":25},"updated":"2016-05-02 17:33:51.000000000","message":"comment needs updating","commit_id":"25f407e24148dd6fda2f61b263ae25f37c12ffd6"},{"author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"change_message_id":"a419d8343ad8102481162ccc92d045a095da58cd","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    if parse_comma:"},{"line_number":90,"context_line":"        # expect multiple invocations of --labels but fall back"},{"line_number":91,"context_line":"        # to either , or ; delimited if only one --labels is specified"},{"line_number":92,"context_line":"        if len(lbls) \u003d\u003d 1:"},{"line_number":93,"context_line":"            lbls \u003d lbls[0].split(\u0027;\u0027)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_87dae415","line":91,"range":{"start_line":91,"start_character":24,"end_line":91,"end_character":25},"in_reply_to":"1a122d0e_9dfc2774","updated":"2016-05-04 02:20:33.000000000","message":"Done","commit_id":"25f407e24148dd6fda2f61b263ae25f37c12ffd6"}],"magnumclient/tests/test_utils.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"5cfabb62374927f09fabf8e8d286d75140eb9e86","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_format_label_none(self):"},{"line_number":111,"context_line":"        self.assertEqual({}, utils.format_labels(None))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_format_labels_false(self):"},{"line_number":114,"context_line":"        l \u003d utils.format_labels(["},{"line_number":115,"context_line":"            \u0027K1\u003dV1,K2\u003dV2,\u0027"},{"line_number":116,"context_line":"            \u0027K3\u003dV3,K4\u003dV4,\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_9d0a6778","line":113,"updated":"2016-05-02 17:33:51.000000000","message":"I would much prefer the existing tests be modified to use semicolons and new tests added for testing a mix of semi colons and commas.","commit_id":"25f407e24148dd6fda2f61b263ae25f37c12ffd6"},{"author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"change_message_id":"a419d8343ad8102481162ccc92d045a095da58cd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_format_label_none(self):"},{"line_number":111,"context_line":"        self.assertEqual({}, utils.format_labels(None))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_format_labels_false(self):"},{"line_number":114,"context_line":"        l \u003d utils.format_labels(["},{"line_number":115,"context_line":"            \u0027K1\u003dV1,K2\u003dV2,\u0027"},{"line_number":116,"context_line":"            \u0027K3\u003dV3,K4\u003dV4,\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_27c4b03f","line":113,"in_reply_to":"1a122d0e_9d0a6778","updated":"2016-05-04 02:20:33.000000000","message":"@Tom The test_format_labels_semicolon is in the #line 120.\nAnd the test_format_labels_mix_commas_semicolon_false is in the #line 132.","commit_id":"25f407e24148dd6fda2f61b263ae25f37c12ffd6"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"5cfabb62374927f09fabf8e8d286d75140eb9e86","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            \u0027K1\u003dV1,K2\u003dV2,\u0027"},{"line_number":135,"context_line":"            \u0027K3\u003dV3;K4\u003dV4,\u0027"},{"line_number":136,"context_line":"            \u0027K5\u003dV5\u0027], parse_comma\u003dFalse)"},{"line_number":137,"context_line":"        self.assertEqual({\u0027K1\u0027: \u0027V1,K2\u003dV2,K3\u003dV3;K4\u003dV4,K5\u003dV5\u0027}, l)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_format_labels_split_false(self):"},{"line_number":140,"context_line":"        l \u003d utils.format_labels(["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_7d382b3e","line":137,"range":{"start_line":137,"start_character":47,"end_line":137,"end_character":48},"updated":"2016-05-02 17:33:51.000000000","message":"why isn\u0027t K4: V4,K5\u003dV5 in the dict?","commit_id":"25f407e24148dd6fda2f61b263ae25f37c12ffd6"},{"author":{"_account_id":18386,"name":"wangqun","email":"bjwqun@cn.ibm.com","username":"wangqun"},"change_message_id":"a419d8343ad8102481162ccc92d045a095da58cd","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            \u0027K1\u003dV1,K2\u003dV2,\u0027"},{"line_number":135,"context_line":"            \u0027K3\u003dV3;K4\u003dV4,\u0027"},{"line_number":136,"context_line":"            \u0027K5\u003dV5\u0027], parse_comma\u003dFalse)"},{"line_number":137,"context_line":"        self.assertEqual({\u0027K1\u0027: \u0027V1,K2\u003dV2,K3\u003dV3;K4\u003dV4,K5\u003dV5\u0027}, l)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_format_labels_split_false(self):"},{"line_number":140,"context_line":"        l \u003d utils.format_labels(["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_47d0ccf7","line":137,"range":{"start_line":137,"start_character":47,"end_line":137,"end_character":48},"in_reply_to":"1a122d0e_7d382b3e","updated":"2016-05-04 02:20:33.000000000","message":"@Tom, This is to test the mix of commas and semicolon. So here is \";\".","commit_id":"25f407e24148dd6fda2f61b263ae25f37c12ffd6"}]}