)]}'
{"magnumclient/v1/client.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"8693192e20fbc8ad1e4ea652b9ba502c3bcba420","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if endpoint_type:"},{"line_number":48,"context_line":"            interface \u003d endpoint_type"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        if magnum_url and input_auth_token:"},{"line_number":51,"context_line":"            auth_type \u003d \u0027admin_token\u0027"},{"line_number":52,"context_line":"            session \u003d None"},{"line_number":53,"context_line":"            loader_kwargs \u003d dict("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_0a6c429b","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":43},"updated":"2016-04-22 09:21:50.000000000","message":"will this be overwrite too? if you treat endpoint_override as magnum_url?","commit_id":"57cd504e694d48c3436ea78cab1a069c627774c6"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"8693192e20fbc8ad1e4ea652b9ba502c3bcba420","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                auth\u003dauth_plugin, verify\u003d(not insecure))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        client_kwargs \u003d {}"},{"line_number":89,"context_line":"        # fix: os-cloud-config is using endpoint_override instead of magnum_url"},{"line_number":90,"context_line":"        if endpoint_override and not magnum_url:"},{"line_number":91,"context_line":"            magnum_url \u003d endpoint_override"},{"line_number":92,"context_line":"        if magnum_url:"},{"line_number":93,"context_line":"            client_kwargs[\u0027endpoint_override\u0027] \u003d magnum_url"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_4f492c8e","line":91,"range":{"start_line":89,"start_character":0,"end_line":91,"end_character":42},"updated":"2016-04-22 09:21:50.000000000","message":"I think we can change the logic like this:\n        if endpoint_override:\n            client_kwargs[\u0027endpoint_override\u0027] \u003d endpoint_override","commit_id":"57cd504e694d48c3436ea78cab1a069c627774c6"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"8693192e20fbc8ad1e4ea652b9ba502c3bcba420","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        if magnum_url:"},{"line_number":93,"context_line":"            client_kwargs[\u0027endpoint_override\u0027] \u003d magnum_url"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not magnum_url:"},{"line_number":96,"context_line":"            try:"},{"line_number":97,"context_line":"                # Trigger an auth error so that we can throw the exception"},{"line_number":98,"context_line":"                # we always have"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_4fbbec75","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":26},"updated":"2016-04-22 09:21:50.000000000","message":"if not magnum_url or not endpoint_override:\n ...","commit_id":"57cd504e694d48c3436ea78cab1a069c627774c6"}]}