)]}'
{"magnumclient/shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e1fe218061aef38a6a4c36614cc04739c3a539bb","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                            help\u003d\"Do not verify https connections\")"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # The auth-system-plugins might require some extra options"},{"line_number":328,"context_line":"        auth.load_auth_system_opts(parser)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        return parser"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_771f2e08","side":"PARENT","line":328,"range":{"start_line":328,"start_character":13,"end_line":328,"end_character":34},"updated":"2016-07-20 21:57:31.000000000","message":"Why this is removed?","commit_id":"d24e1460b824c1d172c1220eb11c773e23cc5a7a"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"5d3d019dad97efba3130ed6dc0baac25354b4564","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                            help\u003d\"Do not verify https connections\")"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        # The auth-system-plugins might require some extra options"},{"line_number":328,"context_line":"        auth.load_auth_system_opts(parser)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        return parser"},{"line_number":331,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_988befc2","side":"PARENT","line":328,"range":{"start_line":328,"start_character":13,"end_line":328,"end_character":34},"in_reply_to":"dada55a8_771f2e08","updated":"2016-07-20 23:55:40.000000000","message":"I removed \"common.apiclient.auth\" and bring these opts to this file.","commit_id":"d24e1460b824c1d172c1220eb11c773e23cc5a7a"}],"magnumclient/v1/client.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"e1fe218061aef38a6a4c36614cc04739c3a539bb","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                 service_type\u003dDEFAULT_SERVICE_TYPE, service_name\u003dNone,"},{"line_number":81,"context_line":"                 region_name\u003dNone,"},{"line_number":82,"context_line":"                 auth_type\u003d\u0027password\u0027, insecure\u003dFalse, timeout\u003d600,"},{"line_number":83,"context_line":"                 **kwargs):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # We have to keep the api_key are for backwards compat, but let\u0027s"},{"line_number":86,"context_line":"        # remove it from the rest of our code since it\u0027s not a keystone"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_7740ce34","line":83,"updated":"2016-07-20 21:57:31.000000000","message":"This seems to break backward-compatibility. Could you keep the interface the same as before (the order of parameters should be \u0027username\u0027, \u0027api_key\u0027, ....) and add new parameters at the end? \n\n    def __init__(self, username\u003dNone, api_key\u003dNone, project_id\u003dNone,\n                 project_name\u003dNone, auth_url\u003dNone, magnum_url\u003dNone,\n                 endpoint_type\u003dNone, endpoint_override\u003dNone,\n                 service_type\u003dDEFAULT_SERVICE_TYPE,\n                 region_name\u003dNone, input_auth_token\u003dNone,\n                 session\u003dNone, password\u003dNone, auth_type\u003d\u0027password\u0027,\n                 interface\u003d\u0027public\u0027, service_name\u003dNone, insecure\u003dFalse,\n                 user_domain_id\u003dNone, user_domain_name\u003dNone,\n                 project_domain_id\u003dNone, project_domain_name\u003dNone, .....):","commit_id":"03ea6d887346ea4b845e597106ff9b25c43e276a"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"5d3d019dad97efba3130ed6dc0baac25354b4564","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                 service_type\u003dDEFAULT_SERVICE_TYPE, service_name\u003dNone,"},{"line_number":81,"context_line":"                 region_name\u003dNone,"},{"line_number":82,"context_line":"                 auth_type\u003d\u0027password\u0027, insecure\u003dFalse, timeout\u003d600,"},{"line_number":83,"context_line":"                 **kwargs):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # We have to keep the api_key are for backwards compat, but let\u0027s"},{"line_number":86,"context_line":"        # remove it from the rest of our code since it\u0027s not a keystone"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_b8019308","line":83,"in_reply_to":"dada55a8_7740ce34","updated":"2016-07-20 23:55:40.000000000","message":"I introduce \"**kwargs\" to keep backward compatibility, and modify if parameters are required to fix for backward compatibility. Actually there are some un-worked parameters in this arguments before.\n\nI think, it\u0027s better to give necessary parameters to os-client-config directly.","commit_id":"03ea6d887346ea4b845e597106ff9b25c43e276a"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"547f12236a0c45fc8fe399917d2e11b6994451af","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                 service_type\u003dDEFAULT_SERVICE_TYPE, service_name\u003dNone,"},{"line_number":81,"context_line":"                 region_name\u003dNone,"},{"line_number":82,"context_line":"                 auth_type\u003d\u0027password\u0027, insecure\u003dFalse, timeout\u003d600,"},{"line_number":83,"context_line":"                 **kwargs):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # We have to keep the api_key are for backwards compat, but let\u0027s"},{"line_number":86,"context_line":"        # remove it from the rest of our code since it\u0027s not a keystone"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_4f9d2a09","line":83,"in_reply_to":"dada55a8_b8019308","updated":"2016-07-21 01:19:44.000000000","message":"@yuanying,\n\nI don\u0027t think kwargs is enough to make it backward compatible. If this is the code to create a client:\n\n  Client(\"test_name\", \"test_key\")\n\nIn before, it will assign \"test_name\" to username and \"test_key\" to api_key. In the new version, it assigns \"test_name\" to session and \"test_key\" to password.","commit_id":"03ea6d887346ea4b845e597106ff9b25c43e276a"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"5ff916258abf74f020a3edaec50b63e5fcbbc8cc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                 service_type\u003dDEFAULT_SERVICE_TYPE, service_name\u003dNone,"},{"line_number":81,"context_line":"                 region_name\u003dNone,"},{"line_number":82,"context_line":"                 auth_type\u003d\u0027password\u0027, insecure\u003dFalse, timeout\u003d600,"},{"line_number":83,"context_line":"                 **kwargs):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # We have to keep the api_key are for backwards compat, but let\u0027s"},{"line_number":86,"context_line":"        # remove it from the rest of our code since it\u0027s not a keystone"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_8c98d0c1","line":83,"in_reply_to":"dada55a8_b8019308","updated":"2016-07-20 23:58:31.000000000","message":"Ah, I forgot to add \"input_auth_token\" parameter for backwood-compatibility.","commit_id":"03ea6d887346ea4b845e597106ff9b25c43e276a"}]}