)]}'
{"id":"openstack%2Fpython-magnumclient~346146","triplet_id":"openstack%2Fpython-magnumclient~master~I200d146478866bfad66ab8085ab873493e78584f","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1599393","hashtags":[],"change_id":"I200d146478866bfad66ab8085ab873493e78584f","subject":"Rename external_network_id to external_network","status":"ABANDONED","created":"2016-07-22 17:35:05.000000000","updated":"2016-08-18 13:06:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"798071782281620faa74e5a02e92b351bb6e410c","_number":346146,"virtual_id_number":346146,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":1,"date":"2016-07-23 14:34:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-07-26 15:54:59.000000000","_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"date":"2016-08-02 16:32:28.000000000","_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":-1,"date":"2016-07-26 15:19:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-23 14:34:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-07-26 15:19:58.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2016-08-02 16:32:28.000000000","updated_by":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"reviewer":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"state":"REVIEWER"}],"messages":[{"id":"abdf070af825685b10944d31f71daebdf7c7078f","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-07-22 17:35:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a3d7eff55d66b4df5ef3784c1ae61461328f6b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-22 18:22:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/46/346146/1/check/gate-python-magnumclient-docs/a239045//doc/build/html/ : SUCCESS in 3m 39s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/46/346146/1/check/gate-python-magnumclient-pep8/1135ef4/ : FAILURE in 2m 45s\n- gate-python-magnumclient-python27 http://logs.openstack.org/46/346146/1/check/gate-python-magnumclient-python27/e5107bc/ : SUCCESS in 3m 45s\n- gate-python-magnumclient-python34 http://logs.openstack.org/46/346146/1/check/gate-python-magnumclient-python34/6268dfe/ : SUCCESS in 3m 51s\n- gate-python-magnumclient-python35-nv http://logs.openstack.org/46/346146/1/check/gate-python-magnumclient-python35-nv/7c47ffa/ : SUCCESS in 12m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"72079d59b1d9944d3f7f28031c0623346bf473c2","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-07-22 18:46:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"59ceabb05ece726d5a33e1a559e48e06c86aa2fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-22 19:07:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/46/346146/2/check/gate-python-magnumclient-docs/cb8e56c//doc/build/html/ : SUCCESS in 5m 42s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/46/346146/2/check/gate-python-magnumclient-pep8/49084d0/ : SUCCESS in 7m 11s\n- gate-python-magnumclient-python27 http://logs.openstack.org/46/346146/2/check/gate-python-magnumclient-python27/6d6391a/ : SUCCESS in 5m 15s\n- gate-python-magnumclient-python34 http://logs.openstack.org/46/346146/2/check/gate-python-magnumclient-python34/b665298/ : SUCCESS in 6m 14s\n- gate-python-magnumclient-python35-nv http://logs.openstack.org/46/346146/2/check/gate-python-magnumclient-python35-nv/18ec883/ : SUCCESS in 10m 39s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"81246a58aef10a8ce423b5a57b32f0e8260a4b53","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-07-23 14:27:30.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"06ccd981899ecadbc18faa20b8b513726d9e14e3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-23 14:34:22.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs http://docs-draft.openstack.org/46/346146/3/check/gate-python-magnumclient-docs/77c00e9//doc/build/html/ : SUCCESS in 5m 10s\n- gate-python-magnumclient-pep8 http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-pep8/2c49de5/ : SUCCESS in 3m 37s\n- gate-python-magnumclient-python27 http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-python27/2fd6e9b/ : SUCCESS in 4m 02s\n- gate-python-magnumclient-python34 http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-python34/f329bf0/ : SUCCESS in 4m 18s\n- gate-python-magnumclient-python35-nv http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-python35-nv/2d39ca1/ : SUCCESS in 4m 17s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"1a2c0ba9d665c8e0e8c45a1a7115c3da66b6b7f6","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-07-24 15:59:18.000000000","message":"Abandoned\n\ngate tests are failing, may be because of this patch. so currently abandoning","accounts_in_message":[],"_revision_number":3},{"id":"1a150ff98fa777d66c6f8adb8430c1f9ed789137","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-07-26 13:59:12.000000000","message":"Restored\n\nReason of failing of magnum test was not this patch, so restoring.","accounts_in_message":[],"_revision_number":3},{"id":"1c51b9eaf78d458098c71c98ebc02d6a8bb19209","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2016-07-26 15:19:58.000000000","message":"Patch Set 3: Code-Review-1\n\nThis patch will break the backward-compatibility, so we are not able to merge it. See here: https://governance.openstack.org/reference/tags/assert_follows-standard-deprecation.html .","accounts_in_message":[],"_revision_number":3},{"id":"f8ba0f8a1e9c16179f64823ad84d2b153ec17391","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-07-26 15:54:59.000000000","message":"Patch Set 3:\n\nThanks, then following patch also has to be discarded?: \nhttps://review.openstack.org/#/c/346122/\n\nIs there any way to get these changes in the components?\n\nIf no, please mark the bug: #1599393, #1540126 as invalid or won\u0027t fix.","accounts_in_message":[],"_revision_number":3},{"id":"7cb5ea570db0350d818f11296ad0fa89b99f4b90","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-26 16:40:24.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/46/346146/3/check/gate-python-magnumclient-docs-ubuntu-xenial/17dcab5//doc/build/html/ : SUCCESS in 4m 51s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-pep8-ubuntu-xenial/1014936/ : SUCCESS in 5m 11s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-python27-ubuntu-xenial/403324b/ : SUCCESS in 9m 14s\n- gate-python-magnumclient-python34 http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-python34/1bf49c1/ : SUCCESS in 4m 54s\n- gate-python-magnumclient-python35 http://logs.openstack.org/46/346146/3/check/gate-python-magnumclient-python35/a313e51/ : SUCCESS in 9m 44s","accounts_in_message":[],"_revision_number":3},{"id":"885f46751fe40260386cad781c19b9f7b961b443","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2016-08-02 16:32:28.000000000","message":"Patch Set 3:\n\nCould we add an additional external_network param and put a note on external_network_id that it\u0027s being deprecated? I like this patch.","accounts_in_message":[],"_revision_number":3},{"id":"cbfa848ed0bdbcec0b5fd1c95fb77ccb65e7f7f1","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-08-02 17:03:13.000000000","message":"Patch Set 3:\n\n@Ricardo Thanks for the suggestion and discussion on IRC weekly meeting. I will try to find a way and submit the patch.\nI remember there is a way to do this, but the way didn\u0027t work for mandatory parameters.","accounts_in_message":[],"_revision_number":3},{"id":"4dc8398b1071b9d78609d01852a4867913a2a7a5","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-08-18 13:06:33.000000000","message":"Abandoned\n\nWill continue after \"bay to cluster\" conversion","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"073b9215f6cf03aa53876468b7e79b16e4bd53d9","revisions":{"9a224de0d997a4c00106c028950dd945dcdc1239":{"kind":"REWORK","_number":1,"created":"2016-07-22 17:35:05.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/46/346146/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/46/346146/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/1"}}},"commit":{"parents":[{"commit":"adbb8562b9d489e04bbb023c81a4f80e5f0807fe","subject":"Merge \"Increase unit test coverage for module baymodels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/adbb8562b9d489e04bbb023c81a4f80e5f0807fe"}]}],"author":{"name":"yatinkarel","email":"yatin.karel@nectechnologies.in","date":"2016-07-22 17:29:35.000000000","tz":330},"committer":{"name":"yatinkarel","email":"yatin.karel@nectechnologies.in","date":"2016-07-22 17:34:47.000000000","tz":330},"subject":"Rename external_network_id to external_network","message":"Rename external_network_id to external_network\n\nSince both name and id can be used for external network. So\nrename external_network_id with external_network and update\nhelp message for option external_network_id.\n\nChange-Id: I200d146478866bfad66ab8085ab873493e78584f\nPartial-Bug: #1599393\nDepends-On: If041d4da3c264d5a3bf1faba1275c62907eda469\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/9a224de0d997a4c00106c028950dd945dcdc1239"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/9a224de0d997a4c00106c028950dd945dcdc1239"}]},"branch":"refs/heads/master"},"11fdeaff4285b6b10aa8d236d24588c7661704f9":{"kind":"REWORK","_number":2,"created":"2016-07-22 18:46:31.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/46/346146/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/46/346146/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/2"}}},"commit":{"parents":[{"commit":"adbb8562b9d489e04bbb023c81a4f80e5f0807fe","subject":"Merge \"Increase unit test coverage for module baymodels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/adbb8562b9d489e04bbb023c81a4f80e5f0807fe"}]}],"author":{"name":"yatinkarel","email":"yatin.karel@nectechnologies.in","date":"2016-07-22 17:29:35.000000000","tz":330},"committer":{"name":"yatinkarel","email":"yatin.karel@nectechnologies.in","date":"2016-07-22 18:45:16.000000000","tz":330},"subject":"Rename external_network_id to external_network","message":"Rename external_network_id to external_network\n\nSince both name and id can be used for external network. So\nrename external_network_id with external_network and update\nhelp message for option external_network_id.\n\nChange-Id: I200d146478866bfad66ab8085ab873493e78584f\nPartial-Bug: #1599393\nDepends-On: If041d4da3c264d5a3bf1faba1275c62907eda469\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/11fdeaff4285b6b10aa8d236d24588c7661704f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/11fdeaff4285b6b10aa8d236d24588c7661704f9"}]},"branch":"refs/heads/master"},"073b9215f6cf03aa53876468b7e79b16e4bd53d9":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-07-23 14:27:30.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/46/346146/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/46/346146/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/46/346146/3"}}},"commit":{"parents":[{"commit":"adbb8562b9d489e04bbb023c81a4f80e5f0807fe","subject":"Merge \"Increase unit test coverage for module baymodels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/adbb8562b9d489e04bbb023c81a4f80e5f0807fe"}]}],"author":{"name":"yatinkarel","email":"yatin.karel@nectechnologies.in","date":"2016-07-22 17:29:35.000000000","tz":330},"committer":{"name":"yatinkarel","email":"yatin.karel@nectechnologies.in","date":"2016-07-23 14:26:41.000000000","tz":330},"subject":"Rename external_network_id to external_network","message":"Rename external_network_id to external_network\n\nSince both name and id can be used for external network. So\nrename external_network_id with external_network and update\nhelp message for option external_network_id.\n\nChange-Id: I200d146478866bfad66ab8085ab873493e78584f\nPartial-Bug: #1599393\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/073b9215f6cf03aa53876468b7e79b16e4bd53d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/073b9215f6cf03aa53876468b7e79b16e4bd53d9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
