)]}'
{"magnumclient/common/httpclient.py":[{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"3123df91a40f9a141a3d23fd94760561c2cd459a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"API_VERSION \u003d \u0027/v1\u0027"},{"line_number":37,"context_line":"DEFAULT_API_VERSION \u003d \u00271.3\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _extract_error_json(body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1e9b0acb","line":37,"updated":"2016-08-19 15:40:31.000000000","message":"Default should be \u0027latest\u0027, that keyword is used by the api to always select the latest version.  That way we won\u0027t have to keep updating the client each time a micro-version for any api is increased.  I think this is already set somewhere in the client but if you are changing it then please make sure it stays \u0027latest\u0027 by default.","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6f90420b982259c61df551bd3e93d1a96590de0c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"CHUNKSIZE \u003d 1024 * 64  # 64kB"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"API_VERSION \u003d \u0027/v1\u0027"},{"line_number":37,"context_line":"DEFAULT_API_VERSION \u003d \u00271.3\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _extract_error_json(body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1eeab40f","line":37,"in_reply_to":"1ac06dbe_1e9b0acb","updated":"2016-08-22 00:17:36.000000000","message":"Done","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"},{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"3123df91a40f9a141a3d23fd94760561c2cd459a","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Content-Type\u0027, \u0027application/json\u0027)"},{"line_number":356,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Accept\u0027, \u0027application/json\u0027)"},{"line_number":357,"context_line":"        kwargs[\u0027headers\u0027].setdefault("},{"line_number":358,"context_line":"            \u0027OpenStack-API-Version\u0027, \u0027container-infra latest\u0027)"},{"line_number":359,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":360,"context_line":"            kwargs[\u0027data\u0027] \u003d json.dumps(kwargs.pop(\u0027body\u0027))"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_9eceda81","line":358,"updated":"2016-08-19 15:40:31.000000000","message":"\u0027container-infra latest\u0027is already being set here by default.  I don\u0027t see the need for the new constants and settings","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6f90420b982259c61df551bd3e93d1a96590de0c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Content-Type\u0027, \u0027application/json\u0027)"},{"line_number":356,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027Accept\u0027, \u0027application/json\u0027)"},{"line_number":357,"context_line":"        kwargs[\u0027headers\u0027].setdefault("},{"line_number":358,"context_line":"            \u0027OpenStack-API-Version\u0027, \u0027container-infra latest\u0027)"},{"line_number":359,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":360,"context_line":"            kwargs[\u0027data\u0027] \u003d json.dumps(kwargs.pop(\u0027body\u0027))"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_3ef7b0f6","line":358,"in_reply_to":"1ac06dbe_9eceda81","updated":"2016-08-22 00:17:36.000000000","message":"I deleted this line.","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"}],"magnumclient/shell.py":[{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"3123df91a40f9a141a3d23fd94760561c2cd459a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"from magnumclient.v1 import shell as shell_v1"},{"line_number":56,"context_line":"from magnumclient import version"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"DEFAULT_API_VERSION \u003d \u00271.3\u0027"},{"line_number":59,"context_line":"DEFAULT_INTERFACE \u003d \u0027public\u0027"},{"line_number":60,"context_line":"DEFAULT_SERVICE_TYPE \u003d \u0027container-infra\u0027"},{"line_number":61,"context_line":"LAST_KNOWN_API_VERSION \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_3e81a64b","line":58,"updated":"2016-08-19 15:40:31.000000000","message":"default should be \u0027latest\u0027","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6f90420b982259c61df551bd3e93d1a96590de0c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"from magnumclient.v1 import shell as shell_v1"},{"line_number":56,"context_line":"from magnumclient import version"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"DEFAULT_API_VERSION \u003d \u00271.3\u0027"},{"line_number":59,"context_line":"DEFAULT_INTERFACE \u003d \u0027public\u0027"},{"line_number":60,"context_line":"DEFAULT_SERVICE_TYPE \u003d \u0027container-infra\u0027"},{"line_number":61,"context_line":"LAST_KNOWN_API_VERSION \u003d 3"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_7ed92883","line":58,"in_reply_to":"1ac06dbe_3e81a64b","updated":"2016-08-22 00:17:36.000000000","message":"Done","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"}],"magnumclient/tests/test_shell.py":[{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"3123df91a40f9a141a3d23fd94760561c2cd459a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            \u0027region_name\u0027: None, \u0027service_type\u0027: \u0027container-infra\u0027,"},{"line_number":224,"context_line":"            \u0027user_id\u0027: None, \u0027username\u0027: \u0027username\u0027,"},{"line_number":225,"context_line":"            \u0027user_domain_id\u0027: None, \u0027user_domain_name\u0027: None,"},{"line_number":226,"context_line":"            \u0027api_version\u0027: \u00271.3\u0027"},{"line_number":227,"context_line":"        }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @mock.patch(\u0027magnumclient.v1.client.Client\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1e378ab1","line":226,"updated":"2016-08-19 15:40:31.000000000","message":"\u0027latest\u0027","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6f90420b982259c61df551bd3e93d1a96590de0c","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            \u0027region_name\u0027: None, \u0027service_type\u0027: \u0027container-infra\u0027,"},{"line_number":224,"context_line":"            \u0027user_id\u0027: None, \u0027username\u0027: \u0027username\u0027,"},{"line_number":225,"context_line":"            \u0027user_domain_id\u0027: None, \u0027user_domain_name\u0027: None,"},{"line_number":226,"context_line":"            \u0027api_version\u0027: \u00271.3\u0027"},{"line_number":227,"context_line":"        }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @mock.patch(\u0027magnumclient.v1.client.Client\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_dee81c13","line":226,"in_reply_to":"1ac06dbe_1e378ab1","updated":"2016-08-22 00:17:36.000000000","message":"Done","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"}],"magnumclient/tests/v1/test_client.py":[{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"3123df91a40f9a141a3d23fd94760561c2cd459a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        kwargs \u003d self._load_service_type_kwargs()"},{"line_number":52,"context_line":"        kwargs[\u0027endpoint_override\u0027] \u003d None"},{"line_number":53,"context_line":"        kwargs[\u0027session\u0027] \u003d session"},{"line_number":54,"context_line":"        kwargs[\u0027api_version\u0027] \u003d \u00271.3\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return kwargs"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_de55f2c6","line":54,"updated":"2016-08-19 15:40:31.000000000","message":"\u0027latest\u0027","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6f90420b982259c61df551bd3e93d1a96590de0c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        kwargs \u003d self._load_service_type_kwargs()"},{"line_number":52,"context_line":"        kwargs[\u0027endpoint_override\u0027] \u003d None"},{"line_number":53,"context_line":"        kwargs[\u0027session\u0027] \u003d session"},{"line_number":54,"context_line":"        kwargs[\u0027api_version\u0027] \u003d \u00271.3\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return kwargs"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_bee3a032","line":54,"in_reply_to":"1ac06dbe_de55f2c6","updated":"2016-08-22 00:17:36.000000000","message":"Done","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"}],"magnumclient/v1/client.py":[{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"3123df91a40f9a141a3d23fd94760561c2cd459a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DEFAULT_SERVICE_TYPE \u003d \u0027container-infra\u0027"},{"line_number":28,"context_line":"LEGACY_DEFAULT_SERVICE_TYPE \u003d \u0027container\u0027"},{"line_number":29,"context_line":"DEFAULT_API_VERSION \u003d \u00271.3\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _load_session(cloud\u003dNone, insecure\u003dFalse, timeout\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_be69168e","line":29,"updated":"2016-08-19 15:40:31.000000000","message":"\u0027latest\u0027\n\nThis also seems like a lot of constants that would all have to be updated every time a micro-version increased.","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6f90420b982259c61df551bd3e93d1a96590de0c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DEFAULT_SERVICE_TYPE \u003d \u0027container-infra\u0027"},{"line_number":28,"context_line":"LEGACY_DEFAULT_SERVICE_TYPE \u003d \u0027container\u0027"},{"line_number":29,"context_line":"DEFAULT_API_VERSION \u003d \u00271.3\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _load_session(cloud\u003dNone, insecure\u003dFalse, timeout\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1ed11458","line":29,"in_reply_to":"1ac06dbe_be69168e","updated":"2016-08-22 00:17:36.000000000","message":"Done","commit_id":"c416841ea94a4e099b4c4241f9cd55b1798f9eb7"}]}