)]}'
{"magnumclient/tests/v1/test_certificates.py":[{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"d560bff07b144f6e8ca62eb0062d54da92496be7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ac06dbe_db053c46","updated":"2016-08-23 23:06:26.000000000","message":"Add a test that verifies backwards compatibility by using the bay_uuid option","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"},{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"9981f93c7b413b0b2bf83308164fc90187571592","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ac06dbe_5b6479e4","in_reply_to":"1ac06dbe_887a5722","updated":"2016-08-24 15:47:06.000000000","message":"you have logic handles things differently when one or the other is used.  we should have tests for each to provide coverage","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"da9cf066a04eb566a8c27054cc8e5647f932e355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ac06dbe_887a5722","in_reply_to":"1ac06dbe_db053c46","updated":"2016-08-24 00:54:02.000000000","message":"I didn\u0027t think one would actually be needed because it appeared to me that bay_uuid was entirely internal and set via command-line arguments","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"},{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"8c2ebb0d0e8baa2df622fe8241947032c4e38683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1ac06dbe_81e31f05","updated":"2016-08-24 17:49:36.000000000","message":"I missed the seeing the test you kept.  This is looks fine.","commit_id":"1778212482b324e0cac1a2a4b4a6f58e9b2d0871"}],"magnumclient/v1/certificates_shell.py":[{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"d560bff07b144f6e8ca62eb0062d54da92496be7","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DEPRECATION_MESSAGE \u003d ("},{"line_number":21,"context_line":"    \u0027WARNING: Bay commands are deprecated and will be removed in a future \u0027"},{"line_number":22,"context_line":"    \u0027release.\\nUse cluster commands to avoid seeing this message.\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_fb1ab8c4","line":21,"updated":"2016-08-23 23:06:26.000000000","message":"This message should be more specific to this command. In this case they are not using the wrong command, just using the wrong parameter.","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"},{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"9981f93c7b413b0b2bf83308164fc90187571592","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DEPRECATION_MESSAGE \u003d ("},{"line_number":21,"context_line":"    \u0027WARNING: Bay commands are deprecated and will be removed in a future \u0027"},{"line_number":22,"context_line":"    \u0027release.\\nUse cluster commands to avoid seeing this message.\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_1b5b2130","line":21,"in_reply_to":"1ac06dbe_a5de5eda","updated":"2016-08-24 15:47:06.000000000","message":"yeah i like that better","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"da9cf066a04eb566a8c27054cc8e5647f932e355","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"DEPRECATION_MESSAGE \u003d ("},{"line_number":21,"context_line":"    \u0027WARNING: Bay commands are deprecated and will be removed in a future \u0027"},{"line_number":22,"context_line":"    \u0027release.\\nUse cluster commands to avoid seeing this message.\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_a5de5eda","line":21,"in_reply_to":"1ac06dbe_fb1ab8c4","updated":"2016-08-24 00:54:02.000000000","message":"How about \"The bay parameter is deprecated[...] Use the cluster parameter [...]\" instead?","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"2199b7233af58ecbf42c8d2b1abd0b7d5e5238b3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"           required\u003dFalse,"},{"line_number":43,"context_line":"           metavar\u003d\u0027\u003cbay\u003e\u0027,"},{"line_number":44,"context_line":"           help\u003d\u0027ID or name of the bay.\u0027)"},{"line_number":45,"context_line":"@utils.arg(\u0027--cluster\u0027,"},{"line_number":46,"context_line":"           required\u003dFalse,"},{"line_number":47,"context_line":"           metavar\u003d\u0027\u003ccluster\u003e\u0027,"},{"line_number":48,"context_line":"           help\u003d\u0027ID or name of the cluster.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_bb704073","line":45,"updated":"2016-08-23 22:46:18.000000000","message":"I had to use this method of adding args because of the way cliutils seems to work. \n\nThe drawback to this method of adding \"required\" arguments is that they show up as optional in help but at least throw an error if all are missing. Therefore I see 3 solutions:\n\n1) Add a concept of a \"single requirement group\" in cliutils.py which has a \"group\" of requirements that are singly required, i.e. a group of \"bay\" and \"cluster\" would require at least \"bay\" or \"cluster\" to exist in the args list.\n\n2) Just mark bay as deprecated and create new cluster-only commands (This seems less practical but at least shows accurate help text)\n\n3) Wire up the CLI commands without cliutils (I don\u0027t see this as viable)","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"},{"author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"change_message_id":"d560bff07b144f6e8ca62eb0062d54da92496be7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"           required\u003dFalse,"},{"line_number":43,"context_line":"           metavar\u003d\u0027\u003cbay\u003e\u0027,"},{"line_number":44,"context_line":"           help\u003d\u0027ID or name of the bay.\u0027)"},{"line_number":45,"context_line":"@utils.arg(\u0027--cluster\u0027,"},{"line_number":46,"context_line":"           required\u003dFalse,"},{"line_number":47,"context_line":"           metavar\u003d\u0027\u003ccluster\u003e\u0027,"},{"line_number":48,"context_line":"           help\u003d\u0027ID or name of the cluster.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_fb48f8b4","line":45,"in_reply_to":"1ac06dbe_bb704073","updated":"2016-08-23 23:06:26.000000000","message":"I think the current solution works well enough. This is only needed until we remove bay.","commit_id":"b76888f956fbd34c53725a22b1d5fc8e231496f4"}]}