)]}'
{"magnumclient/tests/v1/test_clusters.py":[{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"ccf6b7f5aada6561b90b8ea32abcafcdb0ff2e94","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        self.assertTrue(cluster)\r"},{"line_number":249,"context_line":"\r"},{"line_number":250,"context_line":"    def test_cluster_create_with_keypair(self):\r"},{"line_number":251,"context_line":"        cluster \u003d self.mgr.create(**CREATE_CLUSTER)\r"},{"line_number":252,"context_line":"        expect \u003d [\r"},{"line_number":253,"context_line":"            (\u0027POST\u0027, \u0027/v1/clusters\u0027, {}, CREATE_CLUSTER),\r"},{"line_number":254,"context_line":"        ]\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_44dd9f6f","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":15},"updated":"2016-10-04 15:54:42.000000000","message":"This test looks exactly like the one above it. Should we add a check for the kaypair in the request?","commit_id":"efb9c9c1f058e7eeffb11f6fce7c92cfc9a68d02"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"6dd394a9f976067d450170a9c3dc4693768448b7","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        self.assertTrue(cluster)\r"},{"line_number":249,"context_line":"\r"},{"line_number":250,"context_line":"    def test_cluster_create_with_keypair(self):\r"},{"line_number":251,"context_line":"        cluster \u003d self.mgr.create(**CREATE_CLUSTER)\r"},{"line_number":252,"context_line":"        expect \u003d [\r"},{"line_number":253,"context_line":"            (\u0027POST\u0027, \u0027/v1/clusters\u0027, {}, CREATE_CLUSTER),\r"},{"line_number":254,"context_line":"        ]\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_6ea0b291","line":251,"range":{"start_line":251,"start_character":8,"end_line":251,"end_character":15},"in_reply_to":"1a95cdbc_44dd9f6f","updated":"2016-10-04 17:44:04.000000000","message":"Good catch. I started in one direction on this test and then missed that I basically reverted. Will fix","commit_id":"efb9c9c1f058e7eeffb11f6fce7c92cfc9a68d02"}],"magnumclient/tests/v1/test_clusters_shell.py":[{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"ccf6b7f5aada6561b90b8ea32abcafcdb0ff2e94","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        # Output should be\r"},{"line_number":62,"context_line":"        # +------+------+------------+--------------+--------------+--------+\r"},{"line_number":63,"context_line":"        # | uuid | name | keypair_id | node_count   | master_count | status |\r"},{"line_number":64,"context_line":"        # +------+------+------------+--------------+--------------+--------+\r"},{"line_number":65,"context_line":"        # | x    | x    | x          | x            | x            | x      |\r"},{"line_number":66,"context_line":"        # +------+------+------------+--------------+--------------+--------+\r"},{"line_number":67,"context_line":"        self.assertTrue(mock_list.called)\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_a4bbc30d","line":64,"range":{"start_line":64,"start_character":10,"end_line":64,"end_character":77},"updated":"2016-10-04 15:54:42.000000000","message":"Nice! I like this updated table","commit_id":"efb9c9c1f058e7eeffb11f6fce7c92cfc9a68d02"}],"magnumclient/v1/cluster_templates_shell.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"20076d4fedbd231f41260c8970c0cc26b227d216","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           required\u003dFalse,"},{"line_number":41,"context_line":"           metavar\u003d\u0027\u003ckeypair-id\u003e\u0027,"},{"line_number":42,"context_line":"           help\u003d\u0027The name or UUID of the SSH keypair to load into the\u0027"},{"line_number":43,"context_line":"           \u0027 Bay nodes. This parameter is deprecated and replaced by\u0027"},{"line_number":44,"context_line":"           \u0027 keypair.\u0027)"},{"line_number":45,"context_line":"@utils.arg(\u0027--keypair\u0027,"},{"line_number":46,"context_line":"           required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_2fdd35e0","line":43,"range":{"start_line":43,"start_character":13,"end_line":43,"end_character":16},"updated":"2016-10-07 12:12:41.000000000","message":"What is a bay? I have no idea!","commit_id":"dbe78f634e824d95bd18cb0b6e89ae9b9fdc8fd2"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"b3e630c9e9bb9c9302b73b4bf36b3cfa82f09560","unresolved":false,"context_lines":[{"line_number":40,"context_line":"           required\u003dFalse,"},{"line_number":41,"context_line":"           metavar\u003d\u0027\u003ckeypair-id\u003e\u0027,"},{"line_number":42,"context_line":"           help\u003d\u0027The name or UUID of the SSH keypair to load into the\u0027"},{"line_number":43,"context_line":"           \u0027 Bay nodes. This parameter is deprecated and replaced by\u0027"},{"line_number":44,"context_line":"           \u0027 keypair.\u0027)"},{"line_number":45,"context_line":"@utils.arg(\u0027--keypair\u0027,"},{"line_number":46,"context_line":"           required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_c2cd7b32","line":43,"range":{"start_line":43,"start_character":13,"end_line":43,"end_character":16},"in_reply_to":"1a95cdbc_2fdd35e0","updated":"2016-10-07 16:47:55.000000000","message":"Good point. Fixed a few other spots, too.","commit_id":"dbe78f634e824d95bd18cb0b6e89ae9b9fdc8fd2"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"20076d4fedbd231f41260c8970c0cc26b227d216","unresolved":false,"context_lines":[{"line_number":46,"context_line":"           required\u003dFalse,"},{"line_number":47,"context_line":"           metavar\u003d\u0027\u003ckeypair\u003e\u0027,"},{"line_number":48,"context_line":"           help\u003d\u0027The name or UUID of the SSH keypair to load into the\u0027"},{"line_number":49,"context_line":"           \u0027 Bay nodes.\u0027)"},{"line_number":50,"context_line":"@utils.arg(\u0027--external-network-id\u0027,"},{"line_number":51,"context_line":"           required\u003dTrue,"},{"line_number":52,"context_line":"           metavar\u003d\u0027\u003cexternal-network-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_0fa2394b","line":49,"range":{"start_line":49,"start_character":13,"end_line":49,"end_character":16},"updated":"2016-10-07 12:12:41.000000000","message":"ditto","commit_id":"dbe78f634e824d95bd18cb0b6e89ae9b9fdc8fd2"}],"magnumclient/v1/clusters_shell.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"525fb136569a364ed2023b188c1079016404e14b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    opts \u003d {}"},{"line_number":111,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":112,"context_line":"    opts[\u0027cluster_template_id\u0027] \u003d cluster_template.uuid"},{"line_number":113,"context_line":"    opts[\u0027keypair_id\u0027] \u003d args.keypair or cluster_template.keypair_id"},{"line_number":114,"context_line":"    opts[\u0027node_count\u0027] \u003d args.node_count"},{"line_number":115,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":116,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_157aedbc","line":113,"range":{"start_line":113,"start_character":38,"end_line":113,"end_character":68},"updated":"2016-10-04 11:43:09.000000000","message":"According to the server side patch, if the user hasn\u0027t passed a keypair with cluster-create the cluster-template keypair will be used.\n\nSo this should be removed client side.","commit_id":"efb9c9c1f058e7eeffb11f6fce7c92cfc9a68d02"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"6dd394a9f976067d450170a9c3dc4693768448b7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    opts \u003d {}"},{"line_number":111,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":112,"context_line":"    opts[\u0027cluster_template_id\u0027] \u003d cluster_template.uuid"},{"line_number":113,"context_line":"    opts[\u0027keypair_id\u0027] \u003d args.keypair or cluster_template.keypair_id"},{"line_number":114,"context_line":"    opts[\u0027node_count\u0027] \u003d args.node_count"},{"line_number":115,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":116,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_0efe4e6b","line":113,"range":{"start_line":113,"start_character":38,"end_line":113,"end_character":68},"in_reply_to":"3a98d1f4_157aedbc","updated":"2016-10-04 17:44:04.000000000","message":"Done","commit_id":"efb9c9c1f058e7eeffb11f6fce7c92cfc9a68d02"},{"author":{"_account_id":9095,"name":"Murali Allada","email":"amuralis@hotmail.com","username":"murali.allada"},"change_message_id":"ccf6b7f5aada6561b90b8ea32abcafcdb0ff2e94","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    opts \u003d {}"},{"line_number":111,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":112,"context_line":"    opts[\u0027cluster_template_id\u0027] \u003d cluster_template.uuid"},{"line_number":113,"context_line":"    opts[\u0027keypair_id\u0027] \u003d args.keypair or cluster_template.keypair_id"},{"line_number":114,"context_line":"    opts[\u0027node_count\u0027] \u003d args.node_count"},{"line_number":115,"context_line":"    opts[\u0027master_count\u0027] \u003d args.master_count"},{"line_number":116,"context_line":"    opts[\u0027discovery_url\u0027] \u003d args.discovery_url"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_840327b8","line":113,"range":{"start_line":113,"start_character":38,"end_line":113,"end_character":68},"in_reply_to":"3a98d1f4_157aedbc","updated":"2016-10-04 15:54:42.000000000","message":"Yup! good catch. This should happen on the server side.","commit_id":"efb9c9c1f058e7eeffb11f6fce7c92cfc9a68d02"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"f0dc1ee66ed42863346759848091331579dc3ae7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"           default\u003dNone,"},{"line_number":53,"context_line":"           metavar\u003d\u0027\u003cfields\u003e\u0027,"},{"line_number":54,"context_line":"           help\u003d_(\u0027Comma-separated list of fields to display. \u0027"},{"line_number":55,"context_line":"                  \u0027Available fields: uuid, name, cluster_template_id, \u0027"},{"line_number":56,"context_line":"                  \u0027stack_id, status, master_count, node_count, links, \u0027"},{"line_number":57,"context_line":"                  \u0027create_timeout\u0027"},{"line_number":58,"context_line":"                  )"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_5d6a2a82","line":55,"range":{"start_line":55,"start_character":49,"end_line":55,"end_character":65},"updated":"2016-10-07 17:13:58.000000000","message":"This fix probably should have been in another patch, but no need to get excited about that. Thanks for finding/fixing it.","commit_id":"fe25c07127f2c58555071a34c38d5a516962e382"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"0715f137df862047484bf9451baf902fd920f551","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        exclude_fields\u003d(c.lower() for c in columns))[0]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    labels \u003d columns[:]"},{"line_number":75,"context_line":"    labels[2] \u003d \u0027keypair_id\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    utils.print_list(clusters, columns,"},{"line_number":78,"context_line":"                     {\u0027versions\u0027: magnum_utils.print_list_field(\u0027versions\u0027)},"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_fb2db946","line":75,"updated":"2016-10-07 20:04:52.000000000","message":"This displays keypair_id in the cluster-list so users don\u0027t get confused setting keypair-id but seeing keypair instead","commit_id":"95e9edd0d145fa93e0126fd004ed1e00f61b4662"}]}