)]}'
{"id":"openstack%2Fpython-magnumclient~387732","triplet_id":"openstack%2Fpython-magnumclient~master~I885301d6eb69182f109cdfbfbc771bbbf13beb2a","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1634305","hashtags":[],"change_id":"I885301d6eb69182f109cdfbfbc771bbbf13beb2a","subject":"Add missing options for HTTPClient if auth_token given.","status":"MERGED","created":"2016-10-18 00:24:44.000000000","updated":"2016-10-18 04:41:29.000000000","submitted":"2016-10-18 04:40:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dbd7324695ea6580e015d3ef40745a9774a7646a","_number":387732,"virtual_id_number":387732,"owner":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},{"value":0,"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},{"value":0,"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":2,"date":"2016-10-18 04:40:51.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"},{"value":0,"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":2,"date":"2016-10-18 02:19:21.000000000","_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},{"value":1,"date":"2016-10-18 04:20:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},{"value":2,"date":"2016-10-18 04:36:38.000000000","_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-18 01:19:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"},{"value":0,"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},{"value":0,"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},{"value":1,"date":"2016-10-18 04:36:38.000000000","_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"},{"value":0,"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},{"value":0,"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},{"value":0,"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"},{"value":0,"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},{"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},{"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-18 00:25:28.000000000","updated_by":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"reviewer":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"state":"REVIEWER"},{"updated":"2016-10-18 00:25:40.000000000","updated_by":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"reviewer":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"state":"REVIEWER"},{"updated":"2016-10-18 00:27:26.000000000","updated_by":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"reviewer":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"state":"REVIEWER"},{"updated":"2016-10-18 01:19:02.000000000","updated_by":{"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"},"reviewer":{"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"},"state":"REVIEWER"},{"updated":"2016-10-18 02:19:21.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2016-10-18 04:20:44.000000000","updated_by":{"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},"reviewer":{"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},"state":"REVIEWER"},{"updated":"2016-10-18 04:36:38.000000000","updated_by":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"reviewer":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"state":"REVIEWER"},{"updated":"2016-10-18 04:40:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7f2843ea4d125217336e1525fef4f9c3fd3e9389","author":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"date":"2016-10-18 00:24:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8ca6868b816a868b36ae4c5b951e8baf444896a","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-10-18 00:27:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"27441ee9ac94fc39c4bf21d465b598c87260d4d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 00:28:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/32/387732/1/check/gate-python-magnumclient-docs-ubuntu-xenial/0924fbb//doc/build/html/ : SUCCESS in 2m 24s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/32/387732/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/3c72b6e/ : SUCCESS in 2m 59s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/32/387732/1/check/gate-python-magnumclient-python27-ubuntu-xenial/b35bcfa/ : FAILURE in 3m 07s\n- gate-python-magnumclient-python34 http://logs.openstack.org/32/387732/1/check/gate-python-magnumclient-python34/78d20c1/ : FAILURE in 2m 33s\n- gate-python-magnumclient-python35 http://logs.openstack.org/32/387732/1/check/gate-python-magnumclient-python35/c8e7168/ : FAILURE in 3m 51s","accounts_in_message":[],"_revision_number":1},{"id":"0f4d59ff95a59bcb1a537324b8e834ec849350ec","author":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"date":"2016-10-18 00:48:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"63ba5af495a02568723e5e1d29bbe6d09b43fc84","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 00:52:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/32/387732/2/check/gate-python-magnumclient-docs-ubuntu-xenial/2ce41aa//doc/build/html/ : SUCCESS in 2m 25s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/32/387732/2/check/gate-python-magnumclient-pep8-ubuntu-xenial/98d7f34/ : SUCCESS in 3m 08s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/32/387732/2/check/gate-python-magnumclient-python27-ubuntu-xenial/09d6dcd/ : SUCCESS in 2m 48s\n- gate-python-magnumclient-python34 http://logs.openstack.org/32/387732/2/check/gate-python-magnumclient-python34/2305a7e/ : SUCCESS in 3m 57s\n- gate-python-magnumclient-python35 http://logs.openstack.org/32/387732/2/check/gate-python-magnumclient-python35/8f6f7a9/ : SUCCESS in 2m 48s","accounts_in_message":[],"_revision_number":2},{"id":"4a9b97318da8e625cec0744e195417547c178ca6","author":{"_account_id":22711,"name":"zhengchuanhu","email":"zhengchuan.hu@easystack.cn","username":"zhengchuanhu"},"date":"2016-10-18 01:19:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5840bb5d8fb17182f25bb466ef3880c3cbbfe9b1","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2016-10-18 02:19:21.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c464de3924e455b3dea915e67cf71e266bc2a5ff","author":{"_account_id":20465,"name":"Chetna","email":"ck.khullar@gmail.com","username":"chetna"},"date":"2016-10-18 04:20:44.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"cce824a5fc5bedb3acbf2c71784a9c322748f81e","author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"date":"2016-10-18 04:36:38.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"474a861eb700af1b53076b83f6d827cb513af4ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 04:36:48.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"50f82520d8c67e5c5df5be26734fcf0896f4f101","date":"2016-10-18 04:40:51.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"4a85ccc15af6213d7562b34cb972ea44f5cd369b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 04:40:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/32/387732/2/gate/gate-python-magnumclient-docs-ubuntu-xenial/8a6006e//doc/build/html/ : SUCCESS in 2m 29s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/32/387732/2/gate/gate-python-magnumclient-pep8-ubuntu-xenial/fc546bf/ : SUCCESS in 2m 29s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/32/387732/2/gate/gate-python-magnumclient-python27-ubuntu-xenial/dcb56e1/ : SUCCESS in 2m 40s\n- gate-python-magnumclient-python34 http://logs.openstack.org/32/387732/2/gate/gate-python-magnumclient-python34/42f2034/ : SUCCESS in 4m 02s\n- gate-python-magnumclient-python35 http://logs.openstack.org/32/387732/2/gate/gate-python-magnumclient-python35/2df516f/ : SUCCESS in 2m 45s","accounts_in_message":[],"_revision_number":2},{"id":"ae8fc8621d64067c482fdddb3a3b574f72a805a2","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-10-18 04:41:29.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/newton as commit 14dfc7d61664b03d2b7bed74dd032c60a0d86a19","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7829c8c901da4cb0e6dd821ca0127ddc93e75442","revisions":{"2badde34c32e84fbb9ee4bfe86fd56cb394709d9":{"kind":"REWORK","_number":1,"created":"2016-10-18 00:24:44.000000000","uploader":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"ref":"refs/changes/32/387732/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/32/387732/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/1"}}},"commit":{"parents":[{"commit":"949b280e6bb94a474f626b79954aef2744754c6b","subject":"Merge \"Remove white space between print and ()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/949b280e6bb94a474f626b79954aef2744754c6b"}]}],"author":{"name":"maliki","email":"imran.malik@emc.com","date":"2016-10-18 00:19:17.000000000","tz":-420},"committer":{"name":"maliki","email":"imran.malik@emc.com","date":"2016-10-18 00:24:43.000000000","tz":-420},"subject":"Add missing options for HTTPClient if auth_token given.","message":"Add missing options for HTTPClient if auth_token given.\n\nThe insecure client options and timeout were bypassed\nif auth token was given, as in case of Magnum UI.\nThis is causing SSL error even insecure is set to true\nby Magnum UI and magnum client is unable to skip SSL check\nbecuase insecure option was not passed to HTTPClient.\nThis was caused due to this change :\nhttps://github.com/openstack/python-magnumclient/commit/a374b9f99cabd78f93603860425517d45b6290fa#diff-c8d8ebbd1f15e85c914906c6357e0a5f\nAs a consequence, any HTTPS based connections to magnum endpoint\nfail. With this patch, the missing options to HTTPClient are\ncorrectly passed to and SSL checks are skipped safely if insecure\nis set to True.\n\nChange-Id: I885301d6eb69182f109cdfbfbc771bbbf13beb2a\nCloses-Bug: #1634305\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/2badde34c32e84fbb9ee4bfe86fd56cb394709d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/2badde34c32e84fbb9ee4bfe86fd56cb394709d9"}]},"branch":"refs/heads/master"},"7829c8c901da4cb0e6dd821ca0127ddc93e75442":{"kind":"REWORK","_number":2,"created":"2016-10-18 00:48:01.000000000","uploader":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"ref":"refs/changes/32/387732/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/32/387732/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/32/387732/2"}}},"commit":{"parents":[{"commit":"949b280e6bb94a474f626b79954aef2744754c6b","subject":"Merge \"Remove white space between print and ()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/949b280e6bb94a474f626b79954aef2744754c6b"}]}],"author":{"name":"maliki","email":"imran.malik@emc.com","date":"2016-10-18 00:19:17.000000000","tz":-420},"committer":{"name":"maliki","email":"imran.malik@emc.com","date":"2016-10-18 00:47:53.000000000","tz":-420},"subject":"Add missing options for HTTPClient if auth_token given.","message":"Add missing options for HTTPClient if auth_token given.\n\nThe insecure client options and timeout were bypassed\nif auth token was given, as in case of Magnum UI.\nThis is causing SSL error even insecure is set to true\nby Magnum UI and magnum client is unable to skip SSL check\nbecuase insecure option was not passed to HTTPClient.\nThis was caused due to this change :\nhttps://github.com/openstack/python-magnumclient/commit/a374b9f99cabd78f93603860425517d45b6290fa#diff-c8d8ebbd1f15e85c914906c6357e0a5f\nAs a consequence, any HTTPS based connections to magnum endpoint\nfail. With this patch, the missing options to HTTPClient are\ncorrectly passed to and SSL checks are skipped safely if insecure\nis set to True.\n\nChange-Id: I885301d6eb69182f109cdfbfbc771bbbf13beb2a\nCloses-Bug: #1634305\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7829c8c901da4cb0e6dd821ca0127ddc93e75442"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7829c8c901da4cb0e6dd821ca0127ddc93e75442"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
