)]}'
{"id":"openstack%2Fpython-magnumclient~387789","triplet_id":"openstack%2Fpython-magnumclient~stable%2Fnewton~I885301d6eb69182f109cdfbfbc771bbbf13beb2a","project":"openstack/python-magnumclient","branch":"stable/newton","topic":"bug/1634305","hashtags":[],"change_id":"I885301d6eb69182f109cdfbfbc771bbbf13beb2a","subject":"Add missing options for HTTPClient if auth_token given.","status":"MERGED","created":"2016-10-18 04:41:28.000000000","updated":"2016-10-18 22:25:42.000000000","submitted":"2016-10-18 22:25:42.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"507656b8a79d12fda998207be9edec5f92231733","_number":387789,"virtual_id_number":387789,"owner":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":2,"date":"2016-10-18 22:25:42.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":2,"date":"2016-10-18 22:22:54.000000000","_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":1,"date":"2016-10-18 05:03:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-18 16:21:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":1,"date":"2016-10-18 04:42:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":2,"date":"2016-10-18 09:27:39.000000000","_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":1,"date":"2016-10-18 22:22:54.000000000","_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"date":"2016-10-18 04:42:42.000000000","_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},{"value":0,"date":"2016-10-18 22:18:37.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"date":"2016-10-18 04:42:55.000000000","_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"value":0,"date":"2016-10-18 04:42:50.000000000","_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-18 04:42:42.000000000","updated_by":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"reviewer":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"state":"REVIEWER"},{"updated":"2016-10-18 04:42:50.000000000","updated_by":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"reviewer":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"state":"REVIEWER"},{"updated":"2016-10-18 04:42:55.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2016-10-18 05:03:34.000000000","updated_by":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"reviewer":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"state":"REVIEWER"},{"updated":"2016-10-18 09:27:39.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2016-10-18 16:21:08.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"state":"REVIEWER"},{"updated":"2016-10-18 22:18:37.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2016-10-18 22:22:54.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2016-10-18 22:25:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8fb2982a23ac900bf96abd2a5ca7b15166c0da01","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-10-18 04:41:28.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"89f0eac3f988c3c271a51d6a343aa57ba3996acd","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-10-18 04:42:36.000000000","message":"Patch Set 1: Code-Review+1\n\nThis bug makes the Horizon integration non functional when using self signed certs. Cherry picking this since we (and potentially others) heavily depend on this.","accounts_in_message":[],"_revision_number":1},{"id":"3ddc3b8a6ced1972b9ec5e8d21089ec8ab7a43ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 04:47:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/89/387789/1/check/gate-python-magnumclient-docs-ubuntu-xenial/cd326f4//doc/build/html/ : SUCCESS in 3m 16s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/89/387789/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/da5b791/ : SUCCESS in 2m 13s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/89/387789/1/check/gate-python-magnumclient-python27-ubuntu-xenial/ce18371/ : SUCCESS in 2m 14s\n- gate-python-magnumclient-python34 http://logs.openstack.org/89/387789/1/check/gate-python-magnumclient-python34/b7ca82f/ : SUCCESS in 2m 47s\n- gate-python-magnumclient-python35 http://logs.openstack.org/89/387789/1/check/gate-python-magnumclient-python35/182e477/ : SUCCESS in 2m 14s","accounts_in_message":[],"_revision_number":1},{"id":"df742025c8269925027f44d03b493fa80c132afa","author":{"_account_id":12609,"name":"Imran Hayder Malik","email":"hayderimran7@gmail.com","username":"hayderimran7"},"date":"2016-10-18 05:03:34.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"bb2ba8e2437a6ceb045e6aacbfdcadfa13888f41","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2016-10-18 09:27:39.000000000","message":"Patch Set 1: Code-Review+2\n\nThis is a critical bug to be fixed in newton also.","accounts_in_message":[],"_revision_number":1},{"id":"72f778e1efc96333801a04983cd3c80e586ab36a","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-10-18 16:21:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a9c4ce1590f8ca788c1afa88c1fceb2ee3b49c8a","author":{"_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"},"date":"2016-10-18 17:00:13.000000000","message":"Patch Set 1:\n\n+1","accounts_in_message":[],"_revision_number":1},{"id":"c7f034c27205b780b6931ad910405a67d635d933","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2016-10-18 22:22:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ed03de02515bb47a9bc7f722754950afb21b04ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 22:23:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"cea2c7934faf251dcccfbb5a646128e5d375c417","date":"2016-10-18 22:25:42.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"108e6e3de020c14bd12e67201c696fa787ce70a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-18 22:25:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/89/387789/1/gate/gate-python-magnumclient-docs-ubuntu-xenial/b554765//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/89/387789/1/gate/gate-python-magnumclient-pep8-ubuntu-xenial/fd20ca3/ : SUCCESS in 2m 09s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/89/387789/1/gate/gate-python-magnumclient-python27-ubuntu-xenial/e23695b/ : SUCCESS in 2m 26s\n- gate-python-magnumclient-python34 http://logs.openstack.org/89/387789/1/gate/gate-python-magnumclient-python34/88cb057/ : SUCCESS in 2m 15s\n- gate-python-magnumclient-python35 http://logs.openstack.org/89/387789/1/gate/gate-python-magnumclient-python35/75b3842/ : SUCCESS in 2m 17s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"14dfc7d61664b03d2b7bed74dd032c60a0d86a19","revisions":{"14dfc7d61664b03d2b7bed74dd032c60a0d86a19":{"kind":"REWORK","_number":1,"created":"2016-10-18 04:41:28.000000000","uploader":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"ref":"refs/changes/89/387789/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/89/387789/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/89/387789/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/89/387789/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/89/387789/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/89/387789/1"}}},"commit":{"parents":[{"commit":"db984109f8704f06756f5aface1906bf2de2acb8","subject":"Update .gitreview for stable/newton","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/db984109f8704f06756f5aface1906bf2de2acb8"}]}],"author":{"name":"maliki","email":"imran.malik@emc.com","date":"2016-10-18 00:19:17.000000000","tz":-420},"committer":{"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","date":"2016-10-18 04:41:28.000000000","tz":0},"subject":"Add missing options for HTTPClient if auth_token given.","message":"Add missing options for HTTPClient if auth_token given.\n\nThe insecure client options and timeout were bypassed\nif auth token was given, as in case of Magnum UI.\nThis is causing SSL error even insecure is set to true\nby Magnum UI and magnum client is unable to skip SSL check\nbecuase insecure option was not passed to HTTPClient.\nThis was caused due to this change :\nhttps://github.com/openstack/python-magnumclient/commit/a374b9f99cabd78f93603860425517d45b6290fa#diff-c8d8ebbd1f15e85c914906c6357e0a5f\nAs a consequence, any HTTPS based connections to magnum endpoint\nfail. With this patch, the missing options to HTTPClient are\ncorrectly passed to and SSL checks are skipped safely if insecure\nis set to True.\n\nChange-Id: I885301d6eb69182f109cdfbfbc771bbbf13beb2a\nCloses-Bug: #1634305\n(cherry picked from commit 7829c8c901da4cb0e6dd821ca0127ddc93e75442)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/14dfc7d61664b03d2b7bed74dd032c60a0d86a19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/14dfc7d61664b03d2b7bed74dd032c60a0d86a19"}]},"branch":"refs/heads/stable/newton"}},"requirements":[],"submit_records":[],"submit_requirements":[]}