)]}'
{"magnumclient/common/cliutils.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"503e2a3ebec2890f5b0cee18663cbd348b8f006d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(MissingArgs, self).__init__(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def deprecation_message(preamble, new_name):"},{"line_number":47,"context_line":"    msg \u003d (\u0027 This parameter is deprecated and will be removed in a future \u0027"},{"line_number":48,"context_line":"           \u0027release. Use --%s instead.\u0027 % new_name)"},{"line_number":49,"context_line":"    return preamble + msg"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_7a4a0385","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":43},"updated":"2016-10-28 05:25:57.000000000","message":"After patch 3(https://review.openstack.org/#/c/388240) this method is not required.","commit_id":"bc0555c0927e78629b7dd8d1bcfaa2be1b798196"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"b8df849ae9b22fc0d98c3ca683df4554413b00ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(MissingArgs, self).__init__(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def deprecation_message(preamble, new_name):"},{"line_number":47,"context_line":"    msg \u003d (\u0027 This parameter is deprecated and will be removed in a future \u0027"},{"line_number":48,"context_line":"           \u0027release. Use --%s instead.\u0027 % new_name)"},{"line_number":49,"context_line":"    return preamble + msg"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_272f81f7","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":43},"in_reply_to":"ba5da102_7a4a0385","updated":"2016-10-28 17:20:53.000000000","message":"Good catch, will remove","commit_id":"bc0555c0927e78629b7dd8d1bcfaa2be1b798196"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"396f548551b71009b51490d4f29fd7f6ee24fcc1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(MissingArgs, self).__init__(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_args(fn, *args, **kwargs):"},{"line_number":47,"context_line":"    \"\"\"Check that the supplied args are sufficient for calling a function."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    \u003e\u003e\u003e validate_args(lambda a: None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_bd0b1a7c","line":46,"updated":"2016-11-11 04:41:52.000000000","message":"Where is deprecation_message message now(as it is now to be included after discussion of argparse bug with Spyros)?\nWhen i check out both patches i can find it. But here when i check the difference from base can\u0027t find. Please check.\nIf you find, fix the Space in beginning\nmsg \u003d (\u0027 This parameter is deprecated and","commit_id":"fe03de57a224d1d6d5847168dba9f163afa527c3"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"85b6f927d8c00284c7c30eeb82e8fcbdb29b50c1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(MissingArgs, self).__init__(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_args(fn, *args, **kwargs):"},{"line_number":47,"context_line":"    \"\"\"Check that the supplied args are sufficient for calling a function."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    \u003e\u003e\u003e validate_args(lambda a: None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_435d8947","line":46,"in_reply_to":"9a629dbe_002e48fa","updated":"2016-11-14 04:09:29.000000000","message":"\u003c\u003c It is, and it does look a little odd but it was a simple solution :)\n\nWhat about following:-\ndef deprecation_message(preamble, new_name):\n    msg \u003d (\u0027%s This parameter is deprecated and will be removed in a future \u0027\n           \u0027release. Use --%s instead.\u0027 % (preamble, new_name))\n    return msg\n\n\u003c\u003c\u003c I removed deprecation_message due to your earlier comment, but then didn\u0027t re-add after I moved the other patch back to showing old and new parameters in help text. I think this should be fine since the new patch can add it after a rebase if necessary.\n\nOk, then rebase it so that it\u0027s visible to other reviewers also.","commit_id":"fe03de57a224d1d6d5847168dba9f163afa527c3"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"be32cdd1caede4f9140addced30acb292573a61d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(MissingArgs, self).__init__(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_args(fn, *args, **kwargs):"},{"line_number":47,"context_line":"    \"\"\"Check that the supplied args are sufficient for calling a function."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    \u003e\u003e\u003e validate_args(lambda a: None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_272c06ab","line":46,"in_reply_to":"9a629dbe_435d8947","updated":"2016-11-14 15:48:32.000000000","message":"Done","commit_id":"fe03de57a224d1d6d5847168dba9f163afa527c3"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"e18e3db6f2e0719381e6ae42aee05890b6f64397","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(MissingArgs, self).__init__(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_args(fn, *args, **kwargs):"},{"line_number":47,"context_line":"    \"\"\"Check that the supplied args are sufficient for calling a function."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    \u003e\u003e\u003e validate_args(lambda a: None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_002e48fa","line":46,"in_reply_to":"9a629dbe_7d66e22a","updated":"2016-11-11 16:59:00.000000000","message":"It is, and it does look a little odd but it was a simple solution :)\n\nI removed deprecation_message due to your earlier comment, but then didn\u0027t re-add after I moved the other patch back to showing old and new parameters in help text. I think this should be fine since the new patch can add it after a rebase if necessary.","commit_id":"fe03de57a224d1d6d5847168dba9f163afa527c3"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0eac777391749e60d817d4630b2de0c4801d1934","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        super(MissingArgs, self).__init__(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_args(fn, *args, **kwargs):"},{"line_number":47,"context_line":"    \"\"\"Check that the supplied args are sufficient for calling a function."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    \u003e\u003e\u003e validate_args(lambda a: None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_7d66e22a","line":46,"in_reply_to":"9a629dbe_bd0b1a7c","updated":"2016-11-11 04:45:56.000000000","message":"I think it\u0027s for space between WARNING: and message, but it looks odd.","commit_id":"fe03de57a224d1d6d5847168dba9f163afa527c3"}],"magnumclient/shell.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"6493902df792f9985073fe62f1cc14932c59deeb","unresolved":false,"context_lines":[{"line_number":645,"context_line":"            return"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        for (old_info, new_info, required) in func.deprecated_groups:"},{"line_number":648,"context_line":"            dep_param \u003d old_info[0][0]"},{"line_number":649,"context_line":"            new_param \u003d new_info[0][0]"},{"line_number":650,"context_line":"            dep_value, new_value \u003d None, None"},{"line_number":651,"context_line":"            for i in range(len(argv)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_934968ba","line":648,"updated":"2016-10-19 07:52:42.000000000","message":"I think we should use consistent names like either(dep_info, dep_param,dep_value) or (old_info, old_param, old_value)","commit_id":"89799e4e3a6afa3011c4aad6424dad8bc21fac20"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"a92d394f2b3c906c18cbee5fa8826716caf40a4d","unresolved":false,"context_lines":[{"line_number":645,"context_line":"            return"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        for (old_info, new_info, required) in func.deprecated_groups:"},{"line_number":648,"context_line":"            dep_param \u003d old_info[0][0]"},{"line_number":649,"context_line":"            new_param \u003d new_info[0][0]"},{"line_number":650,"context_line":"            dep_value, new_value \u003d None, None"},{"line_number":651,"context_line":"            for i in range(len(argv)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_737e626b","line":648,"in_reply_to":"fa6399be_934968ba","updated":"2016-10-20 07:30:11.000000000","message":"Agreed. Will fix in next patch","commit_id":"89799e4e3a6afa3011c4aad6424dad8bc21fac20"}],"magnumclient/tests/v1/shell_test_base.py":[{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"e5ccab959a54b62b28777890d267e012746c8f07","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \".*?^Try \u0027magnum help \","},{"line_number":52,"context_line":"        ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _deprecated_warning \u003d ["},{"line_number":55,"context_line":"        \u0027.*(WARNING: The \\-\\-[a-z\\-]*-id parameter is deprecated)+\u0027,"},{"line_number":56,"context_line":"        \u0027.*(Use the \\-\\-[a-z\\-]* parameter to avoid seeing this message)+\u0027"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    _few_argument_error \u003d ["},{"line_number":60,"context_line":"        \u0027.*?^usage: magnum \u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_9cc9a05d","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":5},"updated":"2016-11-14 17:00:38.000000000","message":"Although I understand this usage is informative about how to use this feature, it would be better to separate this into a child patch. That way you have one patch that adds the deprecation mutex feature, and another patch that implements it for the first time.","commit_id":"b3f6b0577cf4e1fb0645cd1fc62073dd0c50eaab"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"5e1685058ed7aa874208e515ab250a196e8ba2c6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \".*?^Try \u0027magnum help \","},{"line_number":52,"context_line":"        ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _deprecated_warning \u003d ["},{"line_number":55,"context_line":"        \u0027.*(WARNING: The \\-\\-[a-z\\-]*-id parameter is deprecated)+\u0027,"},{"line_number":56,"context_line":"        \u0027.*(Use the \\-\\-[a-z\\-]* parameter to avoid seeing this message)+\u0027"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    _few_argument_error \u003d ["},{"line_number":60,"context_line":"        \u0027.*?^usage: magnum \u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_ffb52e31","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":5},"in_reply_to":"9a629dbe_1f4ca275","updated":"2016-11-14 17:13:23.000000000","message":"Nevermind, I combined your overall comment with this specific one in my head and misunderstood.","commit_id":"b3f6b0577cf4e1fb0645cd1fc62073dd0c50eaab"},{"author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"change_message_id":"0fef6d4d2881e28c1aba686998bcd4158a55056a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \".*?^Try \u0027magnum help \","},{"line_number":52,"context_line":"        ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _deprecated_warning \u003d ["},{"line_number":55,"context_line":"        \u0027.*(WARNING: The \\-\\-[a-z\\-]*-id parameter is deprecated)+\u0027,"},{"line_number":56,"context_line":"        \u0027.*(Use the \\-\\-[a-z\\-]* parameter to avoid seeing this message)+\u0027"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    _few_argument_error \u003d ["},{"line_number":60,"context_line":"        \u0027.*?^usage: magnum \u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_b18da033","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":5},"in_reply_to":"9a629dbe_1f4ca275","updated":"2016-11-15 16:54:13.000000000","message":"yes please.","commit_id":"b3f6b0577cf4e1fb0645cd1fc62073dd0c50eaab"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"2afa9a38863ecb0dc452fb5bad92117b4e1a7fd0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \".*?^Try \u0027magnum help \","},{"line_number":52,"context_line":"        ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    _deprecated_warning \u003d ["},{"line_number":55,"context_line":"        \u0027.*(WARNING: The \\-\\-[a-z\\-]*-id parameter is deprecated)+\u0027,"},{"line_number":56,"context_line":"        \u0027.*(Use the \\-\\-[a-z\\-]* parameter to avoid seeing this message)+\u0027"},{"line_number":57,"context_line":"    ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    _few_argument_error \u003d ["},{"line_number":60,"context_line":"        \u0027.*?^usage: magnum \u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_1f4ca275","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":5},"in_reply_to":"9a629dbe_9cc9a05d","updated":"2016-11-14 17:08:26.000000000","message":"I have one implementation patch that\u0027s out now. Do you think I should move these strings to that patch?","commit_id":"b3f6b0577cf4e1fb0645cd1fc62073dd0c50eaab"}]}