)]}'
{"magnumclient/v1/baymodels_shell.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"fdc58edb413704599f0764b4e3660eb95ae0a034","unresolved":false,"context_lines":[{"line_number":120,"context_line":"           action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":121,"context_line":"           help\u003d\u0027Indicates whether created bays should have a load balancer \u0027"},{"line_number":122,"context_line":"                \u0027for master nodes or not.\u0027)"},{"line_number":123,"context_line":"@utils.arg(\u0027--floating-ip-disabled\u0027,"},{"line_number":124,"context_line":"           action\u003d\u0027store_false\u0027, default\u003dTrue,"},{"line_number":125,"context_line":"           help\u003d\u0027Indicates whether created bays should have a floating ip\u0027"},{"line_number":126,"context_line":"                \u0027or not.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_cb56eb05","line":123,"updated":"2016-11-22 04:04:41.000000000","message":"Please do this in a backwards compatible way.  If users are passing --floating-ip-enabled then this change doesn\u0027t need to break that.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e3fb5be9ac9e036178e7a1ec3b1e08629ef97a21","unresolved":false,"context_lines":[{"line_number":120,"context_line":"           action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":121,"context_line":"           help\u003d\u0027Indicates whether created bays should have a load balancer \u0027"},{"line_number":122,"context_line":"                \u0027for master nodes or not.\u0027)"},{"line_number":123,"context_line":"@utils.arg(\u0027--floating-ip-disabled\u0027,"},{"line_number":124,"context_line":"           action\u003d\u0027store_false\u0027, default\u003dTrue,"},{"line_number":125,"context_line":"           help\u003d\u0027Indicates whether created bays should have a floating ip\u0027"},{"line_number":126,"context_line":"                \u0027or not.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_8e9401e9","line":123,"in_reply_to":"7a77a97e_cb56eb05","updated":"2016-11-22 05:17:21.000000000","message":"Ok Tony, i will take care this time.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6d79a9ca67d1796150b1a3fb0a752d6faa24cee5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"           help\u003d\u0027Indicates whether created bays should have a load balancer \u0027"},{"line_number":122,"context_line":"                \u0027for master nodes or not.\u0027)"},{"line_number":123,"context_line":"@utils.arg(\u0027--floating-ip-disabled\u0027,"},{"line_number":124,"context_line":"           action\u003d\u0027store_false\u0027, default\u003dTrue,"},{"line_number":125,"context_line":"           help\u003d\u0027Indicates whether created bays should have a floating ip\u0027"},{"line_number":126,"context_line":"                \u0027or not.\u0027)"},{"line_number":127,"context_line":"@utils.deprecated(DEPRECATION_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_9bbaaf70","line":124,"updated":"2016-11-04 06:42:07.000000000","message":"Floating IP is enabled by default.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"89e976b9342b496f3ba15ba0f4a707c1f8a6b733","unresolved":false,"context_lines":[{"line_number":121,"context_line":"           help\u003d\u0027Indicates whether created bays should have a load balancer \u0027"},{"line_number":122,"context_line":"                \u0027for master nodes or not.\u0027)"},{"line_number":123,"context_line":"@utils.arg(\u0027--floating-ip-disabled\u0027,"},{"line_number":124,"context_line":"           action\u003d\u0027store_false\u0027, default\u003dTrue,"},{"line_number":125,"context_line":"           help\u003d\u0027Indicates whether created bays should have a floating ip\u0027"},{"line_number":126,"context_line":"                \u0027or not.\u0027)"},{"line_number":127,"context_line":"@utils.deprecated(DEPRECATION_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_700032ab","line":124,"in_reply_to":"9a629dbe_22585832","updated":"2016-11-09 05:41:48.000000000","message":"Done for stable/newton, here will go with enum approach","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"6890bb4f6b3992a5af0536c1fa4647d97bef8c69","unresolved":false,"context_lines":[{"line_number":121,"context_line":"           help\u003d\u0027Indicates whether created bays should have a load balancer \u0027"},{"line_number":122,"context_line":"                \u0027for master nodes or not.\u0027)"},{"line_number":123,"context_line":"@utils.arg(\u0027--floating-ip-disabled\u0027,"},{"line_number":124,"context_line":"           action\u003d\u0027store_false\u0027, default\u003dTrue,"},{"line_number":125,"context_line":"           help\u003d\u0027Indicates whether created bays should have a floating ip\u0027"},{"line_number":126,"context_line":"                \u0027or not.\u0027)"},{"line_number":127,"context_line":"@utils.deprecated(DEPRECATION_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_aa015f3a","line":124,"in_reply_to":"9a629dbe_700032ab","updated":"2016-11-09 15:53:10.000000000","message":"Thanks!","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"3511e99fba203d71b93337d8e001e938b9ba2216","unresolved":false,"context_lines":[{"line_number":121,"context_line":"           help\u003d\u0027Indicates whether created bays should have a load balancer \u0027"},{"line_number":122,"context_line":"                \u0027for master nodes or not.\u0027)"},{"line_number":123,"context_line":"@utils.arg(\u0027--floating-ip-disabled\u0027,"},{"line_number":124,"context_line":"           action\u003d\u0027store_false\u0027, default\u003dTrue,"},{"line_number":125,"context_line":"           help\u003d\u0027Indicates whether created bays should have a floating ip\u0027"},{"line_number":126,"context_line":"                \u0027or not.\u0027)"},{"line_number":127,"context_line":"@utils.deprecated(DEPRECATION_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_22585832","line":124,"in_reply_to":"ba5da102_8747b04a","updated":"2016-11-08 13:02:52.000000000","message":"If we are going with floating_ip_disabled, I think the arg should be set in a way that makes sense for what it is named, so if the flag is present, floating_ip_disabled should be True. Therefore, this should be `action\u003d\u0027store_true\u0027, default\u003dFalse`. Then, the logic below should be flipped.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"597a93744c063aa596bbae5e3afe1a756b382d6a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"           help\u003d\u0027Indicates whether created bays should have a load balancer \u0027"},{"line_number":122,"context_line":"                \u0027for master nodes or not.\u0027)"},{"line_number":123,"context_line":"@utils.arg(\u0027--floating-ip-disabled\u0027,"},{"line_number":124,"context_line":"           action\u003d\u0027store_false\u0027, default\u003dTrue,"},{"line_number":125,"context_line":"           help\u003d\u0027Indicates whether created bays should have a floating ip\u0027"},{"line_number":126,"context_line":"                \u0027or not.\u0027)"},{"line_number":127,"context_line":"@utils.deprecated(DEPRECATION_MESSAGE)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8747b04a","line":124,"in_reply_to":"ba5da102_9bbaaf70","updated":"2016-11-04 09:29:47.000000000","message":"Yes, floating ip is enabled by default, so we need a way to disable it. passing --floating-ip-disabled will disable it.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ed070b1e14decdc21d1d6d0f39e057343a844e20","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    opts[\u0027registry_enabled\u0027] \u003d args.registry_enabled"},{"line_number":152,"context_line":"    opts[\u0027server_type\u0027] \u003d args.server_type"},{"line_number":153,"context_line":"    opts[\u0027master_lb_enabled\u0027] \u003d args.master_lb_enabled"},{"line_number":154,"context_line":"    opts[\u0027floating_ip_enabled\u0027] \u003d args.floating_ip_disabled"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    baymodel \u003d cs.baymodels.create(**opts)"},{"line_number":157,"context_line":"    _show_baymodel(baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_f6224751","line":154,"range":{"start_line":154,"start_character":10,"end_line":154,"end_character":29},"updated":"2016-11-10 06:31:48.000000000","message":"We can change this param also.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"change_message_id":"6d79a9ca67d1796150b1a3fb0a752d6faa24cee5","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    opts[\u0027registry_enabled\u0027] \u003d args.registry_enabled"},{"line_number":152,"context_line":"    opts[\u0027server_type\u0027] \u003d args.server_type"},{"line_number":153,"context_line":"    opts[\u0027master_lb_enabled\u0027] \u003d args.master_lb_enabled"},{"line_number":154,"context_line":"    opts[\u0027floating_ip_enabled\u0027] \u003d args.floating_ip_disabled"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    baymodel \u003d cs.baymodels.create(**opts)"},{"line_number":157,"context_line":"    _show_baymodel(baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_bbbf735f","line":154,"updated":"2016-11-04 06:42:07.000000000","message":"if floating_ip_disabled is true, then floating_ip will be enabled??","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"89e976b9342b496f3ba15ba0f4a707c1f8a6b733","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    opts[\u0027registry_enabled\u0027] \u003d args.registry_enabled"},{"line_number":152,"context_line":"    opts[\u0027server_type\u0027] \u003d args.server_type"},{"line_number":153,"context_line":"    opts[\u0027master_lb_enabled\u0027] \u003d args.master_lb_enabled"},{"line_number":154,"context_line":"    opts[\u0027floating_ip_enabled\u0027] \u003d args.floating_ip_disabled"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    baymodel \u003d cs.baymodels.create(**opts)"},{"line_number":157,"context_line":"    _show_baymodel(baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_b0300aa0","line":154,"in_reply_to":"9a629dbe_3f3f8fd7","updated":"2016-11-09 05:41:48.000000000","message":"Done for stable/newton, here will go with enum approach.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"fdc58edb413704599f0764b4e3660eb95ae0a034","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    opts[\u0027registry_enabled\u0027] \u003d args.registry_enabled"},{"line_number":152,"context_line":"    opts[\u0027server_type\u0027] \u003d args.server_type"},{"line_number":153,"context_line":"    opts[\u0027master_lb_enabled\u0027] \u003d args.master_lb_enabled"},{"line_number":154,"context_line":"    opts[\u0027floating_ip_enabled\u0027] \u003d args.floating_ip_disabled"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    baymodel \u003d cs.baymodels.create(**opts)"},{"line_number":157,"context_line":"    _show_baymodel(baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_4b349bdd","line":154,"in_reply_to":"9a629dbe_b0300aa0","updated":"2016-11-22 04:04:41.000000000","message":"No you need to get this right on master and then backport that to newton.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"597a93744c063aa596bbae5e3afe1a756b382d6a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    opts[\u0027registry_enabled\u0027] \u003d args.registry_enabled"},{"line_number":152,"context_line":"    opts[\u0027server_type\u0027] \u003d args.server_type"},{"line_number":153,"context_line":"    opts[\u0027master_lb_enabled\u0027] \u003d args.master_lb_enabled"},{"line_number":154,"context_line":"    opts[\u0027floating_ip_enabled\u0027] \u003d args.floating_ip_disabled"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    baymodel \u003d cs.baymodels.create(**opts)"},{"line_number":157,"context_line":"    _show_baymodel(baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_f28108c5","line":154,"in_reply_to":"ba5da102_bbbf735f","updated":"2016-11-04 09:29:47.000000000","message":"Yes, it\u0027s just a way how end user would use it and this needs to be done because by default floating ip is enabled, \nOtherwise server side changes would be required.","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"3511e99fba203d71b93337d8e001e938b9ba2216","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    opts[\u0027registry_enabled\u0027] \u003d args.registry_enabled"},{"line_number":152,"context_line":"    opts[\u0027server_type\u0027] \u003d args.server_type"},{"line_number":153,"context_line":"    opts[\u0027master_lb_enabled\u0027] \u003d args.master_lb_enabled"},{"line_number":154,"context_line":"    opts[\u0027floating_ip_enabled\u0027] \u003d args.floating_ip_disabled"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    baymodel \u003d cs.baymodels.create(**opts)"},{"line_number":157,"context_line":"    _show_baymodel(baymodel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_3f3f8fd7","line":154,"in_reply_to":"ba5da102_f28108c5","updated":"2016-11-08 13:02:52.000000000","message":"Based on my above comment, this should be `\u003d not args.floating_ip_disabled`","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"}],"magnumclient/v1/cluster_templates_shell.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"ed070b1e14decdc21d1d6d0f39e057343a844e20","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    opts[\u0027registry_enabled\u0027] \u003d args.registry_enabled"},{"line_number":147,"context_line":"    opts[\u0027server_type\u0027] \u003d args.server_type"},{"line_number":148,"context_line":"    opts[\u0027master_lb_enabled\u0027] \u003d args.master_lb_enabled"},{"line_number":149,"context_line":"    opts[\u0027floating_ip_enabled\u0027] \u003d args.floating_ip_disabled"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    cluster_template \u003d cs.cluster_templates.create(**opts)"},{"line_number":152,"context_line":"    _show_cluster_template(cluster_template)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_561693f1","line":149,"range":{"start_line":149,"start_character":10,"end_line":149,"end_character":29},"updated":"2016-11-10 06:31:48.000000000","message":"ditto. Change it to floating_ip_disabled","commit_id":"23e20c02748098234390f025aa0040fc96babf8b"}]}